github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-01-30 05:01:44 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: prevents multiple jumps to happen with LockOn (#8460)

Browse Source
This commit is contained in:
Joffrey JAFFEUX 2019-12-04 16:45:23 +01:00 committed by GitHub
parent 46d8fd3831
commit c5140ef3fb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
app/assets/javascripts/discourse/lib/lock-on.js.es6
View File

@ -51,23 +51,25 @@ export default class LockOn {
lock() {
const startedAt = new Date().getTime();
let previousTop = this.elementTop();
previousTop && $(window).scrollTop(previousTop);
const interval = setInterval(() => {
if (!previousTop) {
previousTop = this.elementTop();
previousTop && $(window).scrollTop(previousTop);
} else {
const top = Math.max(0, this.elementTop());
const scrollTop = $(window).scrollTop();
const elementTop = this.elementTop();
if (!previousTop && !elementTop) {
// we can't find the element yet, wait a little bit more
return;
}
if (typeof top === "undefined" || isNaN(top)) {
return this.clearLock(interval);
}
const top = Math.max(0, elementTop);
const scrollTop = $(window).scrollTop();
if (!within(4, top, previousTop) || !within(4, scrollTop, top)) {
$(window).scrollTop(top);
previousTop = top;
}
if (typeof top === "undefined" || isNaN(top)) {
return this.clearLock(interval);
}
if (!within(4, top, previousTop) || !within(4, scrollTop, top)) {
$(window).scrollTop(top);
previousTop = top;
}
// Commit suicide after a little while