github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-03-24 09:55:33 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Fix invalid test in 5dba5c4208ee8560090c815729b3053b9fd82585 (#25810)

Browse Source 
Why this change?

The previous test setup did not actually act as a regression test
because the test will still pass even when the fix is removed. This
commit uses a rendering test instead to ensure that Ember is tracking
the property change.
This commit is contained in:
Alan Guo Xiang Tan 2024-02-22 19:10:23 +08:00 committed by GitHub
parent 3b87a174e7
commit c56c3adfde
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 24 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
app/assets/javascripts/discourse/tests/unit/models/extra-nav-item-test.gjs Normal file
View File

@ -0,0 +1,24 @@
import { render, settled } from "@ember/test-helpers";
import { setupRenderingTest } from "ember-qunit";
import { module, test } from "qunit";
import { ExtraNavItem } from "discourse/models/nav-item";
module("Unit | Model | extra-nav-item", function (hooks) {
setupRenderingTest(hooks);
test("displayName updates when count property changes", async function (assert) {
const extraNavItem = ExtraNavItem.create({
name: "something",
});
await render(<template><p>{{extraNavItem.displayName}}</p></template>);
assert.dom("p").hasText("[en.filters.something.title count=0]");
extraNavItem.count = 2;
await settled();
assert.dom("p").hasText("[en.filters.something.title_with_count count=2]");
});
});

25
app/assets/javascripts/discourse/tests/unit/models/extra-nav-item-test.js
View File

@ -1,25 +0,0 @@
import { setupTest } from "ember-qunit";
import { module, test } from "qunit";
import { ExtraNavItem } from "discourse/models/nav-item";
module("Unit | Model | extra-nav-item", function (hooks) {
setupTest(hooks);
test("displayName updates when count property changes", function (assert) {
const extraNavItem = ExtraNavItem.create({
name: "something",
});
assert.strictEqual(
extraNavItem.displayName,
"[en.filters.something.title count=0]"
);
extraNavItem.count = 2;
assert.strictEqual(
extraNavItem.displayName,
"[en.filters.something.title_with_count count=2]"
);
});
});