From c6bde9f239f4cddd83e850668d5e51af475e829c Mon Sep 17 00:00:00 2001 From: Gerhard Schlager Date: Wed, 20 Jan 2021 23:46:25 +0100 Subject: [PATCH] DEV: Remove Dangerfile We aren't using it anymore --- Dangerfile | 73 ------------------------------------------------------ 1 file changed, 73 deletions(-) delete mode 100644 Dangerfile diff --git a/Dangerfile b/Dangerfile deleted file mode 100644 index 33cf8fc5657..00000000000 --- a/Dangerfile +++ /dev/null @@ -1,73 +0,0 @@ -# frozen_string_literal: true - -if github.pr_json && (github.pr_json["additions"] || 0) > 250 || (github.pr_json["deletions"] || 0) > 250 - warn("This pull request is big! We prefer smaller PRs whenever possible, as they are easier to review. Can this be split into a few smaller PRs?") -end - -prettier_offenses = `yarn --silent prettier --list-different "app/assets/stylesheets/**/*.scss" "app/assets/javascripts/**/*.js" "app/assets/javascripts/**/*.es6" "test/javascripts/**/*.es6"`.split("\n") - -unless prettier_offenses.empty? - fail(%{ -This PR doesn't match our required code formatting standards, as enforced by prettier.io. Here's how to set up prettier in your code editor.\n -#{prettier_offenses.map { |o| github.html_link(o) }.join("\n")} - }) -end - -locales_changes = git.modified_files.grep(%r{config/locales}) -has_non_en_locales_changes = locales_changes.grep_v(%r{config/locales/(?:client|server)\.(?:en|en_US)\.yml}).any? - -if locales_changes.any? && has_non_en_locales_changes - fail("Please submit your non-English translation updates via [Crowdin](https://translate.discourse.org/). You can read more on how to contribute translations [here](https://meta.discourse.org/t/contribute-a-translation-to-discourse/14882).") -end - -files = (git.added_files + git.modified_files) - .select { |path| !path.start_with?("plugins/") } - .select { |path| path.end_with?("es6") || path.end_with?("js") || path.end_with?("rb") } - -js_files = files.select { |path| path.end_with?(".js.es6") || path.end_with?(".js") } -js_test_files = js_files.select { |path| path.end_with?("-test.js.es6") } - -super_offenses = [] -self_offenses = [] -js_files.each do |path| - diff = git.diff_for_file(path) - - next if !diff - - diff.patch.lines.grep(/^\+\s\s/).each do |added_line| - super_offenses << path if added_line['this._super()'] - self_offenses << path if added_line[/(?:(^|\W)self\.?)/] - end -end - -jquery_find_offenses = [] -js_test_files.each do |path| - diff = git.diff_for_file(path) - - next if !diff - - diff.patch.lines.grep(/^\+\s\s/).each do |added_line| - jquery_find_offenses << path if added_line['this.$('] - end -end - -if !self_offenses.empty? - warn(%{ -Use fat arrow instead of self pattern.\n -#{self_offenses.uniq.map { |o| github.html_link(o) }.join("\n")} - }) -end - -if !super_offenses.empty? - warn(%{ -When possible use `this._super(...arguments)` instead of `this._super()`\n -#{super_offenses.uniq.map { |o| github.html_link(o) }.join("\n")} - }) -end - -if !jquery_find_offenses.empty? - warn(%{ -Use `find()` instead of `this.$` in js tests`\n -#{jquery_find_offenses.uniq.map { |o| github.html_link(o) }.join("\n")} - }) -end