From d28808e866799814849dd089ed22fda12ca3172d Mon Sep 17 00:00:00 2001 From: Robin Ward Date: Thu, 20 Jan 2022 16:33:01 -0500 Subject: [PATCH] FIX: The service observer was using `this` incorrectly It was pointing at nothing due to context. --- .../javascripts/discourse/app/components/global-notice.js | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/app/assets/javascripts/discourse/app/components/global-notice.js b/app/assets/javascripts/discourse/app/components/global-notice.js index d37c3c0b825..01c3d59295a 100644 --- a/app/assets/javascripts/discourse/app/components/global-notice.js +++ b/app/assets/javascripts/discourse/app/components/global-notice.js @@ -220,6 +220,7 @@ export default Component.extend({ @bind _handleLogsNoticeUpdate() { + const { logsNoticeService } = this; const logNotice = Notice.create({ text: htmlSafe(this.logsNoticeService.message), id: "alert-logs-notice", @@ -227,13 +228,10 @@ export default Component.extend({ dismissable: true, persistentDismiss: false, visibility() { - return !this.logsNoticeService.hidden; + return !logsNoticeService.hidden; }, onDismiss() { - this.logsNoticeService.setProperties({ - hidden: true, - text: "", - }); + logsNoticeService.set("text", ""); }, }, });