From da43b60510fd6f791de065659e762c656037c5ac Mon Sep 17 00:00:00 2001 From: carsick Date: Wed, 22 Feb 2023 23:00:41 -0800 Subject: [PATCH] Update period-title.js (#20422) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit (A petty but important typography fix) Use en dash (–) instead of hyphen (-) for ranges (including dates) For example — 1–2, May–June, 1:00pm–2:00pm A space in before and after the dash is usually not present in writing but for user interfaces can be stylistic choice. (The space is left unchanged here.) References - https://learn.microsoft.com/en-us/style-guide/punctuation/dashes-hyphens/enes - https://www.thepunctuationguide.com/en-dash.html --- .../javascripts/discourse/app/helpers/period-title.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/assets/javascripts/discourse/app/helpers/period-title.js b/app/assets/javascripts/discourse/app/helpers/period-title.js index 090f7cacd3e..c84f3ef8668 100644 --- a/app/assets/javascripts/discourse/app/helpers/period-title.js +++ b/app/assets/javascripts/discourse/app/helpers/period-title.js @@ -28,7 +28,7 @@ export default htmlHelper((period, options) => { .clone() .subtract(1, "year") .format(I18n.t("dates.long_with_year_no_time")) + - " - " + + " – " + finish.format(I18n.t("dates.long_with_year_no_time")); break; case "quarterly": @@ -37,7 +37,7 @@ export default htmlHelper((period, options) => { .clone() .subtract(3, "month") .format(I18n.t("dates.long_no_year_no_time")) + - " - " + + " – " + finish.format(I18n.t("dates.long_no_year_no_time")); break; case "weekly": @@ -50,7 +50,7 @@ export default htmlHelper((period, options) => { dateString = start.format(I18n.t("dates.long_no_year_no_time")) + - " - " + + " – " + finish.format(I18n.t("dates.long_no_year_no_time")); break; case "monthly": @@ -59,7 +59,7 @@ export default htmlHelper((period, options) => { .clone() .subtract(1, "month") .format(I18n.t("dates.long_no_year_no_time")) + - " - " + + " – " + finish.format(I18n.t("dates.long_no_year_no_time")); break; case "daily":