github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-03-23 04:15:41 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

UX: Make PresenceChannel changes more responsive (#14733)

Browse Source 
For very fast-paced things (e.g. replying... indicators), 5s resolution is not great. This commit improves the resolution to 1 update per second.
This commit is contained in:
David Taylor 2021-10-26 21:15:20 +01:00 committed by GitHub
parent d067ee1c5a
commit e073451eae
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/discourse/app/services/presence.js
View File

@ -18,7 +18,7 @@ import User from "discourse/models/user";
const PRESENCE_INTERVAL_S = 30; const PRESENCE_INTERVAL_S = 30;
const PRESENCE_DEBOUNCE_MS = isTesting() ? 0 : 500; const PRESENCE_DEBOUNCE_MS = isTesting() ? 0 : 500;
const PRESENCE_THROTTLE_MS = isTesting() ? 0 : 5000; const PRESENCE_THROTTLE_MS = isTesting() ? 0 : 1000;
const PRESENCE_GET_RETRY_MS = 5000; const PRESENCE_GET_RETRY_MS = 5000;

5
app/controllers/presence_controller.rb
View File

@ -39,8 +39,9 @@ class PresenceController < ApplicationController
client_id = params[:client_id] client_id = params[:client_id]
raise Discourse::InvalidParameters.new(:client_id) if !client_id.is_a?(String) || client_id.blank? raise Discourse::InvalidParameters.new(:client_id) if !client_id.is_a?(String) || client_id.blank?
# JS client is designed to throttle to one request every 5 seconds # JS client is designed to throttle to one request per second
RateLimiter.new(nil, "update-presence-#{current_user.id}-#{client_id}}", 3, 10.seconds).performed! # When no changes are being made, it makes one request every 30 seconds
RateLimiter.new(nil, "update-presence-#{current_user.id}", 20, 10.seconds).performed!
present_channels = params[:present_channels] present_channels = params[:present_channels]
if present_channels && !(present_channels.is_a?(Array) && present_channels.all? { |c| c.is_a? String }) if present_channels && !(present_channels.is_a?(Array) && present_channels.all? { |c| c.is_a? String })