From e5ce2d97f6e8514a19438b2832867c217479f46a Mon Sep 17 00:00:00 2001
From: David Taylor <david@taylorhq.com>
Date: Wed, 11 Dec 2019 11:49:27 +0000
Subject: [PATCH] DEV: Simplify Rubocop runner for GitHub actions

Once we are happy with basic behavior, we can try adding annotations again
---
 .github/workflows/ci.yml        |   5 +-
 script/rubocop_github_action.rb | 142 --------------------------------
 2 files changed, 1 insertion(+), 146 deletions(-)
 delete mode 100644 script/rubocop_github_action.rb

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index c699fc93235..16b47f6095f 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -122,10 +122,7 @@ jobs:
 
       - name: Rubocop
         if: env.BUILD_TYPE == 'LINT'
-        run: ruby script/rubocop_github_action.rb
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          JOB_NAME: ${{ matrix.target }}-${{ matrix.build_types }} / Rubocop
+        run: bundle exec rubocop .
       
       - name: ESLint
         if: env.BUILD_TYPE == 'LINT'
diff --git a/script/rubocop_github_action.rb b/script/rubocop_github_action.rb
deleted file mode 100644
index 2e84c651f2e..00000000000
--- a/script/rubocop_github_action.rb
+++ /dev/null
@@ -1,142 +0,0 @@
-# frozen_string_literal: true
-
-# Adapted from https://github.com/gimenete/rubocop-action/blob/master/lib/index.rb
-
-require 'net/http'
-require 'json'
-require 'time'
-
-@GITHUB_SHA = ENV["GITHUB_SHA"]
-@GITHUB_EVENT_PATH = ENV["GITHUB_EVENT_PATH"]
-@GITHUB_TOKEN = ENV["GITHUB_TOKEN"]
-@GITHUB_WORKSPACE = ENV["GITHUB_WORKSPACE"]
-
-@event = JSON.parse(File.read(ENV["GITHUB_EVENT_PATH"]))
-@repository = @event["repository"]
-@owner = @repository["owner"]["login"]
-@repo = @repository["name"]
-
-@check_name = ENV["JOB_NAME"]
-
-@headers = {
-  "Content-Type": 'application/json',
-  "Accept": 'application/vnd.github.antiope-preview+json',
-  "Authorization": "Bearer #{@GITHUB_TOKEN}",
-  "User-Agent": 'rubocop-action'
-}
-
-def create_check
-  body = {
-    "name" => @check_name,
-    "head_sha" => @GITHUB_SHA,
-    "status" => "in_progress",
-    "started_at" => Time.now.iso8601
-  }
-
-  http = Net::HTTP.new('api.github.com', 443)
-  http.use_ssl = true
-  path = "/repos/#{@owner}/#{@repo}/check-runs"
-
-  resp = http.post(path, body.to_json, @headers)
-
-  if resp.code.to_i >= 300
-    raise resp.message
-  end
-
-  data = JSON.parse(resp.body)
-  data["id"]
-end
-
-def update_check(id, conclusion, output)
-  body = {
-    "name" => @check_name,
-    "head_sha" => @GITHUB_SHA,
-    "status" => 'completed',
-    "completed_at" => Time.now.iso8601,
-    "conclusion" => conclusion,
-    "output" => output
-  }
-
-  http = Net::HTTP.new('api.github.com', 443)
-  http.use_ssl = true
-  path = "/repos/#{@owner}/#{@repo}/check-runs/#{id}"
-
-  resp = http.patch(path, body.to_json, @headers)
-
-  if resp.code.to_i >= 300
-    raise resp.message
-  end
-end
-
-@annotation_levels = {
-  "refactor" => 'failure',
-  "convention" => 'failure',
-  "warning" => 'warning',
-  "error" => 'failure',
-  "fatal" => 'failure'
-}
-
-def run_rubocop
-  annotations = []
-  errors = nil
-  Dir.chdir(@GITHUB_WORKSPACE) { # rubocop:disable DiscourseCops/NoChdir because this is not part of the app
-    errors = JSON.parse(`bundle exec rubocop --parallel  --format json .`)
-  }
-  conclusion = "success"
-  count = 0
-
-  errors["files"].each do |file|
-    path = file["path"]
-    offenses = file["offenses"]
-
-    offenses.each do |offense|
-      severity = offense["severity"]
-      message = offense["message"]
-      location = offense["location"]
-      annotation_level = @annotation_levels[severity]
-      count = count + 1
-
-      if annotation_level == "failure"
-        conclusion = "failure"
-      end
-
-      annotations.push(
-                         "path" => path,
-                         "start_line" => location["start_line"],
-                         "end_line" => location["start_line"],
-                         "annotation_level": annotation_level,
-                         "message" => message
-                       )
-    end
-  end
-
-  output = {
-    "title": @check_name,
-    "summary": "#{count} offense(s) found",
-    "annotations" => annotations
-  }
-
-  { "output" => output, "conclusion" => conclusion }
-end
-
-def run
-  id = create_check()
-  begin
-    results = run_rubocop()
-    conclusion = results["conclusion"]
-    output = results["output"]
-
-    update_check(id, conclusion, output)
-
-    if conclusion == "failure"
-      puts "Rubocop Failed: #{output["summary"]}"
-      exit 1
-    end
-  rescue
-    update_check(id, "failure", nil)
-    puts "Rubocop Errored"
-    exit 1
-  end
-end
-
-run()