diff --git a/lib/site_setting_extension.rb b/lib/site_setting_extension.rb index 44f35a1220c..99ab174d22d 100644 --- a/lib/site_setting_extension.rb +++ b/lib/site_setting_extension.rb @@ -284,6 +284,8 @@ module SiteSettingExtension def add_override!(name, val) type = get_data_type(name, defaults[name.to_sym]) + val = val.to_s if type == types[:string] + if type == types[:bool] && val != true && val != false val = (val == "t" || val == "true") ? 't' : 'f' end diff --git a/spec/components/site_setting_extension_spec.rb b/spec/components/site_setting_extension_spec.rb index 353c04bd4cd..ce3d5584509 100644 --- a/spec/components/site_setting_extension_spec.rb +++ b/spec/components/site_setting_extension_spec.rb @@ -179,7 +179,6 @@ describe SiteSettingExtension do end it "should coerce int to string" do - skip "This test is not working on Rspec 2 even" settings.test_str = 100 expect(settings.test_str).to eq("100") end