From e8aa2b8d9a2765ea30521fa5e8a71481689f7480 Mon Sep 17 00:00:00 2001
From: Natalie Tay <natalie.tay@discourse.org>
Date: Mon, 13 Jan 2025 13:50:00 +0800
Subject: [PATCH] DEV: Add a nofollow to /u so user profiles don't get added as
 a target for crawling (#30693)

In some sites, we are noticing that /u routes are getting indexed.

This commit adds a
["nofollow"](https://developers.google.com/search/docs/crawling-indexing/qualify-outbound-links)
on user profiles so that Google will not index these user profile URLs.
---
 app/views/about/index.html.erb    | 4 ++--
 app/views/email/_post.html.erb    | 4 ++--
 app/views/embed/comments.html.erb | 4 ++--
 app/views/list/list.erb           | 2 +-
 app/views/topics/show.html.erb    | 4 ++--
 5 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/app/views/about/index.html.erb b/app/views/about/index.html.erb
index 98bfc49f279..e529aa5740a 100644
--- a/app/views/about/index.html.erb
+++ b/app/views/about/index.html.erb
@@ -15,7 +15,7 @@
     <% @about.admins.each do |user| %>
       <div itemprop='itemListElement' itemscope itemtype='http://schema.org/ListItem'>
         <meta itemprop='url' content='<%= user_path(user.encoded_username(lower: true)) %>'>
-        <a href='<%= user_path(user.encoded_username(lower: true)) %>' itemprop='item'>
+        <a rel='nofollow' href='<%= user_path(user.encoded_username(lower: true)) %>' itemprop='item'>
           <span itemprop='image'>
             <img width="45" height="45" class="avatar" src="<%= user.small_avatar_url %>">
           </span>
@@ -36,7 +36,7 @@
       <% @about.moderators.each do |user| %>
         <div itemprop='itemListElement' itemscope itemtype='http://schema.org/ListItem'>
           <meta itemprop='url' content='<%= user_path(user.encoded_username(lower: true)) %>'>
-          <a href='<%= user_path(user.encoded_username(lower: true)) %>' itemprop='item'>
+          <a rel='nofollow' href='<%= user_path(user.encoded_username(lower: true)) %>' itemprop='item'>
             <span itemprop='image'>
               <img width="45" height="45" class="avatar" src="<%= user.small_avatar_url %>">
             </span>
diff --git a/app/views/email/_post.html.erb b/app/views/email/_post.html.erb
index 57507530d6c..6567549bb6c 100644
--- a/app/views/email/_post.html.erb
+++ b/app/views/email/_post.html.erb
@@ -6,12 +6,12 @@
       </td>
       <td>
         <%- if SiteSetting.prioritize_username_in_ux %>
-          <a class="username username-link" href="<%=Discourse.base_url%>/u/<%= post.user.username_lower%>" target="_blank"><%= post.user.username %></a>
+          <a rel='nofollow' class="username username-link" href="<%=Discourse.base_url%>/u/<%= post.user.username_lower%>" target="_blank"><%= post.user.username %></a>
           <%- if show_name_on_post(post) %>
             <span class='user-name username-title'><%= post.user.name %></span>
           <% end %>
         <%- else %>
-          <a class="username username-link" href="<%=Discourse.base_url%>/u/<%= post.user.username_lower%>" target="_blank"><%= post.user.name %></a>
+          <a rel='nofollow' class="username username-link" href="<%=Discourse.base_url%>/u/<%= post.user.username_lower%>" target="_blank"><%= post.user.name %></a>
           <%- if show_username_on_post(post) %>
             <span class='username username-title'><%= post.user.username %></span>
           <% end %>
diff --git a/app/views/embed/comments.html.erb b/app/views/embed/comments.html.erb
index 66394aed573..ffe98eb97a3 100644
--- a/app/views/embed/comments.html.erb
+++ b/app/views/embed/comments.html.erb
@@ -16,11 +16,11 @@
       <%- end %>
 
       <div class='author'>
-        <a href='<%= Discourse.base_url %>/u/<%= post.username %>' target="_blank"><img src='<%= post.user.small_avatar_url %>' alt=''></a>
+        <a rel='nofollow' href='<%= Discourse.base_url %>/u/<%= post.username %>' target="_blank"><img src='<%= post.user.small_avatar_url %>' alt=''></a>
       </div>
       <div class='cooked'>
         <h3 class='username'>
-          <a href='<%= Discourse.base_url %>/u/<%= post.username %>' target="_blank" class='<% if post.user.staff? %>staff<% end %><% if post.user.new_user? %>new-user<% end %>'><%= post.user.username %></a>
+          <a rel='nofollow' href='<%= Discourse.base_url %>/u/<%= post.username %>' target="_blank" class='<% if post.user.staff? %>staff<% end %><% if post.user.new_user? %>new-user<% end %>'><%= post.user.username %></a>
           <%- if post.user.title.present? %>
             <span class='title'><%= post.user.title %></span>
           <%- end %>
diff --git a/app/views/list/list.erb b/app/views/list/list.erb
index 21697dd1e65..bea29d36858 100644
--- a/app/views/list/list.erb
+++ b/app/views/list/list.erb
@@ -87,7 +87,7 @@
           </td>
           <td class='posters'>
             <% t.posters.each do |poster| %>
-              <a href="<%= Discourse.base_url %>/u/<%= poster.user.username %>" class="<%= poster.extras %>">
+              <a rel='nofollow' href="<%= Discourse.base_url %>/u/<%= poster.user.username %>" class="<%= poster.extras %>">
                 <%- poster_name_and_description = h(poster.name_and_description) %>
                 <img width="25" height="25" src="<%= poster.user.avatar_template.gsub('{size}', '25') %>" class="avatar" title='<%= poster_name_and_description %>' aria-label='<%= poster_name_and_description %>'>
               </a>
diff --git a/app/views/topics/show.html.erb b/app/views/topics/show.html.erb
index ff894eefc9c..dd260e70057 100644
--- a/app/views/topics/show.html.erb
+++ b/app/views/topics/show.html.erb
@@ -55,7 +55,7 @@
         <% if @topic_view.topic.user.present? %>
           <span itemprop='author' itemscope itemtype="http://schema.org/Person">
             <meta itemprop='name' content='<%= @topic_view.topic.user.username %>'>
-            <link itemprop='url' href='<%= Discourse.base_url %>/u/<%= @topic_view.topic.user.username %>'>
+            <link itemprop='url' rel='nofollow' href='<%= Discourse.base_url %>/u/<%= @topic_view.topic.user.username %>'>
           </span>
         <% end %>
         <meta itemprop='text' content='<%= @topic_view.topic.excerpt %>'>
@@ -66,7 +66,7 @@
           <div id='post_<%= post.post_number %>' <%= post.is_first_post? ? "" : "itemprop='comment' itemscope itemtype='http://schema.org/Comment'".html_safe %> class='topic-body crawler-post'>
             <div class='crawler-post-meta'>
               <span class="creator" itemprop="author" itemscope itemtype="http://schema.org/Person">
-                <a itemprop="url" href='<%= Discourse.base_url %>/u/<%= u.username %>'><span itemprop='name'><%= u.username %></span></a>
+                <a itemprop="url" rel='nofollow' href='<%= Discourse.base_url %>/u/<%= u.username %>'><span itemprop='name'><%= u.username %></span></a>
                 <%= "(#{u.name})" if (SiteSetting.display_name_on_posts && SiteSetting.enable_names? && !u.name.blank?) %>
                 <%
                   post_custom_fields = @topic_view.post_custom_fields[post.id] || {}