github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-03-21 13:37:26 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: update id types in API docs to integers (#27412)

Browse Source
This commit is contained in:
Dylan Yang 2024-06-26 19:44:39 -07:00 committed by GitHub
parent cada172981
commit e92a82aa1d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
13 changed files with 61 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
spec/requests/api/posts_spec.rb
View File

@ -117,7 +117,7 @@ RSpec.describe "posts" do
type: %i[string null], type: %i[string null],
}, },
flair_group_id: { flair_group_id: {
type: %i[string null], type: %i[integer null],
}, },
version: { version: {
type: :integer, type: :integer,
@ -191,7 +191,7 @@ RSpec.describe "posts" do
type: :boolean, type: :boolean,
}, },
reviewable_id: { reviewable_id: {
type: %i[string null], type: %i[integer null],
}, },
reviewable_score_count: { reviewable_score_count: {
type: :integer, type: :integer,
@ -261,6 +261,29 @@ RSpec.describe "posts" do
let(:expected_request_schema) { expected_request_schema } let(:expected_request_schema) { expected_request_schema }
end end
end end
response "200", "single reviewable post" do
expected_response_schema = load_spec_schema("post_show_response")
schema expected_response_schema
let(:id) do
topic = Fabricate(:topic)
post = Fabricate(:post, topic: topic)
Fabricate(:reviewable_flagged_post, topic: topic, target: post)
post.id
end
let(:moderator) { Fabricate(:moderator) }
before { sign_in(moderator) }
run_test!
it_behaves_like "a JSON endpoint", 200 do
let(:expected_response_schema) { expected_response_schema }
let(:expected_request_schema) { expected_request_schema }
end
end
end end
put "Update a single post" do put "Update a single post" do
@ -570,7 +593,7 @@ RSpec.describe "posts" do
type: :object, type: :object,
}, },
reviewable_id: { reviewable_id: {
type: %i[string null], type: %i[integer null],
}, },
reviewable_score_count: { reviewable_score_count: {
type: :integer, type: :integer,

6
spec/requests/api/private_messages_spec.rb
View File

@ -178,7 +178,7 @@ RSpec.describe "private messages" do
type: :integer, type: :integer,
}, },
primary_group_id: { primary_group_id: {
type: %i[string null], type: %i[integer null],
}, },
}, },
}, },
@ -198,7 +198,7 @@ RSpec.describe "private messages" do
type: :integer, type: :integer,
}, },
primary_group_id: { primary_group_id: {
type: %i[string null], type: %i[integer null],
}, },
}, },
}, },
@ -385,7 +385,7 @@ RSpec.describe "private messages" do
type: :integer, type: :integer,
}, },
primary_group_id: { primary_group_id: {
type: %i[string null], type: %i[integer null],
}, },
}, },
}, },

4
spec/requests/api/schemas/json/admin_user_response.json
View File

@ -144,7 +144,7 @@
] ]
}, },
"primary_group_id": { "primary_group_id": {
"type": ["string", "null"] "type": ["integer", "null"]
}, },
"badge_count": { "badge_count": {
"type": "integer" "type": "integer"
@ -411,7 +411,7 @@
"type": ["string", "null"] "type": ["string", "null"]
}, },
"flair_group_id": { "flair_group_id": {
"type": ["string", "null"] "type": ["integer", "null"]
}, },
"bio_raw": { "bio_raw": {
"type": ["string", "null"] "type": ["string", "null"]

2
spec/requests/api/schemas/json/category_topics_response.json
View File

@ -176,7 +176,7 @@
}, },
"primary_group_id": { "primary_group_id": {
"type": [ "type": [
"string", "integer",
"null" "null"
] ]
} }

4
spec/requests/api/schemas/json/post_replies_response.json
View File

@ -103,7 +103,7 @@
}, },
"flair_group_id": { "flair_group_id": {
"type": [ "type": [
"string", "integer",
"null" "null"
] ]
}, },
@ -214,7 +214,7 @@
}, },
"reviewable_id": { "reviewable_id": {
"type": [ "type": [
"string", "integer",
"null" "null"
] ]
}, },

4
spec/requests/api/schemas/json/post_show_response.json
View File

@ -90,7 +90,7 @@
}, },
"flair_group_id": { "flair_group_id": {
"type": [ "type": [
"string", "integer",
"null" "null"
] ]
}, },
@ -193,7 +193,7 @@
}, },
"reviewable_id": { "reviewable_id": {
"type": [ "type": [
"string", "integer",
"null" "null"
] ]
}, },

4
spec/requests/api/schemas/json/post_update_response.json
View File

@ -94,7 +94,7 @@
}, },
"flair_group_id": { "flair_group_id": {
"type": [ "type": [
"string", "integer",
"null" "null"
] ]
}, },
@ -191,7 +191,7 @@
}, },
"reviewable_id": { "reviewable_id": {
"type": [ "type": [
"string", "integer",
"null" "null"
] ]
}, },

4
spec/requests/api/schemas/json/topic_create_response.json
View File

@ -105,7 +105,7 @@
}, },
"flair_group_id": { "flair_group_id": {
"type": [ "type": [
"string", "integer",
"null" "null"
] ]
}, },
@ -200,7 +200,7 @@
}, },
"reviewable_id": { "reviewable_id": {
"type": [ "type": [
"string", "integer",
"null" "null"
] ]
}, },

2
spec/requests/api/schemas/json/topic_show_response.json
View File

@ -836,7 +836,7 @@
}, },
"flair_group_id": { "flair_group_id": {
"type": [ "type": [
"string", "integer",
"null" "null"
] ]
}, },

6
spec/requests/api/schemas/json/user_get_response.json
View File

@ -119,7 +119,7 @@
}, },
"primary_group_id": { "primary_group_id": {
"type": [ "type": [
"string", "integer",
"null" "null"
] ]
}, },
@ -131,7 +131,7 @@
}, },
"flair_group_id": { "flair_group_id": {
"type": [ "type": [
"string", "integer",
"null" "null"
] ]
}, },
@ -182,7 +182,7 @@
}, },
"uploaded_avatar_id": { "uploaded_avatar_id": {
"type": [ "type": [
"string", "integer",
"null" "null"
] ]
}, },

2
spec/requests/api/tags_spec.rb
View File

@ -444,7 +444,7 @@ RSpec.describe "tags" do
type: :integer, type: :integer,
}, },
primary_group_id: { primary_group_id: {
type: %i[string null], type: %i[integer null],
}, },
}, },
}, },

6
spec/requests/api/topics_spec.rb
View File

@ -627,7 +627,7 @@ RSpec.describe "topics" do
type: :integer, type: :integer,
}, },
primary_group_id: { primary_group_id: {
type: %i[string null], type: %i[integer null],
}, },
}, },
}, },
@ -827,7 +827,7 @@ RSpec.describe "topics" do
type: :integer, type: :integer,
}, },
primary_group_id: { primary_group_id: {
type: %i[string null], type: %i[integer null],
}, },
}, },
}, },
@ -966,7 +966,7 @@ RSpec.describe "topics" do
type: :boolean, type: :boolean,
}, },
category_id: { category_id: {
type: %i[string null], type: %i[integer null],
}, },
} }

12
spec/requests/api/users_spec.rb
View File

@ -68,6 +68,18 @@ RSpec.describe "users" do
let(:expected_request_schema) { expected_request_schema } let(:expected_request_schema) { expected_request_schema }
end end
end end
response "200", "user with primary group response" do
expected_response_schema = load_spec_schema("user_get_response")
schema expected_response_schema
let(:username) { Fabricate(:user, primary_group_id: Fabricate(:group).id).username }
it_behaves_like "a JSON endpoint", 200 do
let(:expected_response_schema) { expected_response_schema }
let(:expected_request_schema) { expected_request_schema }
end
end
end end
put "Update a user" do put "Update a user" do