github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-04-02 02:18:17 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Revert "FIX: fixnum type site setting can't be more than 20000"

Browse Source 
This reverts commit 636cc66e1f8d7ff1e81641eb8f92fdb010eeb122.
This commit is contained in:
Arpit Jalan 2015-07-13 22:53:44 +05:30
parent fcdb7f36b7
commit e9a81064e7
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/site_setting_extension.rb
View File

@ -310,8 +310,8 @@ module SiteSettingExtension
type = get_data_type(name, defaults[name.to_sym]) type = get_data_type(name, defaults[name.to_sym])
if type == types[:fixnum] if type == types[:fixnum]
# value should be less than 20000 # validate fixnum
valid = false if value.to_i > 20000 valid = false unless value.to_i.is_a?(Fixnum)
end end
return valid return valid

4
spec/components/site_setting_extension_spec.rb
View File

@ -340,12 +340,12 @@ describe SiteSettingExtension do
end end
end end
describe "set for an invalid fixnum value (greater than 20000)" do describe "set for an invalid fixnum value" do
it "raises an error" do it "raises an error" do
settings.setting(:test_setting, 80) settings.setting(:test_setting, 80)
settings.refresh! settings.refresh!
expect { expect {
settings.set("test_setting", 20001) settings.set("test_setting", 9999999999999999999)
}.to raise_error(ArgumentError) }.to raise_error(ArgumentError)
end end
end end