From f4b417462bbfcd9298981a5aed2cff116612a3b6 Mon Sep 17 00:00:00 2001 From: Martin Brennan Date: Fri, 10 Jan 2025 11:03:07 +1000 Subject: [PATCH] UX: Final pass of admin setting pages (#30682) This commit finalises the admin setting page consistency efforts by: * Converting all route templates into .gjs * Adding `@hideTabs={{true}}` for all the page headers so we don't show a border line when it's not needed * Introduce `@showBreadcrumb` and default to true for AdminAreaSettings, for all these pages the Settings part of the breadcrumb is redundant --- .../addon/components/admin-area-settings.gjs | 5 ++- .../templates/config-developer-settings.gjs | 2 ++ .../config-experimental-settings.gjs | 2 ++ .../addon/templates/config-files-settings.gjs | 2 ++ .../addon/templates/config-fonts-settings.gjs | 31 +++++++++++++++++ .../addon/templates/config-fonts-settings.hbs | 21 ------------ .../config-group-permissions-settings.gjs | 2 ++ .../addon/templates/config-legal-settings.gjs | 31 +++++++++++++++++ .../addon/templates/config-legal-settings.hbs | 21 ------------ ...nfig-login-and-authentication-settings.gjs | 33 +++++++++++++++++++ ...nfig-login-and-authentication-settings.hbs | 23 ------------- .../addon/templates/config-logo-settings.gjs | 31 +++++++++++++++++ .../addon/templates/config-logo-settings.hbs | 21 ------------ .../templates/config-navigation-settings.gjs | 31 +++++++++++++++++ .../templates/config-navigation-settings.hbs | 21 ------------ .../config-notifications-settings.gjs | 31 +++++++++++++++++ .../config-notifications-settings.hbs | 21 ------------ .../templates/config-onebox-settings.gjs | 2 ++ .../addon/templates/config-other-settings.gjs | 2 ++ .../templates/config-rate-limits-settings.gjs | 2 ++ .../templates/config-search-settings.gjs | 31 +++++++++++++++++ .../templates/config-search-settings.hbs | 21 ------------ .../templates/config-security-settings.gjs | 2 ++ .../addon/templates/config-spam-settings.gjs | 2 ++ .../config-trust-levels-settings.gjs | 32 ++++++++++++++++++ .../config-trust-levels-settings.hbs | 22 ------------- .../templates/config-user-api-settings.gjs | 2 ++ config/locales/client.en.yml | 2 +- 28 files changed, 276 insertions(+), 173 deletions(-) create mode 100644 app/assets/javascripts/admin/addon/templates/config-fonts-settings.gjs delete mode 100644 app/assets/javascripts/admin/addon/templates/config-fonts-settings.hbs create mode 100644 app/assets/javascripts/admin/addon/templates/config-legal-settings.gjs delete mode 100644 app/assets/javascripts/admin/addon/templates/config-legal-settings.hbs create mode 100644 app/assets/javascripts/admin/addon/templates/config-login-and-authentication-settings.gjs delete mode 100644 app/assets/javascripts/admin/addon/templates/config-login-and-authentication-settings.hbs create mode 100644 app/assets/javascripts/admin/addon/templates/config-logo-settings.gjs delete mode 100644 app/assets/javascripts/admin/addon/templates/config-logo-settings.hbs create mode 100644 app/assets/javascripts/admin/addon/templates/config-navigation-settings.gjs delete mode 100644 app/assets/javascripts/admin/addon/templates/config-navigation-settings.hbs create mode 100644 app/assets/javascripts/admin/addon/templates/config-notifications-settings.gjs delete mode 100644 app/assets/javascripts/admin/addon/templates/config-notifications-settings.hbs create mode 100644 app/assets/javascripts/admin/addon/templates/config-search-settings.gjs delete mode 100644 app/assets/javascripts/admin/addon/templates/config-search-settings.hbs create mode 100644 app/assets/javascripts/admin/addon/templates/config-trust-levels-settings.gjs delete mode 100644 app/assets/javascripts/admin/addon/templates/config-trust-levels-settings.hbs diff --git a/app/assets/javascripts/admin/addon/components/admin-area-settings.gjs b/app/assets/javascripts/admin/addon/components/admin-area-settings.gjs index 65cd42794bc..b3f5fc08844 100644 --- a/app/assets/javascripts/admin/addon/components/admin-area-settings.gjs +++ b/app/assets/javascripts/admin/addon/components/admin-area-settings.gjs @@ -17,6 +17,7 @@ export default class AdminAreaSettings extends Component { @tracked settings = []; @tracked filter = ""; @tracked loading = false; + @tracked showBreadcrumb = this.args.showBreadcrumb ?? true; constructor() { super(...arguments); @@ -62,7 +63,9 @@ export default class AdminAreaSettings extends Component { }