Sam
49f0cc16ba
PERF: optimise serialization for topic tracking state ( #20860 )
...
This corrects two issues:
1. We were double serializing topic tracking state (as_json calls were not cached)
2. We were inefficiently serializing items by instantiating extra objects
2023-03-28 18:09:22 +11:00
Sam
7038540af6
PERF: ensure sidebar section link index is correctly ordered ( #20854 )
...
We perform lookups on sidebar section links based on sidebar_section_id
totally ignoring user. This ensures we have an index to work with.
This removes the previous index `links_user_id_section_id_position` which
partially doubled up `idx_unique_sidebar_section_links`
2023-03-28 15:13:44 +11:00
Penar Musaraj
cb92ea3c2b
UX: Take sticky header into account when spacebar scrolling ( #20848 )
2023-03-27 20:37:01 -04:00
Krzysztof Kotlarek
326a7a47e7
FIX: global sidebar section icon not moving on scroll ( #20851 )
...
Global section icon is using absolute position. To make it move on scroll, the parent element has to be relative.
https://meta.discourse.org/t/globe-icon-at-sidebar-behaves-badly/259382
2023-03-28 10:13:27 +11:00
Canapin
2dba3ab7c9
UX: Improve the "install theme/component" modal on mobile ( #20777 )
2023-03-27 14:11:31 -04:00
NullVoxPopuli
e988628186
DEV: Update browserslist ( #20846 )
...
Silences some verbose logging while booting the UI
2023-03-27 19:15:04 +02:00
Jarek Radosz
cbabc01e0e
DEV: Make capabilities into a service ( #18678 )
2023-03-27 19:06:36 +02:00
Daniel Waterworth
d563b73202
DEV: Make category topic_ids cache work like other caches ( #20814 )
2023-03-27 09:23:29 -05:00
Daniel Waterworth
3e80ab3143
DEV: Make category subcategory_ids cache work like other caches ( #20815 )
2023-03-27 09:23:23 -05:00
Daniel Waterworth
b2554e1490
DEV: Make hex cache work like other caches ( #20816 )
2023-03-27 09:22:53 -05:00
Daniel Waterworth
0f4bb19524
DEV: make developer cache work like other caches ( #20817 )
2023-03-27 09:22:33 -05:00
dependabot[bot]
3d0b67372f
Build(deps): Bump @uppy/aws-s3-multipart in /app/assets/javascripts ( #20032 )
...
Bumps [@uppy/aws-s3-multipart](https://github.com/transloadit/uppy ) from 3.1.1 to 3.1.2.
- [Release notes](https://github.com/transloadit/uppy/releases )
- [Changelog](https://github.com/transloadit/uppy/blob/main/CHANGELOG.md )
- [Commits](https://github.com/transloadit/uppy/compare/@uppy/aws-s3-multipart@3.1.1...@uppy/aws-s3-multipart@3.1.2 )
---
updated-dependencies:
- dependency-name: "@uppy/aws-s3-multipart"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-27 13:38:11 +02:00
dependabot[bot]
f425e9c66c
Build(deps): Bump @uppy/utils in /app/assets/javascripts ( #20567 )
...
Bumps [@uppy/utils](https://github.com/transloadit/uppy ) from 5.1.2 to 5.1.3.
- [Release notes](https://github.com/transloadit/uppy/releases )
- [Changelog](https://github.com/transloadit/uppy/blob/main/CHANGELOG.md )
- [Commits](https://github.com/transloadit/uppy/compare/@uppy/utils@5.1.2...@uppy/utils@5.1.3 )
---
updated-dependencies:
- dependency-name: "@uppy/utils"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-27 13:35:34 +02:00
dependabot[bot]
142ef6088c
Build(deps): Bump @uppy/aws-s3 in /app/assets/javascripts ( #20033 )
...
Bumps [@uppy/aws-s3](https://github.com/transloadit/uppy ) from 3.0.4 to 3.0.5.
- [Release notes](https://github.com/transloadit/uppy/releases )
- [Changelog](https://github.com/transloadit/uppy/blob/main/CHANGELOG.md )
- [Commits](https://github.com/transloadit/uppy/compare/@uppy/aws-s3@3.0.4...@uppy/aws-s3@3.0.5 )
---
updated-dependencies:
- dependency-name: "@uppy/aws-s3"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-27 12:50:56 +02:00
dependabot[bot]
dd0c9a96b9
Build(deps): Bump @popperjs/core in /app/assets/javascripts ( #20831 )
...
Bumps [@popperjs/core](https://github.com/popperjs/popper-core ) from 2.11.6 to 2.11.7.
- [Release notes](https://github.com/popperjs/popper-core/releases )
- [Commits](https://github.com/popperjs/popper-core/compare/v2.11.6...v2.11.7 )
---
updated-dependencies:
- dependency-name: "@popperjs/core"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-27 11:52:53 +02:00
dependabot[bot]
f56a6a1c28
Build(deps): Bump sinon from 15.0.2 to 15.0.3 in /app/assets/javascripts ( #20829 )
...
Bumps [sinon](https://github.com/sinonjs/sinon ) from 15.0.2 to 15.0.3.
- [Release notes](https://github.com/sinonjs/sinon/releases )
- [Changelog](https://github.com/sinonjs/sinon/blob/main/docs/changelog.md )
- [Commits](https://github.com/sinonjs/sinon/compare/v15.0.2...v15.0.3 )
---
updated-dependencies:
- dependency-name: sinon
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-27 11:51:33 +02:00
dependabot[bot]
e7ef5afb1b
Build(deps): Bump sass from 1.59.3 to 1.60.0 in /app/assets/javascripts ( #20830 )
...
Bumps [sass](https://github.com/sass/dart-sass ) from 1.59.3 to 1.60.0.
- [Release notes](https://github.com/sass/dart-sass/releases )
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md )
- [Commits](https://github.com/sass/dart-sass/compare/1.59.3...1.60.0 )
---
updated-dependencies:
- dependency-name: sass
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-27 11:50:55 +02:00
dependabot[bot]
30417b7f18
Build(deps): Bump terser in /app/assets/javascripts ( #20832 )
...
Bumps [terser](https://github.com/terser/terser ) from 5.16.6 to 5.16.8.
- [Release notes](https://github.com/terser/terser/releases )
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/terser/terser/compare/v5.16.6...v5.16.8 )
---
updated-dependencies:
- dependency-name: terser
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-27 11:50:06 +02:00
Ted Johansson
392cea5852
DEV: Only show plugin tab for admin ( #20841 )
...
As part of another regression, we realized that the plugins tab is visible to moderators, but they cannot interact with anything inside without triggering authorization errors.
This change hides the plugin tab for non-admin users.
2023-03-27 16:08:16 +08:00
Krzysztof Kotlarek
e0cf2849fd
FIX: admin always see configure default sidebar categories ( #20836 )
...
When an admin removes all the categories from their personal sidebar configuration, the section should remain visible to them with the “Configure default categories” prompt.
Similar solution for tags.
/t/95036
2023-03-27 15:46:39 +11:00
Alan Guo Xiang Tan
e0155b6955
DEV: Introduce dedicated controller and route for discovery.filter ( #20837 )
...
Instead of being tied to the old implementation and constraints, a
dedicated route and controller for the `discovery.filter` app route will
allow us to iterate on changes much faster.
2023-03-27 10:08:11 +08:00
Krzysztof Kotlarek
4047073292
FIX: display validation under custom sidebar fields ( #20772 )
...
Before, incorrectly filled fields were marked with red border. Now, additional information under the field is displayed to notify the user what is incorrect.
/t/93696
2023-03-27 13:03:16 +11:00
Keegan George
c66323f964
UX: Make table wrapper popup button icon only ( #20820 )
2023-03-24 13:23:05 -07:00
David Taylor
e47af9bb72
FIX: Check for staff without triggering anonymous user error ( #20819 )
...
Followup to 142d2ab65e
2023-03-24 19:11:57 +00:00
Keegan George
83db0bf41a
FIX: Post height issues with Expand Table button ( #18810 )
2023-03-24 11:55:49 -07:00
Daniel Waterworth
0728fa055b
DEV: Make theme cache work like other caches ( #20813 )
2023-03-24 12:37:16 -05:00
Daniel Waterworth
7e23e6c1e8
DEV: Make banner cache work like other caches ( #20811 )
2023-03-24 12:36:55 -05:00
Kris
88004873ec
A11Y: usernames aren't a meaningful heading ( #20623 )
2023-03-24 13:22:22 -04:00
Andrei Prigorshnev
19b0dbe59d
UX: Show titles on site settings navigation menu items ( #20794 )
...
In some languages, labels on the site settings navigation menu
get truncated. This adds titles to menu items, so users can see
untruncated labels on hover.
2023-03-24 20:46:10 +04:00
David Taylor
fc3c737a7f
UX: Restore reviewable counts on hamburger for legacy navigation ( #20807 )
...
Previously we disabled the hamburger reviewable count badge when the redesigned user menu was enabled. This commit updates the logic so that the hamburger reviewable count is tied the legacy navigation mode instead. This ensures that there is always a persistent reviewable count visible. (in the non-legacy navigation modes, the total reviewable count is shown in the sidebar)
2023-03-24 14:34:32 +00:00
David Taylor
9b41700f87
DEV: Use component class instead of string in user-menu API ( #20806 )
...
In the future we'll be looking at things like tree-shaking and code-splitting. Using 'magic strings' to resolve components is not compatible with those techniques. It makes sense to switch to a more modern pattern now, before the new user-tab API is used too widely.
This commit is backwards-compatible. API consumers which pass a string will see a deprecation message asking them to pass a component class instead.
This commit also turns some unneeded getters into simple class properties (no need to use a getter when it just returns a constant).
2023-03-24 14:26:30 +00:00
Bianca Nenciu
142d2ab65e
FEATURE: Move bootstrap mode indicator to header ( #20663 )
...
The information about bootstrap mode has been moved from the notice to
the README topic for admins.
2023-03-24 15:59:03 +02:00
Jarek Radosz
a39a7028ab
DEV: Remove server-side-only entry for /upgrade ( #20804 )
...
After the docker_manager upgrade (https://github.com/discourse/docker_manager/pull/167 ) this is no longer needed.
2023-03-24 13:11:25 +01:00
dependabot[bot]
75cd3821c6
Build(deps): Bump webpack in /app/assets/javascripts ( #20798 )
...
Bumps [webpack](https://github.com/webpack/webpack ) from 5.76.2 to 5.76.3.
- [Release notes](https://github.com/webpack/webpack/releases )
- [Commits](https://github.com/webpack/webpack/compare/v5.76.2...v5.76.3 )
---
updated-dependencies:
- dependency-name: webpack
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-24 13:10:34 +01:00
Jordan Vidrine
d533f316e8
UX: Fix mobile grippie being hidden ( #20803 )
2023-03-24 07:04:09 -05:00
David Taylor
d2617c4904
UX: Allow opening user-menu tabs in new tab/window ( #20792 )
...
This commit turns the new user menu tabs into `<a href` elements. This means that the tab's associated URL is shown on mouseover, and also allows the browser to handle navigation when a modifier key is pressed (e.g. ctrl, shift, mod).
2023-03-24 08:18:23 +00:00
Krzysztof Kotlarek
4929288bdd
FIX: delay custom section reorder ( #20799 )
...
Reorder should start after 300ms.
In addition, pointer events should be blocked to not open link after reorder is finished.
2023-03-24 13:58:05 +11:00
dependabot[bot]
a6166c5b32
Build(deps): Bump @glimmer/syntax in /app/assets/javascripts ( #20797 )
...
Bumps [@glimmer/syntax](https://github.com/glimmerjs/glimmer-vm ) from 0.84.2 to 0.84.3.
- [Release notes](https://github.com/glimmerjs/glimmer-vm/releases )
- [Changelog](https://github.com/glimmerjs/glimmer-vm/blob/master/CHANGELOG.md )
- [Commits](https://github.com/glimmerjs/glimmer-vm/compare/v0.84.2...v0.84.3 )
---
updated-dependencies:
- dependency-name: "@glimmer/syntax"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-23 23:20:33 +01:00
Mark VanLandingham
ebada4a6b0
DEV: More specific API to including extra associations in CategoryList ( #20790 )
2023-03-23 12:39:38 -05:00
David Taylor
fe127b166d
DEV: Add {{yield}} to user-stream-item for plugins/themes ( #20791 )
...
This means that plugins/themes can re-use the core component and also introduce their own footer
2023-03-23 15:32:00 +00:00
Jordan Vidrine
5238e96377
FIX: Avoid double-encoding featured topic title in user profile ( #20740 )
2023-03-23 13:36:37 +00:00
David Taylor
bee61d4faf
DEV: Convert composer controller to native class syntax ( #20723 )
...
Actions are moved from actions: {} to top-level functions with @action decorator. Previously we had a save() action and a top-level function of the same name, so this commit renames the action to avoid a clash.
2023-03-23 13:36:03 +00:00
David Taylor
b81767c1b1
SECURITY: Limit URL length for theme remote ( #20787 )
2023-03-23 12:01:04 +00:00
Joffrey JAFFEUX
165a3217c8
Revert "FIX: delay custom section reorder ( #20781 )" ( #20786 )
...
This reverts commit 4fe79ccc79
2023-03-23 11:27:12 +01:00
Alan Guo Xiang Tan
2d46824a87
DEV: Switch to data attributes to represent sidebar section name ( #20771 )
...
Data attributes are less restrictive than the class attribute.
2023-03-23 13:09:45 +08:00
Krzysztof Kotlarek
4fe79ccc79
FIX: delay custom section reorder ( #20781 )
...
Reorder should start after 300ms.
In addition, pointer events should be blocked to not open link after reorder is finished.
2023-03-23 15:05:36 +11:00
Alan Guo Xiang Tan
4cb79ce8be
UX: Styling adjustments for filters page ( #20768 )
...
Change styling of filter input & remove button.
This follows the same pattern of design we use for search. In the search dropdown we do not have a button to search. We rely on pressing enter. I've also provided an example of Github's PR filter UI at the bottom of this comment.
We also do not have buttons like this on any other topic-list header. On tag and category dropdowns, we also rely on pressing enter to filter the topic list by chosen categories & tags.
Co-authored-by: Jordan Vidrine <jordan@jordanvidrine.com>
2023-03-23 06:28:47 +08:00
Mark VanLandingham
32aa821f12
DEV: Add preload API to CategoryList ( #20778 )
2023-03-22 15:12:08 -05:00
Bianca Nenciu
f12e77d500
FIX: Do not allow anonymous users to be anonymized ( #20776 )
2023-03-22 20:51:42 +02:00
dependabot[bot]
16b0db77b5
Build(deps): Bump webpack in /app/assets/javascripts ( #20695 )
...
Bumps [webpack](https://github.com/webpack/webpack ) from 5.76.1 to 5.76.2.
- [Release notes](https://github.com/webpack/webpack/releases )
- [Commits](https://github.com/webpack/webpack/compare/v5.76.1...v5.76.2 )
---
updated-dependencies:
- dependency-name: webpack
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-22 11:59:35 +01:00
