github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-01-31 11:15:14 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
39,188 Commits 214 Branches 500 Tags 960 MiB
4dd07843c6
Commit Graph

23278 Commits

Author SHA1 Message Date
Joffrey JAFFEUX
de038c0eab
FIX: highlightjs 10 requires some languages to be loaded before others (#10584) 
cs is also not present in 10 and relies only on csharp file, but for cs alias to work csharp has to be loaded.
 2020-09-02 21:32:57 +02:00
Penar Musaraj
6a837c32e4
DEV: Add class to wizard HTML element 2020-09-02 14:53:38 -04:00
Penar Musaraj
50827684d5
UX: Hide category settings badges checkbox when enable_badges is off 2020-09-02 11:23:59 -04:00
Robin Ward
0a492829ea Add category id to webhook post serializer 2020-09-02 10:42:51 -04:00
Joffrey JAFFEUX
c6e336b519
REFACTOR: simplifies connectors code (#10579) 
- directly uses factoryFor to avoid having to set owner later
- drops jquery usage
- renames view into component as I find it more explicit
 2020-09-02 15:53:42 +02:00
Joe
879e274dc7 UX: wrap extra long links in GitHub oneboxes instead of overflowing 2020-09-02 21:50:57 +08:00
Gerhard Schlager
31c1d57228
FIX: System message wasn't fully translatable 2020-09-02 15:24:25 +02:00
Dan Ungureanu
ef68e11137
FIX: Check if invite has expired before showing it (#10581) 2020-09-02 13:24:49 +03:00
Guo Xiang Tan
01600492de
FIX: Don't raise error in update username job if user has been deleted. 2020-09-02 11:17:17 +08:00
awesomerobot
ec0b4b2acc FIX: wait for groups before showing empty message 2020-09-01 22:36:00 -04:00
Jeff Wong
d49e96c6a3
DEV: add plugin hooks for silence message parameters (#10538) 
DEV: add plugin hooks for silence message parameters

Allows plugins to add, and update extra silence message params for custom
i18n vars

Allows plugins to override system messages via `message_title` and
`message_raw` parameters. We can later expose these params where necessary via event
hooks. Expose the parameter for the on user_silenced trigger.
 2020-09-01 17:25:24 -07:00
Kane York
26ec4fd25b
FIX: User export category preferences on a deleted category. (#10573) 
Tests from a1dd761bd9 were incomplete and did not test a deleted category's category_users record.
 2020-09-01 13:22:59 -07:00
Ahmed Gagan
b14098ce28
removed REGEXP_IN_MATCH regex to make it flexible to use with plugins (#10476) 
* dynamic regex generation for 'STATUS' and 'IN' ddropdown
 2020-09-01 14:33:05 +02:00
Arpit Jalan
34478760b2 Update annotations. 2020-09-01 13:41:04 +05:30
Joffrey JAFFEUX
f8062300da
DEV: removes jquery usage from highlight-syntax (#10564) 2020-09-01 09:50:49 +02:00
Arpit Jalan
bb2e830010 Remove out-of-date / non-core annotations. 2020-09-01 12:40:57 +05:30
Arpit Jalan
e66eefe179 Annotate models. 2020-09-01 10:22:32 +05:30
Krzysztof Kotlarek
084e15b447
FIX: modify notification after remove auto_watch_category (#10568) 
When a category is removed from `auto_watch_category` we are removing
CategoryUser. However, there are still TopicUser with notification level
set to `watching` which was inherited from Category.

We should move them back to `regular` unless they were modified by a user.
 2020-09-01 13:07:41 +10:00
awesomerobot
e824385e64 only remove edit button margin when text is hidden 2020-08-31 22:45:43 -04:00
Guo Xiang Tan
069a109cbb
DEV: Require scheduled job in development to avoid loading file twice. 
This removes the need to memoize constant in order to avoid the "warning: already initialized constant".
 2020-09-01 10:14:40 +08:00
Kane York
a1dd761bd9
FIX: Handle deleted categories in post export (#10567) 
Fixes a crash when exporting my own archive on Meta.
 2020-08-31 17:33:28 -07:00
Martin Brennan
594d919d22
FIX: Focus first button in topic admin menu (#10562) 
When using Shift+A to toggle the admin menu for a topic the first button was not focused, so the menu could not be navigated with tab.
 2020-09-01 10:29:35 +10:00
Kane York
5ec5fbd7ba
User export improvements 2 (#10560) 
* FEATURE: Use predictable filenames inside the user archive export

* FEATURE: Include badges in user archive export

* FEATURE: Add user_visits table to the user archive export
 2020-08-31 15:26:51 -07:00
Joe
c3560a66f3 DEV: CSS truncation followup 
After merging this

58fe78bf28 (diff-fed21847d651f6eb2cc76abbd770f5f8)

I noticed that the code I'm removing in this commit is causing text to be truncated a bit early on desktop. So, I'm removing it for now.
 2020-09-01 02:01:17 +08:00
tshenry
2550c5bd03
FIX: Ensure disabling 2FA works as expected (#10485) 2020-08-31 09:56:57 -07:00
Roman Rizzi
2a3a173e8e
FIX: Disable insert link button when editing a category (#10549) 2020-08-31 13:50:40 -03:00
Joe
58fe78bf28 UX: don't wrap topic status icons in the header if there's more than one 
Context: https://meta.discourse.org/t/when-a-topic-is-closed-and-pinned-the-pin-icon-in-header-not-in-correct-place/162473

Flex is causing a bit of a problem here since it makes the `topic-statuses` div in the header wrap when it has more than one icon. Given that we already use grid on the parent and that the icons are aligned properly, I think it's safe to remove it here.
 2020-09-01 00:40:42 +08:00
Bianca Nenciu
f2e14a3946
FEATURE: Add site setting and wizard step to set base font (#10250) 
Co-authored-by: Neil Lalonde <neillalonde@gmail.com>
 2020-08-31 13:14:09 +03:00
Guo Xiang Tan
5270cd97ef
DEV: Leaking state in PostActionNotifier in tests take 2. 
Follow-up to a3b48826
 2020-08-31 12:55:42 +08:00
Guo Xiang Tan
a3b4882665
DEV: Leaking state in PostActionNotifier in tests. 
Follow-up to 8a0478b97d
 2020-08-31 12:04:17 +08:00
Sam Saffron
b31da92ede
DEV: clear last seen cache consistently 
Previously in some cases the test suite could fail due to a bad entry in
redis from previous tests

This ensures the correct cache is expired when needed

Additionally improves performance of the redis check
 2020-08-31 08:54:42 +10:00
Sam Saffron
8ca8a7edba
DEV: Lint file 
Ruby in warning mode complains about `foo *[]` instead `foo(*[])` is
preferred
 2020-08-31 08:52:01 +10:00
Penar Musaraj
b4c5f6631f
FIX: Do not set color_scheme_id in user options when no schemes are marked as selectable 2020-08-30 09:32:40 -04:00
Kris
7bba65b6f5
UX: Restyle user menu so user links are findable (#10554) 2020-08-28 20:20:59 -04:00
Kane York
c5dc729e77
FEATURE: Add category tracking state to user archive export (#10557) 
Tackling a simple table for the first actual new file in the user archive export.
 2020-08-28 13:16:31 -07:00
Robin Ward
aae97457d2
REFACTOR: Don't use layoutName in select-kit (#10556) 
Instead import the templates as modules, the way Ember CLI wants us to.
 2020-08-28 15:30:20 -04:00
Kane York
84dba3c1c7
FIX: UserAction did not have a types enum (#10553) 
This is important for Data Explorer to provide proper help text.
 2020-08-28 11:49:19 -07:00
Kane York
225cdba676 DEV: drop the explicit .each in UserArchive CSV writing 
I think this is mostly stylistic, but this helps prevent explosive typos in the enum_for() line.
 2020-08-28 11:46:53 -07:00
Kane York
4aed861336 DEV: minor refactors to ExportUserArchive(Spec) 2020-08-28 11:46:53 -07:00
Kane York
7bf199b0c4 DEV: Switch to new ExportUserArchive job 
We now use the newly created job class from the previous commit.
 2020-08-28 11:46:53 -07:00
Kane York
a8560d741f DEV: Create ExportUserArchive as clone of ExportCsvFile 
This is in preparation for improvements to the user archive export data.
Some refactors happened along the way, including calling the different _export methods 'components' of the zip file.

Additionally, make the test for post export much more comprehensive.

Copy sources:
  app/jobs/regular/export_csv_file.rb
  spec/jobs/export_csv_file_spec.rb
 2020-08-28 11:46:53 -07:00
Penar Musaraj
b7cfc9e861
FEATURE: User selectable color schemes (#10544) 2020-08-28 10:36:52 -04:00
Martin Brennan
2352f4bfc7
DEV: Replace SECURE_MEDIA_ROUTE const with other methods (#10545) 
This is so if the route changes this const won't be around to bite us, use the Rails route methods instead.
 2020-08-28 11:28:11 +10:00
Robin Ward
96edb7da38 REFACTOR: Move Mousetrap library to an import 2020-08-27 16:17:19 -04:00
Robin Ward
c172f2068d
REFACTOR: Remove $.cookie in favor of a local library based on it (#10548) 
This helps us out in a few ways:

1. It lessens our reliance on jQuery
2. It's slightly less code because it omits options we don't use
3. It is one less library to import and put into ES6 modules
 2020-08-27 14:07:51 -04:00
Vinoth Kannan
a8502ae1c4
FEATURE: add dismiss unread topics button when filtered by tag. (#10547) 2020-08-27 23:04:45 +05:30
Joffrey JAFFEUX
1cc5e8ea63
DEV: gives didRender and willRerender hooks to widgets (#10496) 
didRender will be called each time the widget is rendered
willRerender will be called the second time a widget is rendered to give an opportunity to clean some state before the tree is replaced
 2020-08-27 16:07:14 +02:00
David Taylor
89cb537fae
DEV: Switch letter avatar service to new domain (#10546) 2020-08-27 12:05:36 +01:00
Kane York
a51db9a7bf
UX: make category topic counts clickable on mobile (#10541) 2020-08-27 01:50:18 -07:00
Guo Xiang Tan
a4ec4c06e3
Fix the build. 2020-08-27 13:50:07 +08:00
Guo Xiang Tan
40c6d90df3 PERF: Create a partial regular post_search_data index on large sites. 
With the addition of `PostSearchData#private_message`, a partial
index consisting of only search data from regular posts can be created.
The partial index helps to speed up searches on large sites since PG
will not have to do an index scan on the entire search data index which
has shown to be a bottle neck.
 2020-08-27 13:42:00 +08:00
Blake Erickson
02833e133c FIX: Suspend API to require suspend_until and reason params 
These fields are required when using the UI and if `suspend_until`
params isn't used the user never is actually suspended so we should
require these fields when suspending a user.
 2020-08-26 19:05:48 -06:00
Kris
95179a5ab6 Button bar needs visible overflow, follow-up to 489443e 2020-08-26 20:52:03 -04:00
Kris
489443e3a9
UX: Better handling of long category names and button bar in composer (#10542) 2020-08-26 19:38:20 -04:00
Jordan Vidrine
7cdef9f793
Remove tag name from classList (#10540) 
* Remove tag name from classList
 2020-08-26 17:20:57 -05:00
Joshua Rosenfeld
1e6d125db6
FIX: Remove additional paths from robots.txt 
admin path is protected by guardian and thus inaccessible to crawlers

Follow up to b52143f
 2020-08-26 16:52:22 -04:00
Jordan Vidrine
ce2491dc2f
Css class additions (#10532) 
* Category Page / Tag Class Additions

These additions add:

-the name of the tag as a css class to discourse tags.
-'pinned' as a css class to pinned topics in the category view
 2020-08-26 12:21:47 -05:00
Joffrey JAFFEUX
f5eccdd0b8
FIX: ensures period-chooser is not losing query params (#10534) 
eg repro before:
- visit http://pr-discourse.test/top/weekly?f=foo
- select another period in the period chooser
- f=foo was gone

After this commit it should still be present
 2020-08-26 19:01:08 +02:00
Robin Ward
ff4de97dfd
REFACTOR: Move bootbox to an import instead of global variable (#10533) 2020-08-26 12:57:13 -04:00
Gerhard Schlager
354014099d Update copy and remove unused strings 2020-08-26 18:08:41 +02:00
David Taylor
4351fa435e
FIX: Correctly redirect after external login on subfolder sites (#10529) 2020-08-26 15:52:21 +01:00
jahan-ggn
ae7ff5eb73
FEATURE: Added sort by username for directory items (#10482) 
* done-sorting-usernames-on-users-page

* sorted-usernames-on-users-page

* spec written

* specs added
 2020-08-26 10:14:20 -04:00
Guo Xiang Tan
dbfb2a1e11
Minor follow-up bug fix for 5ff6c10. 2020-08-26 17:25:28 +08:00
Guo Xiang Tan
5ff6c10320
FIX: Ensure that topic timers belonging to trashed topics are destroyed. 2020-08-26 16:11:10 +08:00
Guo Xiang Tan
3cc761ac44
FIX: Clean up toggle closed topic timer when user is not authorized. 2020-08-26 12:59:05 +08:00
Guo Xiang Tan
5bca1aec48
FIX: Clean up topic_timers when no longer valid. 
This was causing a bug where the jobs for the topic_timers will keep
getting enqueued over and over again.
 2020-08-26 12:18:51 +08:00
Guo Xiang Tan
1e8f216e17
FIX: Ensure autoclose based on last post is executed by system user. 2020-08-26 12:08:46 +08:00
Guo Xiang Tan
ffc5bb7278
Revert "FIX: Topic Timer auto opening closed topics (#10524)" 
This reverts commit 7cfd5f87ff.
 2020-08-26 09:32:11 +08:00
Blake Erickson
7cfd5f87ff
FIX: Topic Timer auto opening closed topics (#10524) 
This commit is addressing an issue where it is possible that there could
be multiple topic timer jobs running to close a topic or a weird race
condition state causing a topic that was just closed to be re-opened.

By removing the logic from the Topic Timer model into the Topic Timer
controller endpoint we isolate the code that is used for setting an
auto-open or an auto-close timer to just that functionality making the
topic timer background jobs safer if multiple are running.

Possibly in the future if we would like this logic back in the model a
refactor will be needed where we actually pass in the auto-close and
auto-open action instead of mixing it with the close and open
action that is currently being passed to the controller.
 2020-08-26 11:17:12 +10:00
Kane York
93e136ae0e
UX: show a generic error on upload for XHR status 0 (#10521) 
This indication covers all cases of network errors, not just "cancelled by user".
The post upload component already has its own handling for user-cancelled uploads, but the generic upload component does not.

Tested by stopping my localhost server right before attempting to upload a file.
 2020-08-25 12:08:03 -07:00
Penar Musaraj
7277ca6cb6
UX: Add category-title-before to categories-boxes layout 
Makes it consistent with the other /categories layouts
 2020-08-25 13:35:13 -04:00
fzngagan
c363189858 Accounted for the change while reading the fields added specs to confirm working 2020-08-25 09:52:18 -04:00
fzngagan
352ad826c1 FIX: symbols and strings should be treated similarly while saving custom fields 2020-08-25 09:52:18 -04:00
Robin Ward
2523a21fc3 FIX: Server side rendering was broken with new helperContext() 2020-08-25 09:16:32 -04:00
Robin Ward
a3fb732b23 REFACTOR: We can reuse getOwner for some container stuff 2020-08-25 09:16:32 -04:00
Robin Ward
347a4981a0 REFACTOR: Remove Discourse constant from get-owner 2020-08-25 09:16:32 -04:00
Robin Ward
185ed80702 REFACTOR: Remove Discourse constants from nav-item 2020-08-25 09:16:32 -04:00
Robin Ward
c068098f75 REFACTOR: Remove container from User class 2020-08-25 09:16:32 -04:00
Robin Ward
c94ba34882 REFACTOR: Remove __container__ from Site 2020-08-25 09:16:32 -04:00
Robin Ward
ac498ae2a0 REFACTOR: Remove container from ajax 2020-08-25 09:16:32 -04:00
Robin Ward
df8ae6891c REFACTOR: Remove constants from text helper 2020-08-25 09:16:32 -04:00
Robin Ward
4063cab8c2 REFACTOR: Missed containers in DiscourseURL 2020-08-25 09:16:32 -04:00
Robin Ward
02e8d84e30 REFACTOR: Remove Discourse constant from showModal 2020-08-25 09:16:32 -04:00
Robin Ward
98e5e1cd53 REFACTOR: Remove container from DiscourseURL 2020-08-25 09:16:32 -04:00
Robin Ward
dae8b9bcfb FIX: Remove container from utilities 2020-08-25 09:16:32 -04:00
Robin Ward
89d766d089 REFACTOR: Remove container from safari-hacks 2020-08-25 09:16:32 -04:00
Robin Ward
c7c3fd4209 REFACTOR: Remove container from pwa-utils 2020-08-25 09:16:32 -04:00
Robin Ward
ebc0298ea0 REFACTOR: Remove Discourse.authenticationComplete 2020-08-25 09:16:32 -04:00
Robin Ward
20e1233f89 REFACTOR: Remove container from raw template helper 2020-08-25 09:16:32 -04:00
Gerhard Schlager
dac0e5b3cc
Merge pull request #10519 from gschlager/get-url 
Fixes for getURL() in subfolders and basePath in translations
 2020-08-25 11:42:50 +02:00
Jarek Radosz
e66f95de3a
FIX: DEV: Lock-on improvements (#10448) 
* DEV: Don't listen for deprecated events

https://developer.mozilla.org/en-US/docs/Web/API/Element/DOMMouseScroll_event

https://developer.mozilla.org/en-US/docs/Web/API/Element/mousewheel_event

* DEV: Listen only on the `body` element

* DEV: clearLock after a while if target is missing

* DEV: Bind the callback

* FIX: Use `requestAnimationFrame`

Prevents content jumps
 2020-08-25 11:42:00 +02:00
Gerhard Schlager
6c09fd4289 DEV: Remove unused code and translations 2020-08-25 11:41:19 +02:00
Joe
66aa94c515
UX: Timeline should jump to the bottom of the post in single-post topics (#10503) 2020-08-25 16:22:07 +08:00
Kris
a92a6b7b10 UX: Minor layout fixes and improved consistency on theme admin 2020-08-24 22:51:58 -04:00
Mark VanLandingham
cef51b3489
DEV: Remove hasBlock from user-info component (#10415) 2020-08-24 21:44:01 -05:00
Guo Xiang Tan
9c997ae117
Revert "DEV: allow plugins to send extra silenced message params" 
This reverts commit c3aeb442d7.

Broken specs so helping Jeff to revert first.
 2020-08-25 09:57:57 +08:00
Jeff Wong
c3aeb442d7 DEV: allow plugins to send extra silenced message params 
allows plugins to send extra custom message params so that they can
include things such as silence reason and message_body if desired
 2020-08-24 18:34:18 -07:00
Krzysztof Kotlarek
7b6f8517bf
FIX: limit number of users addable to group at once (#10510) 
When someone wants to add > 1000 users at once they will hit a timeout.
Therefore, we should introduce limit and inform the user when limit is exceeded.
 2020-08-25 08:55:21 +10:00
Neil Lalonde
ed30f49315
FIX: duplicate categories and tags allowed in inputs where they shouldn't be allowed 
blocklist was renamed to blockedCategories/Tags
 2020-08-24 17:37:04 -04:00
Neil Lalonde
52217099ed
FIX: group categories inputs not filled sometimes 
If you land on the group > manage > categories page or reload it,
the fields will all be blank when there should be categories.
 2020-08-24 17:15:37 -04:00