Guo Xiang Tan
b7b9960558
DEV: Fix missing port in URLs in development mode.
2019-05-06 13:26:57 +08:00
Sam Saffron
267d129f38
FEATURE: only scroll to bottom for discobot
...
Non discobot replies on PMs triggering scroll cause confusion.
2019-05-06 10:55:58 +10:00
Sam Saffron
d4bf7d6831
FIX: correctly display browser is old message to IE10
...
We dropped support for IE10 a while back but never amended the banner to
show it is not supported.
This properly drops support.
2019-05-06 10:45:45 +10:00
Sam Saffron
12e78d8915
DEV: add wrapper for rspec running in docker
2019-05-05 13:43:45 +10:00
Jeff Atwood
7799d29b12
copyedits on approval descriptions
2019-05-04 20:25:46 -07:00
Robin Ward
99a2a769d4
FIX: Conflict error (version was already used)
2019-05-03 16:36:37 -04:00
Vinoth Kannan
e8fafbc123
List and restore missing post uploads from S3 inventory.
2019-05-04 01:16:20 +05:30
Régis Hanol
bfcbfd7864
FIX: don't remap readonly columns
2019-05-03 20:30:23 +02:00
David Taylor
d82da69c2c
FIX: Fail gracefully if username parameter is missing when creating user
2019-05-03 17:17:06 +01:00
Robin Ward
15c9b00307
FEATURE: Show edit indicator on review queue
...
If a flagged post has edits, show the pencil icon and pop up the history
window when clicked.
2019-05-03 11:21:33 -04:00
Joffrey JAFFEUX
5f78bbebe9
FIX: forces a reload of emoji list if clicked on more ( #7473 )
...
This is a bit hacky but it's much more simple and reliable than many other solutions and doesnt involve having to manage some variable state.
2019-05-03 16:11:03 +02:00
David Taylor
0644c10bfe
FIX: Prioritize VERP key over final_recipient header in bounced email
...
Per RFC3464 2.3.2, the final_recipient header may not match the address we originally sent the email to.
2019-05-03 12:12:44 +01:00
Régis Hanol
0d41d58d27
FIX: add ReadOnly hear to /srv/status
2019-05-03 12:21:07 +02:00
Sam Saffron
16ef060a76
DEV: correct Rails 6 deprecation
...
render template is backwards compatible with Rails 5, code is simpler.
Thanks @jhawthorn, this is our last Rails 6 deprecation
2019-05-03 16:20:18 +10:00
Guo Xiang Tan
1815409a6f
DEV: Remove migration tests that have served their purpose.
2019-05-03 14:07:29 +08:00
Jeff Atwood
c37d959106
copyedit
2019-05-02 22:52:14 -07:00
Sam Saffron
3b77fb1fb1
DEV: support symlinked plugins in bin/rake autospec
...
Previously autospec would not pick up save if you saved a plugin in a
symlinked path, this broke quite a few workflows
We now maintain a reverse map so we can correctly re-run specs in plugins
2019-05-03 13:51:07 +10:00
Penar Musaraj
b948d97c8f
FEATURE: Show diff of local changes before updating remote theme ( #7443 )
2019-05-02 21:43:54 -04:00
Sam Saffron
413a54e7be
DEV: follow up on bb8cdf9e, assume no dupe bounce_keys
...
We may have tons of emails in the email logs, assume none are duplicate
hunting for duplication can be very expensive.
2019-05-03 10:52:15 +10:00
Jeff Atwood
ce2c19457a
omit needless words
2019-05-02 17:29:34 -07:00
Sam Saffron
bb8cdf9e5f
PERF: add missing bounce_key index to email_logs
...
We perform lookups based off bounce_key when emails bounce, we need the
index.
2019-05-03 08:48:01 +10:00
Sam Saffron
3dc4ab905c
DEV: annotate models
...
(also looks like renaming of bigint(8) -> bigint in annotate
which seems fine)
2019-05-03 08:34:12 +10:00
Robin Ward
3cb0d27d38
DEV: Upgrade our widget handlebars compiler
...
Now supports subexpressions such as i18n and concat, plus automatic
attaching of widgets similar to ember.
2019-05-02 15:47:57 -04:00
Joffrey JAFFEUX
e696903c31
FIX: uses translatedTitle to check validity of topic footer btn ( #7472 )
2019-05-02 20:56:27 +02:00
Joffrey JAFFEUX
35212036f2
FIX: ensures click on topic link has link for target and not children ( #7471 )
2019-05-02 13:43:02 +02:00
Joffrey JAFFEUX
4c444592d6
DEV: jquery 3.4.1 ( #7470 )
2019-05-02 12:18:32 +02:00
Guo Xiang Tan
d252dad4f0
FIX: Can't remove user profile uploads.
...
Follow up to 24347ace10ad54f7f3bbc687bc7bc37734f558e4.
2019-05-02 16:54:10 +08:00
Guo Xiang Tan
ebca588fd0
DEV: Remove unused line of code.
2019-05-02 16:54:10 +08:00
Joffrey JAFFEUX
75591664e7
FIX: better handling of category filter deselection ( #7468 )
2019-05-02 10:03:12 +02:00
Guo Xiang Tan
d5c9ac7196
PERF: Use cdn when serving site settings upload.
2019-05-02 15:35:07 +08:00
Guo Xiang Tan
24347ace10
FIX: Properly associate user_profiles background urls via upload id.
...
`Upload#url` is more likely and can change from time to time. When it
does changes, we don't want to have to look through multiple tables to
ensure that the URLs are all up to date. Instead, we simply associate
uploads properly to `UserProfile` so that it does not have to replicate
the URLs in the table.
2019-05-02 14:58:24 +08:00
Guo Xiang Tan
c9f6beba05
FIX: Incorrect DB query for AddUploadsToCategories
migration.
...
This is a regression as a result of 7896c74c2bd161f85c976fcd8468797721df30d9. Most instances would have ran the migrations and some might have run this migration with the incorrect query. Impact of this is small for now but I'm fixing this for correctness purposes.
2019-05-02 14:58:24 +08:00
Sam Saffron
96360a779f
DEV: add a few frozen string literals
2019-05-02 16:57:12 +10:00
Sam Saffron
1be01f8dd4
DEV: Add support for Rails 6
...
Minor fixes to add Rails 6 support to Discourse, we now will boot
with RAILS_MASTER=1, all specs pass
Only one tiny deprecation left
Largest change was the way ActiveModel:Errors changed interface a
bit but there is a simple backwards compat way of working it
2019-05-02 16:23:25 +10:00
Guo Xiang Tan
cf235fbd48
Fix bundler not requiring default group. Follow up to a2babcafd8264c94ebcc03d5237b2daf328d4e3e.
2019-05-02 13:25:17 +08:00
Joe
5a834a05ea
FIX: crawler layout CSS adjustments ( #7469 )
...
* Fix header size to fit the viewport
Setting the header to border-box means that the padding is factored in when calculating its width. If this is not done, the header width would be 100% of the viewport width + any padding when set on it. That causes some parts of the header to be rendered off-screen and causes horizontal scrolling.
* prevent code in posts from causing horizontal overflow
We are currently not wrapping code in posts in the crawler view. This affects both unformatted code and inline code blocks. This commit forces such code to wrap in order to prevent horizontal overflow which the Google bot complains about since it causes some content to be rendered outside of the viewport for the mobile crawler.
2019-05-02 13:00:29 +08:00
Sam Saffron
157dc5e298
FEATURE: disable native share API on non tablets/phones
...
Native share API works fantastically on phones/tablets but on full desktop
it is confusing.
2019-05-02 13:18:29 +10:00
Guo Xiang Tan
a2babcafd8
DEV: Don't require non production bundler assets in production.
2019-05-02 10:53:12 +08:00
Penar Musaraj
a5b804fec4
DEV: Add --profile and --fail-fast when running plugin specs, tweak parallel test balancing
2019-05-01 22:47:18 -04:00
Vinoth Kannan
28547c6f08
revert bundler version change
...
73418aaf73cf92053d60c05a32788e2791ef1eca
2019-05-02 04:37:55 +05:30
Vinoth Kannan
73418aaf73
DEV: Add bucket folder path to inventory id
2019-05-02 04:35:35 +05:30
Robin Ward
885f1e7e5f
FIX: Allow category group reviewers to edit queued posts
...
They can edit title, body and tags. Category is disabled for now as it
could lead to some odd security issues.
2019-05-01 14:48:49 -04:00
Robin Ward
0f01c9d25f
FIX: Posts in the approval queue were sometimes dropping category
2019-05-01 14:40:38 -04:00
Vinoth Kannan
92cc57b5da
FIX: make 'stats' method compatible with multisite.
...
a8f410a9c56c87b20449436a3b807955b8284b15
2019-05-01 23:34:18 +05:30
Arpit Jalan
8bedb6a4a3
fix the build
2019-05-01 23:12:50 +05:30
Arpit Jalan
b5ea50a154
FIX: use full screen login for new-topic route ( #7467 )
...
DEV: add javascript tests for new-topic and new-message routes
DEV: fix an existing test that was being skipped
2019-05-01 22:54:29 +05:30
Robin Ward
da0e37512a
FIX: Add test to confirm updating category works.
...
Also replaces a missing translation key that 99.9% of users would never
see.
2019-05-01 11:37:28 -04:00
Vinoth Kannan
7869a10d18
Revert "FEATURE: Added unlisted topics option to advanced search ( #7447 )"
...
This reverts commit 539723f8ffd6506fe3db24ed880471251b287c61 since it is failing the build.
2019-05-01 21:06:20 +05:30
Joffrey JAFFEUX
ae493f4722
UX: fills picker with emoji autocomplete state on more
click ( #7466 )
2019-05-01 16:19:45 +02:00
David Taylor
6fdbf15d6b
DEV: Remove Danger from travis build
2019-05-01 15:15:28 +01:00