Joffrey JAFFEUX 0764dc3452

FIX: cancel fetching messages after channel change (#21689) ...

This issue was especially visible in tests. the `@debounce(100)` was not cancelled when changing channel which was causing 404s as we were trying to load messages on a channel which was deleted as the channel has been destroyed at the end of the test.

This is still not a perfect solution, as we can only cancel the start of `fetchMessages`, but we can't cancel the actual `chatApi.channel` request which result can potentially happens after channel changed, which we try to mitigate with various checks on to ensure visible channel == loaded messages channel.

This commit also tries to make handler naming and cancelling more consistent.

<!-- NOTE: All pull requests should have tests (rspec in Ruby, qunit in JavaScript). If your code does not include test coverage, please include an explanation of why it was omitted. -->

2023-05-23 16:01:47 +02:00

..

chat

UI: chat composer step 2 (#21641)

2023-05-22 17:00:50 +02:00

chat-drawer

DEV: Rearchitect chat tracking state (#21550)

2023-05-16 14:51:13 +02:00

styleguide

FIX: various fixes to chat styleguide (#21617)

2023-05-17 20:03:19 +02:00

user-menu

DEV: Apply prettier to hbs files

2022-12-28 13:11:12 +00:00

channels-list.hbs

FIX: limits max height to viewport on channel only (#21539)

2023-05-15 11:46:33 +02:00

channels-list.js

FIX: limits max height to viewport on channel only (#21539)

2023-05-15 11:46:33 +02:00

chat-browse-view.hbs

FIX: limits max height to viewport on channel only (#21539)

2023-05-15 11:46:33 +02:00

chat-browse-view.js

DEV: start glimmer-ification and optimisations of chat plugin (#19531)

2022-12-21 13:21:02 +01:00

chat-channel-about-view.hbs

SECURITY: XSS on chat excerpts

2023-03-16 15:27:09 -06:00

chat-channel-about-view.js

FIX: Change wording from title -> name in channel about page (#19889)

2023-01-18 09:13:33 +10:00

chat-channel-archive-modal-inner.hbs

DEV: Apply prettier to hbs files

2022-12-28 13:11:12 +00:00

chat-channel-archive-modal-inner.js

DEV: converts models to native classes (#21418)

2023-05-08 18:24:41 +02:00

chat-channel-archive-status.hbs

DEV: converts models to native classes (#21418)

2023-05-08 18:24:41 +02:00

chat-channel-archive-status.js

DEV/ glimmerify chat-channel-status (#21445)

2023-05-09 09:22:25 +02:00

chat-channel-card.hbs

SECURITY: XSS on chat excerpts

2023-03-16 15:27:09 -06:00

chat-channel-card.js

DEV: start glimmer-ification and optimisations of chat plugin (#19531)

2022-12-21 13:21:02 +01:00

chat-channel-chooser-header.hbs

DEV: Apply prettier to hbs files

2022-12-28 13:11:12 +00:00

chat-channel-chooser-header.js

…

chat-channel-chooser-row.hbs

DEV: Apply prettier to hbs files

2022-12-28 13:11:12 +00:00

chat-channel-chooser-row.js

…

chat-channel-chooser.js

…

chat-channel-delete-modal-inner.hbs

DEV: Apply prettier to hbs files

2022-12-28 13:11:12 +00:00

chat-channel-delete-modal-inner.js

DEV: introduces documentation for chat (#19772)

2023-01-18 12:36:16 +01:00

chat-channel-leave-btn.hbs

DEV: converts models to native classes (#21418)

2023-05-08 18:24:41 +02:00

chat-channel-leave-btn.js

DEV: converts models to native classes (#21418)

2023-05-08 18:24:41 +02:00

chat-channel-members-view.hbs

FIX: limits max height to viewport on channel only (#21539)

2023-05-15 11:46:33 +02:00

chat-channel-members-view.js

DEV: start glimmer-ification and optimisations of chat plugin (#19531)

2022-12-21 13:21:02 +01:00

chat-channel-message-emoji-picker.hbs

DEV: Refactoring chat message actions for ChatMessage component usage in thread panel (#20756)

2023-04-06 15:19:52 +02:00

chat-channel-message-emoji-picker.js

DEV: Refactoring chat message actions for ChatMessage component usage in thread panel (#20756)

2023-04-06 15:19:52 +02:00

chat-channel-metadata.hbs

DEV: Fix random typos (#21638)

2023-05-18 15:34:46 +02:00

chat-channel-metadata.js

DEV: Fix random typos (#21638)

2023-05-18 15:34:46 +02:00

chat-channel-preview-card.hbs

FIX: Don't autojoin users when they have ready-only permissions (#20213)

2023-05-10 08:45:13 -03:00

chat-channel-preview-card.js

FIX: Don't autojoin users when they have ready-only permissions (#20213)

2023-05-10 08:45:13 -03:00

chat-channel-row.hbs

DEV: refactors routes to simplify using outlet (#20179)

2023-02-07 13:59:32 +01:00

chat-channel-row.js

DEV: Rearchitect chat tracking state (#21550)

2023-05-16 14:51:13 +02:00

chat-channel-selection-row.hbs

DEV: Apply prettier to hbs files

2022-12-28 13:11:12 +00:00

chat-channel-selection-row.js

DEV: converts models to native classes (#21418)

2023-05-08 18:24:41 +02:00

chat-channel-selector-modal-inner.hbs

DEV: converts models to native classes (#21418)

2023-05-08 18:24:41 +02:00

chat-channel-selector-modal-inner.js

DEV: converts models to native classes (#21418)

2023-05-08 18:24:41 +02:00

chat-channel-settings-saved-indicator.hbs

DEV: Apply prettier to hbs files

2022-12-28 13:11:12 +00:00

chat-channel-settings-saved-indicator.js

FEATURE: channels can allow/disallow @all/@here mentions (#19317)

2022-12-05 17:03:51 +01:00

chat-channel-settings-view.hbs

DEV: converts models to native classes (#21418)

2023-05-08 18:24:41 +02:00

chat-channel-settings-view.js

DEV: converts models to native classes (#21418)

2023-05-08 18:24:41 +02:00

chat-channel-status.hbs

DEV/ glimmerify chat-channel-status (#21445)

2023-05-09 09:22:25 +02:00

chat-channel-status.js

DEV/ glimmerify chat-channel-status (#21445)

2023-05-09 09:22:25 +02:00

chat-channel-title.hbs

DEV: converts models to native classes (#21418)

2023-05-08 18:24:41 +02:00

chat-channel-title.js

DEV: converts models to native classes (#21418)

2023-05-08 18:24:41 +02:00

chat-channel-toggle-view.hbs

DEV: Apply prettier to hbs files

2022-12-28 13:11:12 +00:00

chat-channel-toggle-view.js

DEV: start glimmer-ification and optimisations of chat plugin (#19531)

2022-12-21 13:21:02 +01:00

chat-channel-unread-indicator.hbs

DEV: Rearchitect chat tracking state (#21550)

2023-05-16 14:51:13 +02:00

chat-channel.hbs

DEV: various improvements to devex on chat (#21612)

2023-05-17 17:49:52 +02:00

chat-channel.js

FIX: cancel fetching messages after channel change (#21689)

2023-05-23 16:01:47 +02:00

chat-composer-dropdown.hbs

UI: chat composer step 2 (#21641)

2023-05-22 17:00:50 +02:00

chat-composer-dropdown.js

DEV: Fix random typos (#21638)

2023-05-18 15:34:46 +02:00

chat-composer-message-details.hbs

DEV: various improvements to devex on chat (#21612)

2023-05-17 17:49:52 +02:00

chat-composer-message-details.js

UX: improves composer and thread panel (#21210)

2023-04-25 10:23:03 +02:00

chat-composer-upload.hbs

UX: improves composer and thread panel (#21210)

2023-04-25 10:23:03 +02:00

chat-composer-upload.js

UX: improves composer and thread panel (#21210)

2023-04-25 10:23:03 +02:00

chat-composer-uploads.hbs

UX: improves composer and thread panel (#21210)

2023-04-25 10:23:03 +02:00

chat-composer-uploads.js

FIX: disables send btn while uploads in progress (#21298)

2023-05-02 18:11:40 +02:00

chat-composer.hbs

DEV: regroups composer button code (#21690)

2023-05-23 10:12:03 +02:00

chat-composer.js

UI: chat composer step 2 (#21641)

2023-05-22 17:00:50 +02:00

chat-draft-channel-screen.hbs

FIX: limits max height to viewport on channel only (#21539)

2023-05-15 11:46:33 +02:00

chat-draft-channel-screen.js

FIX: limits max height to viewport on channel only (#21539)

2023-05-15 11:46:33 +02:00

chat-drawer.hbs

DEV: Refactoring chat message actions for ChatMessage component usage in thread panel (#20756)

2023-04-06 15:19:52 +02:00

chat-drawer.js

FIX: apply clear-transition class to correct wrapper for chat drawer (#21129)

2023-04-18 08:37:13 +02:00

chat-emoji-avatar.hbs

DEV: Apply prettier to hbs files

2022-12-28 13:11:12 +00:00

chat-emoji-picker.hbs

FIX: relies on native focus behavior in chat emoji picker (#21092)

2023-04-13 20:35:13 +02:00

chat-emoji-picker.js

FIX: relies on native focus behavior in chat emoji picker (#21092)

2023-04-13 20:35:13 +02:00

chat-full-page-header.hbs

FIX: Add new chat threads icon and move thread list button to right (#21575)

2023-05-16 11:48:01 +02:00

chat-full-page-header.js

DEV: rework the chat-live-pane (#20519)

2023-03-03 13:09:25 +01:00

chat-header-icon-unread-indicator.hbs

DEV: Rearchitect chat tracking state (#21550)

2023-05-16 14:51:13 +02:00

chat-header-icon-unread-indicator.js

DEV: Rearchitect chat tracking state (#21550)

2023-05-16 14:51:13 +02:00

chat-header-icon.hbs

UX: update chat icon to d-chat (#20744)

2023-03-21 10:40:42 -04:00

chat-header-icon.js

UX: brings back URL on chat icon when in full page (#20092)

2023-01-31 10:16:45 +01:00

chat-mention-warnings.hbs

REFACTOR: Move mention warnings logic into a separate service. (#19465)

2023-02-03 15:38:30 -03:00

chat-mention-warnings.js

REFACTOR: Fix pluralized strings in chat plugin (#20357)

2023-02-20 10:31:02 +01:00

chat-message-actions-desktop.hbs

UX: implements draft threads (#21361)

2023-05-05 08:55:55 +02:00

chat-message-actions-desktop.js

DEV: various improvements to devex on chat (#21612)

2023-05-17 17:49:52 +02:00

chat-message-actions-mobile.hbs

UX: implements draft threads (#21361)

2023-05-05 08:55:55 +02:00

chat-message-actions-mobile.js

DEV: Refactoring chat message actions for ChatMessage component usage in thread panel (#20756)

2023-04-06 15:19:52 +02:00

chat-message-avatar.hbs

DEV: rework the chat-live-pane (#20519)

2023-03-03 13:09:25 +01:00

chat-message-collapser.hbs

DEV: Remove lazy-yt and replace with lazy-videos (#20722)

2023-03-29 11:54:25 -04:00

chat-message-collapser.js

DEV: Remove lazy-yt and replace with lazy-videos (#20722)

2023-03-29 11:54:25 -04:00

chat-message-in-reply-to-indicator.hbs

DEV: rework the chat-live-pane (#20519)

2023-03-03 13:09:25 +01:00

chat-message-in-reply-to-indicator.js

UX: implements draft threads (#21361)

2023-05-05 08:55:55 +02:00

chat-message-info.hbs

DEV: rework the chat-live-pane (#20519)

2023-03-03 13:09:25 +01:00

chat-message-info.js

DEV: rework the chat-live-pane (#20519)

2023-03-03 13:09:25 +01:00

chat-message-left-gutter.hbs

DEV: rework the chat-live-pane (#20519)

2023-03-03 13:09:25 +01:00

chat-message-left-gutter.js

DEV: rework the chat-live-pane (#20519)

2023-03-03 13:09:25 +01:00

chat-message-move-to-channel-modal-inner.hbs

DEV: rework the chat-live-pane (#20519)

2023-03-03 13:09:25 +01:00

chat-message-move-to-channel-modal-inner.js

DEV: routable chat part 2 (#20232)

2023-02-14 11:27:07 +01:00

chat-message-reaction.hbs

UX: prevents long press on reaction to open actions (#20899)

2023-03-30 20:01:38 +02:00

chat-message-reaction.js

DEV: Refactoring chat message actions for ChatMessage component usage in thread panel (#20756)

2023-04-06 15:19:52 +02:00

chat-message-separator-date.hbs

UX: Tweak last-visit/date separators (#20601)

2023-03-09 13:44:02 +01:00

chat-message-separator-new.hbs

DEV: rework the chat-live-pane (#20519)

2023-03-03 13:09:25 +01:00

chat-message-text.hbs

PERF: applies optimisations on chat-live pane (#20532)

2023-03-06 16:42:11 +01:00

chat-message-text.js

DEV: rework the chat-live-pane (#20519)

2023-03-03 13:09:25 +01:00

chat-message-thread-indicator.hbs

FEATURE: Thread list initial UI (#21412)

2023-05-10 11:42:32 +02:00

chat-message-thread-indicator.js

FEATURE: Thread list initial UI (#21412)

2023-05-10 11:42:32 +02:00

chat-message.hbs

UX: add indicator for msg from currentUser (#21657)

2023-05-19 11:33:56 +02:00

chat-message.js

DEV: various improvements to devex on chat (#21612)

2023-05-17 17:49:52 +02:00

chat-replying-indicator.hbs

FEATURE: chat-replying indicator for threads (#21485)

2023-05-11 08:02:04 +02:00

chat-replying-indicator.js

FEATURE: chat-replying indicator for threads (#21485)

2023-05-11 08:02:04 +02:00

chat-retention-reminder-text.hbs

REFACTOR: channel retention reminder text (#20310)

2023-02-15 14:50:01 +01:00

chat-retention-reminder-text.js

REFACTOR: channel retention reminder text (#20310)

2023-02-15 14:50:01 +01:00

chat-retention-reminder.hbs

DEV: rework the chat-live-pane (#20519)

2023-03-03 13:09:25 +01:00

chat-retention-reminder.js

DEV: rework the chat-live-pane (#20519)

2023-03-03 13:09:25 +01:00

chat-scroll-to-bottom-arrow.hbs

UX: remove new message element from chatpane (#21143)

2023-04-19 01:54:15 +02:00

chat-selection-manager.hbs

DEV: Correct hbs prettier violations

2023-02-02 13:03:11 +00:00

chat-selection-manager.js

DEV: converts models to native classes (#21418)

2023-05-08 18:24:41 +02:00

chat-side-panel-resizer.hbs

UX: improves composer and thread panel (#21210)

2023-04-25 10:23:03 +02:00

chat-side-panel.hbs

FIX: minor thread changes on mobile (#21457)

2023-05-09 22:38:44 +02:00

chat-side-panel.js

DEV: potential flakey specs fixes (#21307)

2023-04-28 22:06:27 +02:00

chat-skeleton.hbs

PERF: applies optimisations on chat-live pane (#20532)

2023-03-06 16:42:11 +01:00

chat-skeleton.js

DEV: rework the chat-live-pane (#20519)

2023-03-03 13:09:25 +01:00

chat-thread.hbs

DEV: various improvements to devex on chat (#21612)

2023-05-17 17:49:52 +02:00

chat-thread.js

DEV: Bump thread page size to 100 (#21691)

2023-05-23 10:43:39 +02:00

chat-to-topic-selector.hbs

DEV: Apply prettier to hbs files

2022-12-28 13:11:12 +00:00

chat-to-topic-selector.js

DEV: start glimmer-ification and optimisations of chat plugin (#19531)

2022-12-21 13:21:02 +01:00

chat-upload-drop-zone.hbs

UX: improves composer and thread panel (#21210)

2023-04-25 10:23:03 +02:00

chat-upload-drop-zone.js

UX: improves composer and thread panel (#21210)

2023-04-25 10:23:03 +02:00

chat-upload.hbs

FEATURE: Inline audio player for chat uploads (#20175)

2023-02-06 16:00:03 +10:00

chat-upload.js

FEATURE: Inline audio player for chat uploads (#20175)

2023-02-06 16:00:03 +10:00

chat-user-avatar.hbs

DEV: Apply prettier to hbs files

2022-12-28 13:11:12 +00:00

chat-user-avatar.js

…

chat-user-display-name.hbs

DEV: Apply prettier to hbs files

2022-12-28 13:11:12 +00:00

chat-user-display-name.js

…

chat-user-info.hbs

FIX: Chat member user card rendered out of view (#20332)

2023-02-17 10:14:00 -03:00

chat-user-info.js

FIX: Chat member user card rendered out of view (#20332)

2023-02-17 10:14:00 -03:00

chat-vh.js

FIX: chat height fixes (#21561)

2023-05-15 22:00:03 +02:00

collapser.hbs

PERF: applies optimisations on chat-live pane (#20532)

2023-03-06 16:42:11 +01:00

collapser.js

PERF: applies optimisations on chat-live pane (#20532)

2023-03-06 16:42:11 +01:00

d-progress-bar.hbs

DEV: Apply prettier to hbs files

2022-12-28 13:11:12 +00:00

d-progress-bar.js

…

dc-filter-input.hbs

FIX: Emoji autocomplete “more” button not working in chat (#20113)

2023-02-02 15:04:52 -03:00

dc-filter-input.js

…

direct-message-creator.hbs

FIX: chat height fixes (#21561)

2023-05-15 22:00:03 +02:00

direct-message-creator.js

FIX: limits max height to viewport on channel only (#21539)

2023-05-15 11:46:33 +02:00

full-page-chat.hbs

UX: improves composer and thread panel (#21210)

2023-04-25 10:23:03 +02:00

full-page-chat.js

DEV: rework the chat-live-pane (#20519)

2023-03-03 13:09:25 +01:00

on-visibility-action.hbs

DEV: Apply prettier to hbs files

2022-12-28 13:11:12 +00:00

on-visibility-action.js

…

reviewable-chat-message.hbs

DEV: Pass messageId as a dynamic segment instead of a query param (#20013)

2023-02-01 12:39:23 -03:00

reviewable-chat-message.js

DEV: Enable @cached decorator for themes and plugins (#19261)

2022-11-30 15:53:54 +00:00

sidebar-channels.hbs

DEV: routable chat part 2 (#20232)

2023-02-14 11:27:07 +01:00

sidebar-channels.js

DEV: routable chat part 2 (#20232)

2023-02-14 11:27:07 +01:00

toggle-channel-membership-button.hbs

DEV: Apply prettier to hbs files

2022-12-28 13:11:12 +00:00

toggle-channel-membership-button.js

DEV: start glimmer-ification and optimisations of chat plugin (#19531)

2022-12-21 13:21:02 +01:00

user-card-chat-button.hbs

UX: update chat icon to d-chat (#20744)

2023-03-21 10:40:42 -04:00

user-card-chat-button.js

DEV: routable chat part 2 (#20232)

2023-02-14 11:27:07 +01:00