mirror of
https://github.com/discourse/discourse.git
synced 2025-01-31 19:49:29 +08:00
37f4022f73
- Extracts certain logic to private methods and remove unnecessary comments - Extracts email enqueueing methods into a separate class - Fix specs involving UserEmailObserver to call #after_commit instead of the specific methods
95 lines
3.9 KiB
Ruby
95 lines
3.9 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe UserEmailObserver do
|
|
|
|
context 'user_mentioned' do
|
|
|
|
let(:user) { Fabricate(:user) }
|
|
let!(:notification) { Fabricate(:notification, user: user) }
|
|
|
|
it "enqueues a job for the email" do
|
|
Jobs.expects(:enqueue_in).with(SiteSetting.email_time_window_mins.minutes, :user_email, type: :user_mentioned, user_id: notification.user_id, notification_id: notification.id)
|
|
UserEmailObserver.send(:new).after_commit(notification)
|
|
end
|
|
|
|
it "doesn't enqueue an email if the user has mention emails disabled" do
|
|
user.expects(:email_direct?).returns(false)
|
|
Jobs.expects(:enqueue_in).with(SiteSetting.email_time_window_mins.minutes, :user_email, has_entry(type: :user_mentioned)).never
|
|
UserEmailObserver.send(:new).after_commit(notification)
|
|
end
|
|
|
|
end
|
|
|
|
context 'posted' do
|
|
|
|
let(:user) { Fabricate(:user) }
|
|
let!(:notification) { Fabricate(:notification, user: user, notification_type: 9) }
|
|
|
|
it "enqueues a job for the email" do
|
|
Jobs.expects(:enqueue_in).with(SiteSetting.email_time_window_mins.minutes, :user_email, type: :user_posted, user_id: notification.user_id, notification_id: notification.id)
|
|
UserEmailObserver.send(:new).after_commit(notification)
|
|
end
|
|
|
|
it "doesn't enqueue an email if the user has mention emails disabled" do
|
|
user.expects(:email_direct?).returns(false)
|
|
Jobs.expects(:enqueue_in).with(SiteSetting.email_time_window_mins.minutes, :user_email, has_entry(type: :user_posted)).never
|
|
UserEmailObserver.send(:new).after_commit(notification)
|
|
end
|
|
|
|
end
|
|
|
|
context 'user_replied' do
|
|
|
|
let(:user) { Fabricate(:user) }
|
|
let!(:notification) { Fabricate(:notification, user: user, notification_type: 2) }
|
|
|
|
it "enqueues a job for the email" do
|
|
Jobs.expects(:enqueue_in).with(SiteSetting.email_time_window_mins.minutes, :user_email, type: :user_replied, user_id: notification.user_id, notification_id: notification.id)
|
|
UserEmailObserver.send(:new).after_commit(notification)
|
|
end
|
|
|
|
it "doesn't enqueue an email if the user has mention emails disabled" do
|
|
user.expects(:email_direct?).returns(false)
|
|
Jobs.expects(:enqueue_in).with(SiteSetting.email_time_window_mins.minutes, :user_email, has_entry(type: :user_replied)).never
|
|
UserEmailObserver.send(:new).after_commit(notification)
|
|
end
|
|
|
|
end
|
|
|
|
context 'user_quoted' do
|
|
|
|
let(:user) { Fabricate(:user) }
|
|
let!(:notification) { Fabricate(:notification, user: user, notification_type: 3) }
|
|
|
|
it "enqueues a job for the email" do
|
|
Jobs.expects(:enqueue_in).with(SiteSetting.email_time_window_mins.minutes, :user_email, type: :user_quoted, user_id: notification.user_id, notification_id: notification.id)
|
|
UserEmailObserver.send(:new).after_commit(notification)
|
|
end
|
|
|
|
it "doesn't enqueue an email if the user has mention emails disabled" do
|
|
user.expects(:email_direct?).returns(false)
|
|
Jobs.expects(:enqueue_in).with(SiteSetting.email_time_window_mins.minutes, :user_email, has_entry(type: :user_quoted)).never
|
|
UserEmailObserver.send(:new).after_commit(notification)
|
|
end
|
|
|
|
end
|
|
|
|
context 'email_user_invited_to_private_message' do
|
|
|
|
let(:user) { Fabricate(:user) }
|
|
let!(:notification) { Fabricate(:notification, user: user, notification_type: 7) }
|
|
|
|
it "enqueues a job for the email" do
|
|
Jobs.expects(:enqueue_in).with(SiteSetting.email_time_window_mins.minutes, :user_email, type: :user_invited_to_private_message, user_id: notification.user_id, notification_id: notification.id)
|
|
UserEmailObserver.send(:new).after_commit(notification)
|
|
end
|
|
|
|
it "doesn't enqueue an email if the user has mention emails disabled" do
|
|
user.expects(:email_direct?).returns(false)
|
|
Jobs.expects(:enqueue_in).with(SiteSetting.email_time_window_mins.minutes, :user_email, has_entry(type: :user_invited_to_private_message)).never
|
|
UserEmailObserver.send(:new).after_commit(notification)
|
|
end
|
|
|
|
end
|
|
|
|
end |