mirror of
https://github.com/discourse/discourse.git
synced 2025-03-29 09:25:37 +08:00
0bdb616edc
In a recent commit when adding the review section link, I moved to a pattern where we allowed the section links to be refreshed after the section has been constructed. However, we were not tearing down the old section links when refreshing. This made me realise that refreshing section links in a section is not a pattern I want to adopt since people can easily forget to teardown. Instead, each section link should be responsible for defining a teardown function for cleanup which will always be called when the sidebar is removed.