mirror of
https://github.com/discourse/discourse.git
synced 2025-01-31 07:46:16 +08:00
67d568f709
For mentions within threads, the mentioned user can experience a stuck notification. This is due to thread memberships only being created for users who interact with a thread. Without the membership we cannot track if the message containing the mention was read by the user. The solution to this explored in this PR is: - auto add memberships for mentioned users (only direct mentions for performance reasons). - update channel/thread unread queries to check notification read status AND thread membership last read message id when counting mentions. Previously the mention count would remain until the user notification (containing the mention) was read. However this only happens if the user clicks the notification or clicks dismiss all notifications. When a user navigated to the thread without clicking the notification, the green/urgent badge on chat would remain even after a hard page refresh. |
||
|---|---|---|
| .. | ||
| category_channel_spec.rb | ||
| channel_archive_spec.rb | ||
| channel_spec.rb | ||
| direct_message_channel_spec.rb | ||
| direct_message_spec.rb | ||
| draft_spec.rb | ||
| incoming_webhook_spec.rb | ||
| message_reaction_spec.rb | ||
| message_revision_spec.rb | ||
| message_spec.rb | ||
| null_message_spec.rb | ||
| null_user_spec.rb | ||
| reviewable_chat_message_spec.rb | ||
| thread_spec.rb | ||
| user_chat_thread_membership_spec.rb | ||