mirror of
https://github.com/discourse/discourse.git
synced 2025-01-18 17:02:45 +08:00
1cbc65ba79
Why this change? Before this change, the `GroupNotificationsButton` is rendered in the template of `userPrivateMessages` route based on a conditional that checks if the `isGroup` property is true. However, the `isGroup` property is determined based on the child route that is rendered. However, this leads to "jankiness" in the UI because the `GroupNotificationsButton` will be rendered once the route is entered even if the model for the child route has not been resolved yet. What is the solution? In order to avoid this, we move the rendering of the `GroupNotificationsButton` into the template of the `userPrivateMessages.group` route and rely on the `in-element` helper to render it into the right spot in the template of the `userPrivateMessages` route. |
||
|---|---|---|
| .. | ||
| common | ||
| desktop | ||
| mobile | ||
| vendor | ||
| admin_rtl.scss | ||
| admin.scss | ||
| color_definitions.scss | ||
| common.scss | ||
| desktop_rtl.scss | ||
| desktop.scss | ||
| embed.scss | ||
| ember_cli.scss | ||
| mobile_rtl.scss | ||
| mobile.scss | ||
| publish.scss | ||
| qunit-custom.scss | ||
| qunit.scss | ||
| wcag.scss | ||
| wizard_rtl.scss | ||
| wizard.scss | ||