Ted Johansson f1a43f2319

DEV: Handle SSL errors in push notification pusher (#22771) ...

We're seeing unhandled errors in production when web push notifications are failing with an SSL error. This is happening for a few users, but generating a large amount of log noise due to the sheer number of notifications.

This adds handling of SSL errors in two places:

1. In FinalDestination::HTTP, this is handled the same as a timeout error, and gives a chance to recover.
2. In PushNotificationPusher. This will cause the notification to retry a number of times, and if it keeps failing, disable push notifications for the user. (Existing behaviour.)

I wanted to wrap the SSL error in e.g. WebPush::RequestError, but the gem doesn't have request error handling, so didn't want to have the freedom patch diverge from the gem as well. Instead just propagating the raw SSL error.

2023-07-25 15:01:02 +08:00

..

faraday_adapter.rb

…

fast_image.rb

SECURITY: Add FinalDestination::FastImage that's SSRF safe

2023-03-16 15:27:09 -06:00

http.rb

DEV: Handle SSL errors in push notification pusher (#22771)

2023-07-25 15:01:02 +08:00

resolver.rb

FIX: allow changing default DNS query timeout of 2s via GlobalSetting (#20383)

2023-02-21 09:54:29 +11:00

ssrf_detector.rb

DEV: Gracefully handle user avatar download SSRF errors (#21523)

2023-05-12 15:32:02 +08:00