mirror of
https://github.com/discourse/discourse.git
synced 2025-03-01 17:30:54 +08:00

This PR is introducing glimmer usage in the chat-live-pane, for components but also for models. RestModel usage has been dropped in favor of native classes. Other changes/additions in this PR: sticky dates, scrolling will now keep the date separator of the current section at the top of the screen better unread management, marking a channel as unread will correctly mark the correct message and not mark the whole channel as read. Tracking state will also now correctly return unread count and unread mentions. adds an animation on bottom arrow better scrolling behavior, we should now always correctly keep the scroll position while loading more reactions are now more reactive, and will update their tooltip without needed to close/reopen it skeleton has been improved with placeholder images and reactions when making a reaction on the desktop message actions, the menu won't move anymore simplify logic and stop maintaining a list of unloaded messages
211 lines
6.2 KiB
Ruby
211 lines
6.2 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe "Chat channel", type: :system, js: true do
|
|
fab!(:current_user) { Fabricate(:user) }
|
|
fab!(:channel_1) { Fabricate(:chat_channel) }
|
|
fab!(:message_1) { Fabricate(:chat_message, chat_channel: channel_1) }
|
|
|
|
let(:chat) { PageObjects::Pages::Chat.new }
|
|
let(:channel) { PageObjects::Pages::ChatChannel.new }
|
|
|
|
before { chat_system_bootstrap }
|
|
|
|
context "when sending a message" do
|
|
before do
|
|
channel_1.add(current_user)
|
|
sign_in(current_user)
|
|
end
|
|
|
|
context "with lots of messages" do
|
|
before { 50.times { Fabricate(:chat_message, chat_channel: channel_1) } }
|
|
|
|
it "loads most recent messages" do
|
|
unloaded_message = Fabricate(:chat_message, chat_channel: channel_1)
|
|
visit("/chat/c/-/#{channel_1.id}/#{message_1.id}")
|
|
|
|
expect(channel).to have_no_loading_skeleton
|
|
expect(page).to have_no_css("[data-id='#{unloaded_message.id}']")
|
|
|
|
channel.send_message("test_message")
|
|
|
|
expect(channel).to have_no_loading_skeleton
|
|
expect(page).to have_css("[data-id='#{unloaded_message.id}']")
|
|
end
|
|
end
|
|
|
|
it "allows to edit this message once persisted" do
|
|
chat.visit_channel(channel_1)
|
|
expect(channel).to have_no_loading_skeleton
|
|
channel.send_message("aaaaaaaaaaaaaaaaaaaa")
|
|
expect(page).to have_no_css(".chat-message-staged")
|
|
last_message = find(".chat-message-container:last-child")
|
|
last_message.hover
|
|
|
|
expect(page).to have_css(
|
|
".chat-message-actions-container[data-id='#{last_message["data-id"]}']",
|
|
)
|
|
end
|
|
end
|
|
|
|
context "when clicking the arrow button" do
|
|
before do
|
|
channel_1.add(current_user)
|
|
50.times { Fabricate(:chat_message, chat_channel: channel_1) }
|
|
sign_in(current_user)
|
|
end
|
|
|
|
it "jumps to the bottom of the channel" do
|
|
unloaded_message = Fabricate(:chat_message, chat_channel: channel_1)
|
|
visit("/chat/message/#{message_1.id}")
|
|
|
|
expect(channel).to have_no_loading_skeleton
|
|
expect(page).to have_no_css("[data-id='#{unloaded_message.id}']")
|
|
|
|
find(".chat-scroll-to-bottom").click
|
|
|
|
expect(channel).to have_no_loading_skeleton
|
|
expect(page).to have_css("[data-id='#{unloaded_message.id}']")
|
|
end
|
|
end
|
|
|
|
context "when returning to a channel where last read is not last message" do
|
|
before do
|
|
channel_1.add(current_user)
|
|
sign_in(current_user)
|
|
end
|
|
|
|
it "jumps to the bottom of the channel" do
|
|
channel_1.membership_for(current_user).update!(last_read_message: message_1)
|
|
messages = 50.times.map { Fabricate(:chat_message, chat_channel: channel_1) }
|
|
chat.visit_channel(channel_1)
|
|
|
|
expect(page).to have_css("[data-id='#{messages.first.id}']")
|
|
expect(page).to have_no_css("[data-id='#{messages.last.id}']")
|
|
end
|
|
end
|
|
|
|
context "when a new message is created" do
|
|
fab!(:other_user) { Fabricate(:user) }
|
|
|
|
before do
|
|
channel_1.add(other_user)
|
|
channel_1.add(current_user)
|
|
50.times { Fabricate(:chat_message, chat_channel: channel_1) }
|
|
sign_in(current_user)
|
|
end
|
|
|
|
it "doesn’t scroll the pane" do
|
|
visit("/chat/message/#{message_1.id}")
|
|
|
|
new_message =
|
|
Chat::ChatMessageCreator.create(
|
|
chat_channel: channel_1,
|
|
user: other_user,
|
|
content: "this is fine",
|
|
).chat_message
|
|
|
|
expect(page).to have_no_content(new_message.message)
|
|
end
|
|
end
|
|
|
|
context "when a message contains mentions" do
|
|
fab!(:other_user) { Fabricate(:user) }
|
|
|
|
before do
|
|
channel_1.add(other_user)
|
|
channel_1.add(current_user)
|
|
Fabricate(
|
|
:chat_message,
|
|
chat_channel: channel_1,
|
|
message: "hello @here @all @#{current_user.username} @#{other_user.username} @unexisting",
|
|
user: other_user,
|
|
)
|
|
sign_in(current_user)
|
|
end
|
|
|
|
it "highlights the mentions" do
|
|
chat.visit_channel(channel_1)
|
|
|
|
expect(page).to have_selector(".mention.highlighted.valid-mention", text: "@here")
|
|
expect(page).to have_selector(".mention.highlighted.valid-mention", text: "@all")
|
|
expect(page).to have_selector(
|
|
".mention.highlighted.valid-mention",
|
|
text: "@#{current_user.username}",
|
|
)
|
|
expect(page).to have_selector(".mention", text: "@#{other_user.username}")
|
|
expect(page).to have_selector(".mention", text: "@unexisting")
|
|
end
|
|
end
|
|
|
|
context "when reply is right under" do
|
|
fab!(:other_user) { Fabricate(:user) }
|
|
|
|
before do
|
|
Fabricate(:chat_message, in_reply_to: message_1, user: other_user, chat_channel: channel_1)
|
|
channel_1.add(other_user)
|
|
channel_1.add(current_user)
|
|
sign_in(current_user)
|
|
end
|
|
|
|
it "doesn’t show the reply-to line" do
|
|
chat.visit_channel(channel_1)
|
|
|
|
expect(page).to have_no_selector(".chat-reply__excerpt")
|
|
end
|
|
end
|
|
|
|
context "when reply is not directly connected" do
|
|
fab!(:other_user) { Fabricate(:user) }
|
|
|
|
before do
|
|
Fabricate(:chat_message, user: other_user, chat_channel: channel_1)
|
|
Fabricate(:chat_message, in_reply_to: message_1, user: other_user, chat_channel: channel_1)
|
|
channel_1.add(other_user)
|
|
channel_1.add(current_user)
|
|
sign_in(current_user)
|
|
end
|
|
|
|
it "shows the reply-to line" do
|
|
chat.visit_channel(channel_1)
|
|
|
|
expect(page).to have_selector(".chat-reply__excerpt")
|
|
end
|
|
end
|
|
|
|
context "when messages are separated by a day" do
|
|
before do
|
|
Fabricate(:chat_message, chat_channel: channel_1, created_at: 2.days.ago)
|
|
|
|
channel_1.add(current_user)
|
|
sign_in(current_user)
|
|
end
|
|
|
|
it "shows a date separator" do
|
|
chat.visit_channel(channel_1)
|
|
|
|
expect(page).to have_selector(".chat-message-separator__text", text: "Today")
|
|
end
|
|
end
|
|
|
|
context "when a message contains code fence" do
|
|
fab!(:message_2) { Fabricate(:chat_message, chat_channel: channel_1, message: <<~MESSAGE) }
|
|
Here's a message with code highlighting
|
|
|
|
\`\`\`ruby
|
|
Widget.triangulate(arg: "test")
|
|
\`\`\`
|
|
MESSAGE
|
|
|
|
before do
|
|
channel_1.add(current_user)
|
|
sign_in(current_user)
|
|
end
|
|
|
|
it "adds the correct lang" do
|
|
chat.visit_channel(channel_1)
|
|
|
|
expect(page).to have_selector("code.lang-ruby")
|
|
end
|
|
end
|
|
end
|