github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-21 11:16:58 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
discourse/spec/lib
History
Krzysztof Kotlarek 5830f2c9a1
FIX: double reviewable items bug (#28161) 
When `SiteSetting.review_every_post` is true and the category `require_topic_approval` system creates two reviewable items.
1. Firstly, because the category needs approval, the `ReviewableQueuePost` record` is created - at this stage, no topic is created.
2. Admin is approving the review. The topic and first post are created.
3. Because `review_every_post` is true `queue_for_review_if_possible` callback is evaluated and `ReviewablePost` is created.
4. Then `ReviewableQueuePost` is linked to the newly generated topic and post.

At the beginning, we were thinking about hooking to those guards:
```
  def self.queue_for_review_if_possible(post, created_or_edited_by)
    return unless SiteSetting.review_every_post
    return if post.post_type != Post.types[:regular] || post.topic.private_message?
    return if Reviewable.pending.where(target: post).exists?
...
```
And add something like
```
 return if Reviewable.approved.where(target: post).exists?
```

However, because the callback happens in point 3. before the `ReviewableQueuePost` is linked to the `Topic`, it was not possible.

Therefore, when `ReviewableQueuePost` is creating a `Topic`, a new option called `:reviewed_queued_post` is passed to `PostCreator` to avoid creating a second `Reviewable`.
2024-07-31 12:45:00 +10:00
..
active_support_type_extensions
DEV: Move more service code to core (#26613)
2024-04-12 13:14:19 +02:00
auth
DEV: Upgrade Rails to version 7.1
2024-07-04 10:58:21 +02:00
backup_restore
DEV: Use freeze_time_safe in more places (#25949)
2024-03-01 10:07:35 +10:00
common_passwords
DEV: Fix various spec linting issues (#24672)
2023-12-04 13:45:19 +01:00
compression
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
concern
FIX: do not use return in block (#26260)
2024-03-20 10:49:28 +01:00
content_security_policy
FIX: correctly strip unneeded csp directives under strict-dynamic (#26180)
2024-03-14 18:50:09 +00:00
discourse_webauthn
DEV: Fix random typos (#26881)
2024-05-06 20:52:48 +02:00
email
UX: Use a dropdown for SSL mode for group SMTP (#27932)
2024-07-18 10:33:14 +10:00
file_store
DEV: Allow fab! without block (#24314)
2023-11-09 16:47:59 -06:00
final_destination
SECURITY: Add FastImage SSRF safe freedom patch
2024-07-03 20:49:15 +08:00
freedom_patches
SECURITY: Add FastImage SSRF safe freedom patch
2024-07-03 20:49:15 +08:00
guardian
FEATURE: the ability to change the order of flags (#27269)
2024-06-05 13:27:06 +10:00
highlight_js
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
i18n
DEV: Update I18n to 1.13.0 (#21685)
2023-05-24 08:59:37 +08:00
imap
DEV: Remove old TODOs for message-id formats (#27196)
2024-05-28 13:57:09 +10:00
import
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
middleware
FEATURE: Only count topic views for explicit/deferred tracked views (#27533)
2024-07-03 10:38:49 +10:00
migration
DEV: Upgrade Rails to version 7.1
2024-07-04 10:58:21 +02:00
onebox
SECURITY: Fixes for main (#28137)
2024-07-30 14:19:01 +08:00
plugin
FIX: Don’t list values from disabled plugins
2024-07-11 10:51:48 +02:00
pretty_text
FEATURE: Async load of category and chat hashtags (#25526)
2024-02-12 12:07:14 +02:00
rate_limiter
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
scheduler
PERF: Don't allow a single user to monopolize the defer queue (#25593)
2024-02-07 13:47:50 -06:00
second_factor
DEV: Allow run_second_factor! to be used before login (#25420)
2024-01-29 12:28:47 +00:00
seed_data
FIX: "Replace Text" didn't list "Welcome Topic" when "General" category is missing (#27182)
2024-05-27 09:57:30 +02:00
site_settings
FEATURE: optional 2FA enforcement (#27506)
2024-06-19 09:32:30 +10:00
stylesheet
SECURITY: Generate more category CSS on client
2024-03-15 14:24:11 +08:00
svg_sprite
DEV: Allow fab! without block (#24314)
2023-11-09 16:47:59 -06:00
theme_settings_manager
DEV: Remove experimental_objects_type_for_theme_settings site setting (#26507)
2024-04-04 12:01:31 +08:00
theme_store
FEATURE: Theme settings migrations (#24071)
2023-11-02 08:10:15 +03:00
topic_query
DEV: Remove full group refreshes from tests (#25414)
2024-01-25 14:28:26 +08:00
turbo_tests/flaky
DEV: Include exception details for each test in flaky tests report (#24892)
2023-12-14 11:11:11 +08:00
validators
DEV: add validation on content_security_policy_script_src site setting (#27564)
2024-06-21 17:00:22 +08:00
wizard
DEV: Update member access wizard step to use toggle group (#28013)
2024-07-29 14:07:06 +08:00
admin_confirmation_spec.rb
DEV: Allow fab! without block (#24314)
2023-11-09 16:47:59 -06:00
admin_user_index_query_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
archetype_spec.rb
DEV: Catch missing translations during test runs (#26258)
2024-05-24 22:15:53 +08:00
bookmark_manager_spec.rb
DEV: Allow fab! without block (#24314)
2023-11-09 16:47:59 -06:00
bookmark_query_spec.rb
DEV: Allow fab! without block (#24314)
2023-11-09 16:47:59 -06:00
bookmark_reminder_notification_handler_spec.rb
DEV: Allow fab! without block (#24314)
2023-11-09 16:47:59 -06:00
bookmarks_bulk_action_spec.rb
FIX: Bulk clear reminders when the reminder is expired (#27220)
2024-05-28 10:21:33 -03:00
browser_detection_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
cache_spec.rb
FIX: race condition in Discourse.cache.fetch (#28124)
2024-07-30 09:08:12 +02:00
category_badge_spec.rb
FIX: email category badges shouldn't use category text color (#25655)
2024-02-13 10:18:36 -05:00
category_guardian_spec.rb
DEV: Allow fab! without block (#24314)
2023-11-09 16:47:59 -06:00
color_math_spec.rb
UX: Calculate missing hover/selected colors from existing colors (#20105)
2023-02-01 09:55:21 +00:00
composer_messages_finder_spec.rb
DEV: move post flags into database (#27125)
2024-05-23 12:19:07 +10:00
content_buffer_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
content_security_policy_spec.rb
DEV: add validation on content_security_policy_script_src site setting (#27564)
2024-06-21 17:00:22 +08:00
cooked_post_processor_spec.rb
FIX: BBCode tag parser
2024-06-18 10:47:18 +02:00
crawler_detection_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
current_user_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
db_helper_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
directory_helper_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
discourse_diff_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
discourse_event_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
discourse_hub_spec.rb
DEV: include more data in Discourse Discover enrollment payload. (#25846)
2024-02-25 10:42:50 +05:30
discourse_ip_info_spec.rb
FIX: Rescue and warn when error is encountered in DiscourseIpInfo.mmdb_download (#28134)
2024-07-30 11:33:20 +08:00
discourse_js_processor_spec.rb
DEV: @babel/plugin-proposal-decorators -> decorator-transforms (#27260)
2024-06-10 15:51:48 +01:00
discourse_logstash_logger_spec.rb
DEV: Log sidekiq job opts as string instead of hash (#28012)
2024-07-23 06:27:43 +08:00
discourse_plugin_registry_spec.rb
DEV: Remove sprockets from plugin 'extra js' pipeline (#25502)
2024-02-01 11:48:31 +00:00
discourse_redis_spec.rb
DEV: Fix various spec linting issues (#24672)
2023-12-04 13:45:19 +01:00
discourse_sourcemapping_url_processor_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
discourse_spec.rb
FIX: Sort plugins by their setting category name (#25128)
2024-01-08 09:57:25 +10:00
discourse_tagging_spec.rb
FIX: Handle tags with underscores correctly (#26839)
2024-05-01 20:01:39 -05:00
discourse_updates_spec.rb
FEATURE: call hub API to update Discourse discover enrollment. (#25634)
2024-02-23 11:42:28 +05:30
distributed_cache_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
distributed_memoizer_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
distributed_mutex_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
email_cook_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
email_updater_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
ember_cli_spec.rb
FIX: EmberCli cache clearance issue in production (#24343)
2023-11-13 10:34:06 +00:00
encodings_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
enum_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
excerpt_parser_spec.rb
FIX: Internal oneboxes with github links (#22829)
2023-07-28 09:07:53 -06:00
feed_element_installer_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
feed_item_accessor_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
file_helper_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
filter_best_posts_spec.rb
DEV: Allow fab! without block (#24314)
2023-11-09 16:47:59 -06:00
final_destination_spec.rb
FIX: FinalDestination#get forwarding Authorization header on redirects (#27043)
2024-05-16 08:37:34 +08:00
flag_settings_spec.rb
FEATURE: custom flag can require additional message (#27908)
2024-07-18 10:10:22 +10:00
gaps_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
gc_stat_instrumenter_spec.rb
DEV: Seperate concerns of tracking GC stat from MethodProfiler (#22921)
2023-08-02 10:46:37 +08:00
git_repo_spec.rb
FEATURE: display commit hash for each plugin on /admin/plugins page. (#22176)
2023-06-26 10:09:57 +05:30
git_url_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
global_path_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
group_lookup_spec.rb
DEV: Allow fab! without block (#24314)
2023-11-09 16:47:59 -06:00
guardian_spec.rb
FEATURE: admin can disable flags (#27171)
2024-05-29 14:39:58 +10:00
has_errors_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
hijack_spec.rb
DEV: Upgrade Rails to version 7.1
2024-07-04 10:58:21 +02:00
homepage_helper_spec.rb
DEV: Extract theme resolution to a helper (#27426)
2024-06-20 11:33:46 -04:00
html_prettify_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
html_to_markdown_spec.rb
FIX: HtmlToMarkdown should keep HTML entities for <, > and & within HTML elements
2024-06-10 16:03:30 +02:00
image_sizer_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
inline_oneboxer_spec.rb
DEV: update syntax tree to latest (#24623)
2023-11-29 16:38:07 +11:00
js_locale_helper_spec.rb
DEV: Refactor translation overrides a bit (#28125)
2024-07-30 09:56:46 +08:00
json_error_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
letter_avatar_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
message_id_service_spec.rb
DEV: Remove old TODOs for message-id formats (#27196)
2024-05-28 13:57:09 +10:00
method_profiler_spec.rb
DEV: Seperate concerns of tracking GC stat from MethodProfiler (#22921)
2023-08-02 10:46:37 +08:00
mini_sql_multisite_connection_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
mobile_detection_spec.rb
Drop support for iOS < 15.7 (#19847)
2023-01-16 17:28:59 +00:00
new_post_manager_spec.rb
DEV: Automatically update groups for test users with explicit TL (#25415)
2024-01-29 17:52:02 +08:00
new_post_result_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
onebox_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
oneboxer_spec.rb
FEATURE: use new site setting for onebox custom user agent. (#28045)
2024-07-24 04:45:30 +05:30
onpdiff_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
password_hasher_spec.rb
FEATURE: Persist password hashing algorithm/params in database (#20980)
2023-04-11 10:16:28 +01:00
pbkdf2_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
pinned_check_spec.rb
DEV: Fix various spec linting issues (#24672)
2023-12-04 13:45:19 +01:00
plain_text_to_markdown_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
post_action_creator_spec.rb
DEV: Make all admins TL4 in tests (#25435)
2024-03-26 11:41:12 +08:00
post_action_destroyer_spec.rb
DEV: Convert min_trust_to_flag_posts setting to groups (#24864)
2023-12-13 17:18:42 +08:00
post_creator_spec.rb
FIX: double reviewable items bug (#28161)
2024-07-31 12:45:00 +10:00
post_destroyer_spec.rb
DEV: Make all admins TL4 in tests (#25435)
2024-03-26 11:41:12 +08:00
post_jobs_enqueuer_spec.rb
DEV: Update the rubocop-discourse gem
2023-06-26 11:41:52 +02:00
post_locker_spec.rb
DEV: Allow fab! without block (#24314)
2023-11-09 16:47:59 -06:00
post_merger_spec.rb
DEV: Allow fab! without block (#24314)
2023-11-09 16:47:59 -06:00
post_revisor_spec.rb
DEV: move post flags into database (#27125)
2024-05-23 12:19:07 +10:00
presence_channel_spec.rb
DEV: Allow fab! without block (#24314)
2023-11-09 16:47:59 -06:00
pretty_text_spec.rb
SECURITY: Fixes for main (#28137)
2024-07-30 14:19:01 +08:00
promotion_spec.rb
FIX: Do not validate email in TL promotion (#20892)
2023-03-30 13:52:10 +10:00
quote_comparer_spec.rb
DEV: Correct Style/RedundantReturn rubocop issues (#23052)
2023-08-10 02:03:38 +02:00
quote_rewriter_spec.rb
DEV: Update display name in new quote format - Part 2 (#22104)
2023-06-26 11:01:59 +08:00
rate_limiter_spec.rb
DEV: Allow fab! without block (#24314)
2023-11-09 16:47:59 -06:00
retrieve_title_spec.rb
FIX: Don't error out when trying to retrieve title and URL won't encode (#24660)
2023-12-01 15:03:06 +08:00
rtl_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
s3_cors_rulesets_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
s3_helper_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
s3_inventory_multisite_spec.rb
DEV: Introduce hidden s3_inventory_bucket site setting (#27304)
2024-06-10 13:16:00 +08:00
s3_inventory_spec.rb
DEV: Restore missing_s3_uploads stats count if site was restored (#27984)
2024-07-19 14:22:58 +08:00
score_calculator_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
scss_checker_spec.rb
DEV: Allow fab! without block (#24314)
2023-11-09 16:47:59 -06:00
search_spec.rb
DEV: Restrict include:unlisted search option to users that can view unlisted topics (#27977)
2024-07-18 16:33:14 -03:00
secure_session_spec.rb
DEV: Fix various rubocop lints (#24749)
2023-12-06 23:25:00 +01:00
shrink_uploaded_image_spec.rb
DEV: Move min_trust_to_post_embedded_media to group setting (#25238)
2024-01-25 09:50:59 +10:00
sidebar_section_links_updater_spec.rb
DEV: Limit the number of category sidebar links a user can have (#26756)
2024-04-25 13:21:39 -05:00
sidekiq_long_running_job_logger_spec.rb
DEV: Add ability to log a warning when Sidekiq job runs for too long (#27446)
2024-06-13 14:24:44 +08:00
signal_trap_logger_spec.rb
DEV: Move spec file to right folder (#27449)
2024-06-13 06:38:03 +08:00
site_icon_manager_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
site_setting_extension_multisite_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
site_setting_extension_spec.rb
DEV: Upgrade Rails to version 7.1
2024-07-04 10:58:21 +02:00
slug_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
spam_handler_spec.rb
DEV: Remove full group refreshes from tests (#25414)
2024-01-25 14:28:26 +08:00
steps_inspector_spec.rb
DEV: Show parameters on a service contract failure
2024-06-13 12:19:26 +02:00
suggested_topics_builder_spec.rb
DEV: Allow fab! without block (#24314)
2023-11-09 16:47:59 -06:00
system_message_spec.rb
DEV: Allow fab! without block (#24314)
2023-11-09 16:47:59 -06:00
text_cleaner_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
text_sentinel_spec.rb
FIX: Allow all caps within CJK text (#28018)
2024-07-22 17:35:52 +02:00
theme_flag_modifier_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
theme_javascript_compiler_spec.rb
DEV: @babel/plugin-proposal-decorators -> decorator-transforms (#27260)
2024-06-10 15:51:48 +01:00
theme_settings_manager_spec.rb
DEV: Refactor subclasses in ThemeSettingsManager to individual files (#25605)
2024-02-08 12:59:52 +08:00
theme_settings_object_validator_spec.rb
DEV: Add isValidUrl helper function to theme migrations (#26817)
2024-04-30 16:45:07 +08:00
theme_settings_parser_spec.rb
DEV: Fix various rubocop lints (#24749)
2023-12-06 23:25:00 +01:00
theme_settings_validator_spec.rb
DEV: Correctly pluralize error messages (#26469)
2024-04-04 15:02:09 +02:00
timeline_lookup_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
tiny_japanese_segmenter_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
topic_creator_spec.rb
FIX: Skip tags-related validations when the skip_validations option is present (#26379)
2024-03-27 12:56:21 +03:00
topic_publisher_spec.rb
DEV: Allow fab! without block (#24314)
2023-11-09 16:47:59 -06:00
topic_query_spec.rb
DEV: Block accidental serialization of entire AR models (#27668)
2024-07-01 17:08:48 -03:00
topic_retriever_spec.rb
FEATURE: Update topic/comment embedding parameters (#20181)
2023-02-28 14:31:59 +02:00
topic_upload_security_manager_spec.rb
DEV: Update the rubocop-discourse gem
2023-06-26 11:41:52 +02:00
topic_view_spec.rb
DEV: cleanup custom filters to prevent leaks
2024-04-29 16:11:12 +02:00
topics_bulk_action_spec.rb
DEV: Convert min_trust_level_to_tag_topics to groups (#25273)
2024-01-26 13:25:03 +08:00
topics_filter_spec.rb
FIX: experimental topics filter should allow tags with underscore (#27994)
2024-07-20 00:58:29 +04:00
trashable_spec.rb
DEV: Added .only_deleted scope in the Trashable module (#20196)
2023-02-07 15:28:59 -03:00
truncate_logs_formatter_spec.rb
SECURITY: Add a default limit as to when logs should be truncated
2023-10-16 10:34:38 -04:00
trust_level_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
twitter_api_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
unread_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
upload_creator_spec.rb
DEV: depend less on pngquant version (#26906)
2024-05-07 16:56:05 +02:00
upload_markdown_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
upload_recovery_spec.rb
DEV: Move min_trust_to_post_embedded_media to group setting (#25238)
2024-01-25 09:50:59 +10:00
upload_security_spec.rb
DEV: Fix various spec linting issues (#24672)
2023-12-04 13:45:19 +01:00
url_helper_spec.rb
DEV: Add isValidUrl helper function to theme migrations (#26817)
2024-04-30 16:45:07 +08:00
user_comm_screener_spec.rb
DEV: Update the rubocop-discourse gem
2023-06-26 11:41:52 +02:00
user_lookup_spec.rb
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
user_name_suggester_spec.rb
DEV: Fix various spec linting issues (#24672)
2023-12-04 13:45:19 +01:00
version_spec.rb
SECURITY: Add limits for themes and theme assets
2023-09-12 15:31:31 -03:00
work_queue_spec.rb
PERF: Don't allow a single user to monopolize the defer queue (#25593)
2024-02-07 13:47:50 -06:00