mirror of
https://github.com/discourse/discourse.git
synced 2025-02-12 19:06:14 +08:00
ae3231e140
When we were deleting messages in chat, we would find all of the UserChatChannelMembership records that had a matching last_read_message_id and set that column to NULL. This became an issue when multiple users had that deleted message set to their last_read_message_id. When we called ChannelUnreadsQuery to get the unread count for each of the user's channels, we were COALESCing the last_read_message_id and returning 0 if it was NULL, which meant that the unread count for the channel would be the total count of the messages not sent by the user in that channel. This was particularly noticeable for DM channels since we show the count with the indicator in the header. This issue would disappear as soon as the user opened the problem channel, because we would then set the last_read_message_id to an actual ID. To circumvent this, instead of NULLifying the last_read_message_id in most cases, it makes more sense to just set it to the most recent non-deleted chat message ID for the channel. The only time it will be set to NULL now is when there are no more other messages in the channel.
31 lines
949 B
Ruby
31 lines
949 B
Ruby
# frozen_string_literal: true
|
|
|
|
module Chat
|
|
class MessageDestroyer
|
|
def destroy_in_batches(chat_messages_query, batch_size: 200)
|
|
chat_messages_query
|
|
.in_batches(of: batch_size)
|
|
.each do |relation|
|
|
destroyed_ids = relation.destroy_all.pluck(:id, :chat_channel_id)
|
|
destroyed_message_ids = destroyed_ids.map(&:first).uniq
|
|
destroyed_message_channel_ids = destroyed_ids.map(&:second).uniq
|
|
reset_last_read(destroyed_message_ids, destroyed_message_channel_ids)
|
|
delete_flags(destroyed_message_ids)
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def reset_last_read(destroyed_message_ids, destroyed_message_channel_ids)
|
|
::Chat::Action::ResetUserLastReadChannelMessage.call(
|
|
destroyed_message_ids,
|
|
destroyed_message_channel_ids,
|
|
)
|
|
end
|
|
|
|
def delete_flags(message_ids)
|
|
Chat::ReviewableMessage.where(target_id: message_ids).destroy_all
|
|
end
|
|
end
|
|
end
|