mirror of
https://github.com/discourse/discourse.git
synced 2025-01-18 11:42:53 +08:00
8e3691d537
Before this change, calling `StyleSheet::Manager.stylesheet_details` for the first time resulted in multiple queries to the database. This is because the code was modelled in a way where each `Theme` was loaded from the database one at a time. This PR restructures the code such that it allows us to load all the theme records in a single query. It also allows us to eager load the required associations upfront. In order to achieve this, I removed the support of loading multiple themes per request. It was initially added to support user selectable theme components but the feature was never completed and abandoned because it wasn't a feature that we thought was worth building.
63 lines
1.4 KiB
Ruby
63 lines
1.4 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
class QunitController < ApplicationController
|
|
skip_before_action *%i{
|
|
check_xhr
|
|
preload_json
|
|
redirect_to_login_if_required
|
|
}
|
|
layout false
|
|
|
|
# only used in test / dev
|
|
def index
|
|
raise Discourse::InvalidAccess.new if Rails.env.production?
|
|
end
|
|
|
|
def theme
|
|
raise Discourse::NotFound.new if !can_see_theme_qunit?
|
|
|
|
param_key = nil
|
|
@suggested_themes = nil
|
|
if (id = get_param(:id)).present?
|
|
theme = Theme.find_by(id: id.to_i)
|
|
param_key = :id
|
|
elsif (name = get_param(:name)).present?
|
|
theme = Theme.find_by(name: name)
|
|
param_key = :name
|
|
elsif (url = get_param(:url)).present?
|
|
theme = RemoteTheme.find_by(remote_url: url)&.theme
|
|
param_key = :url
|
|
end
|
|
|
|
if param_key && theme.blank?
|
|
return render plain: "Can't find theme with #{param_key} #{params[param_key].inspect}", status: :not_found
|
|
end
|
|
|
|
if !param_key
|
|
@suggested_themes = Theme
|
|
.where(
|
|
id: ThemeField.where(target_id: Theme.targets[:tests_js]).distinct.pluck(:theme_id)
|
|
)
|
|
.order(updated_at: :desc)
|
|
.pluck(:id, :name)
|
|
return
|
|
end
|
|
|
|
request.env[:resolved_theme_id] = theme.id
|
|
request.env[:skip_theme_ids_transformation] = true
|
|
end
|
|
|
|
protected
|
|
|
|
def can_see_theme_qunit?
|
|
return true if !Rails.env.production?
|
|
current_user&.admin?
|
|
end
|
|
|
|
private
|
|
|
|
def get_param(key)
|
|
params[:"theme_#{key}"] || params[key]
|
|
end
|
|
end
|