discourse

mirror of https://github.com/discourse/discourse.git synced 2025-03-29 13:46:40 +08:00

History

Joffrey JAFFEUX 821e9cb649

PERF: avoids eager pluck in posts controller (#21973 )

Calling pluck is instantly making a SELECT, while passing the relationship allows rails to build a correct query.

Before (2 selects):

```
pry(main)> Post.where(topic_id: Topic.where(id: [1,3,4]).pluck(:id)).count
   (1.3ms)  SELECT "topics"."id" FROM "topics" WHERE "topics"."deleted_at" IS NULL AND "topics"."id" IN (1, 3, 4)
  Post Count (0.5ms)  SELECT COUNT(*) FROM "posts" WHERE "posts"."deleted_at" IS NULL AND "posts"."topic_id" IN (1, 3, 4)
```

After (1 select):

```
pry(main)> Post.where(topic_id: Topic.where(id: [1,3,4])).count
  Post Count (2.7ms)  SELECT COUNT(*) FROM "posts" WHERE "posts"."deleted_at" IS NULL AND "posts"."topic_id" IN (SELECT "topics"."id" FROM "topics" WHERE "topics"."deleted_at" IS NULL AND "topics"."id" IN (1, 3, 4))
```

2023-06-07 13:30:38 +02:00

assets

DEV: Convert modal wrapper from named outlet to component (#21970 )

2023-06-07 10:41:29 +01:00

controllers

PERF: avoids eager pluck in posts controller (#21973 )

2023-06-07 13:30:38 +02:00

helpers

UX: Improve login required page (#20847 )

2023-03-28 07:09:44 -05:00

jobs

FIX: consider users.created_at for inactive cleanup (#21688 )