mirror of
https://github.com/discourse/discourse.git
synced 2025-01-18 14:52:46 +08:00
82d6420e31
What is the problem? Before this change, we were relying on the `/tags` endpoint which returned all the tags that are visible to a give user on the site leading to potential performance problems. The attribute keys of the response also changes based on the `tags_listed_by_group` site setting. What is the fix? This commit fixes the problems listed above by creating a dedicate `#list` action in the `TagsController` to handle the listing of the tags in the edit navigation menu tags modal. This is because the `TagsController#index` action was created specifically for the `/tags` route and the response body does not really map well to what we need. The `TagsController#list` action added here is also much safer since the response is paginated and we avoid loading a whole bunch of tags upfront. |
||
|---|---|---|
| .. | ||
| composer | ||
| emojis | ||
| page_objects | ||
| user_page | ||
| admin_customize_form_templates_spec.rb | ||
| admin_customize_themes_spec.rb | ||
| bookmarks_spec.rb | ||
| category_edit_spec.rb | ||
| category_topics_spec.rb | ||
| custom_sidebar_sections_spec.rb | ||
| discovery_breadcrumb_navigation_spec.rb | ||
| dismiss_topics_spec.rb | ||
| editing_sidebar_categories_navigation_spec.rb | ||
| editing_sidebar_tags_navigation_spec.rb | ||
| ember_deprecation_test.rb | ||
| fast_edit_spec.rb | ||
| filtering_topics_spec.rb | ||
| hashtag_autocomplete_spec.rb | ||
| network_disconnected_spec.rb | ||
| reviewables_spec.rb | ||
| search_spec.rb | ||
| tag_notification_level_spec.rb | ||
| tag_synonyms_spec.rb | ||
| topic_page_spec.rb | ||
| topic_summarization_spec.rb | ||
| user_preferences_interface_spec.rb | ||
| user_preferences_navigation_spec.rb | ||
| user_selector_spec.rb | ||
| viewing_category_spec.rb | ||
| viewing_navigation_menu_preferences_spec.rb | ||
| viewing_sidebar_as_anonymous_user_spec.rb | ||
| viewing_sidebar_mobile_spec.rb | ||
| viewing_sidebar_spec.rb | ||
| viewing_user_private_messages_spec.rb | ||