mirror of
https://github.com/discourse/discourse.git
synced 2025-04-01 21:06:15 +08:00
4ea21fa2d0
This change both speeds up specs (less strings to allocate) and helps catch cases where methods in Discourse are mutating inputs. Overall we will be migrating everything to use #frozen_string_literal: true it will take a while, but this is the first and safest move in this direction
83 lines
2.2 KiB
Ruby
83 lines
2.2 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
require_dependency 'discourse_version_check'
|
|
|
|
describe Admin::DashboardController do
|
|
before do
|
|
AdminDashboardData.stubs(:fetch_cached_stats).returns(reports: [])
|
|
Jobs::VersionCheck.any_instance.stubs(:execute).returns(true)
|
|
end
|
|
|
|
it "is a subclass of AdminController" do
|
|
expect(Admin::DashboardController < Admin::AdminController).to eq(true)
|
|
end
|
|
|
|
context 'while logged in as an admin' do
|
|
let(:admin) { Fabricate(:admin) }
|
|
|
|
before do
|
|
sign_in(admin)
|
|
end
|
|
|
|
describe '#index' do
|
|
context 'version checking is enabled' do
|
|
before do
|
|
SiteSetting.version_checks = true
|
|
end
|
|
|
|
it 'returns discourse version info' do
|
|
get "/admin/dashboard.json"
|
|
|
|
expect(response.status).to eq(200)
|
|
expect(JSON.parse(response.body)['version_check']).to be_present
|
|
end
|
|
end
|
|
|
|
context 'version checking is disabled' do
|
|
before do
|
|
SiteSetting.version_checks = false
|
|
end
|
|
|
|
it 'does not return discourse version info' do
|
|
get "/admin/dashboard.json"
|
|
expect(response.status).to eq(200)
|
|
json = JSON.parse(response.body)
|
|
expect(json['version_check']).not_to be_present
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#problems' do
|
|
context 'when there are no problems' do
|
|
before do
|
|
AdminDashboardData.stubs(:fetch_problems).returns([])
|
|
end
|
|
|
|
it 'returns an empty array' do
|
|
get "/admin/dashboard/problems.json"
|
|
|
|
expect(response.status).to eq(200)
|
|
json = JSON.parse(response.body)
|
|
expect(json['problems'].size).to eq(0)
|
|
end
|
|
end
|
|
|
|
context 'when there are problems' do
|
|
before do
|
|
AdminDashboardData.stubs(:fetch_problems).returns(['Not enough awesome', 'Too much sass'])
|
|
end
|
|
|
|
it 'returns an array of strings' do
|
|
get "/admin/dashboard/problems.json"
|
|
expect(response.status).to eq(200)
|
|
json = JSON.parse(response.body)
|
|
expect(json['problems'].size).to eq(2)
|
|
expect(json['problems'][0]).to be_a(String)
|
|
expect(json['problems'][1]).to be_a(String)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|