discourse/spec/jobs/notify_moved_posts_spec.rb
Mark VanLandingham df1fc5bca8
FIX: Consistently notify lowest post number if post_moved notification generation (#30448)
We currently query the posts table without an order when notifying users of moved posts. Generally the query will return the lowest post number post (b/c ID correlates with post_number in most cases) but not always. This adds an order to the post query in notify_moved_posts job.

Also I removed some if statement nesting with early returns / guard clauses.
2024-12-23 09:53:43 -06:00

50 lines
1.6 KiB
Ruby

# frozen_string_literal: true
RSpec.describe Jobs::NotifyMovedPosts do
it "raises an error without post_ids" do
expect { Jobs::NotifyMovedPosts.new.execute(moved_by_id: 1234) }.to raise_error(
Discourse::InvalidParameters,
)
end
it "raises an error without moved_by_id" do
expect { Jobs::NotifyMovedPosts.new.execute(post_ids: [1, 2, 3]) }.to raise_error(
Discourse::InvalidParameters,
)
end
context "with post ids" do
fab!(:p1) { Fabricate(:post) }
fab!(:p2) { Fabricate(:post, user: Fabricate(:evil_trout), topic: p1.topic) }
fab!(:p3) { Fabricate(:post, user: p1.user, topic: p1.topic) }
fab!(:admin)
let(:moved_post_notifications) do
Notification.where(notification_type: Notification.types[:moved_post])
end
it "should create two notifications" do
expect {
Jobs::NotifyMovedPosts.new.execute(post_ids: [p1.id, p2.id, p3.id], moved_by_id: admin.id)
}.to change(moved_post_notifications, :count).by(2)
end
it "notifies on the post with lowest post number" do
Jobs::NotifyMovedPosts.new.execute(post_ids: [p1.id, p3.id], moved_by_id: admin.id)
expect(moved_post_notifications.last.post_number).to eq(p1.post_number)
end
context "when moved by one of the posters" do
it "create one notifications, because the poster is the mover" do
expect {
Jobs::NotifyMovedPosts.new.execute(
post_ids: [p1.id, p2.id, p3.id],
moved_by_id: p1.user_id,
)
}.to change(moved_post_notifications, :count).by(1)
end
end
end
end