mirror of
https://github.com/discourse/discourse.git
synced 2025-01-17 01:22:45 +08:00
062e4fb4f3
When fetching DM channels, we would fetch all the user's DM channels, and limit the number of DM channels we display on the client-side using the `DIRECT_MESSAGE_CHANNELS_LIMIT`. This is obviously not scalable as users are having more and more discussions with other users. This commit ensures we always limit the number of DM channels we send to the client. It adds the `MAX_DM_CHANNEL_RESULTS` in `ChannelFetcher` and use it to limit the records returned by the server. This value should always be lower than `DIRECT_MESSAGE_CHANNELS_LIMIT` on the client-side, so that when the user has more "unread DMs" they still show up on the client as they read them. While adding a spec, I also updated the spec that ensures we have a limit on public channels to use `stub_const` to temporarily lower the number of fixtures we create during the test. |
||
|---|---|---|
| .. | ||
| channel_archive_service_spec.rb | ||
| channel_fetcher_spec.rb | ||
| channel_hashtag_data_source_spec.rb | ||
| channel_membership_manager_spec.rb | ||
| core_pretty_text_spec.rb | ||
| duplicate_message_validator_spec.rb | ||
| guardian_extensions_spec.rb | ||
| message_bookmarkable_spec.rb | ||
| message_mover_spec.rb | ||
| message_processor_spec.rb | ||
| message_reactor_spec.rb | ||
| messages_exporter_spec.rb | ||
| notifier_spec.rb | ||
| onebox_handler_spec.rb | ||
| parsed_mentions_spec.rb | ||
| post_notification_handler_spec.rb | ||
| review_queue_spec.rb | ||
| slack_compatibility_spec.rb | ||
| statistics_spec.rb | ||
| transcript_service_spec.rb | ||