Blake Erickson 7d09af7eda

FIX: Prevent null-byte searches causing 500 error (#8226) ...

This fix ensures that searches that contain a null byte return a 400
error instead of causing a 500 error.

For some reason from rspec we will reach the raise statement inside
of the `rescue_from ArgumentError` block, but outside of rspec it will
not execute the raise statement and so a 500 is thrown instead of
reaching the `rescue_from Discourse::InvalidParameters` block inside of
the application controller.

This fix raises Discourse::InvalidParameters directly from the search
controller instead of relying on `PG::Connection.escape_string` to
raise the `ArgumentError`.

2019-10-22 08:44:52 -06:00

..

admin

FEATURE: Option to update category preferences of all users when site setting changed (#8180)

2019-10-15 18:41:27 +05:30

about_controller_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

application_controller_spec.rb

FEATURE: Add site setting to show more detailed 404 errors. (#8014)

2019-10-08 14:15:08 +03:00

associate_accounts_spec.rb

SECURITY: Require POST with CSRF token for OmniAuth request phase

2019-08-08 11:58:00 +01:00

badges_controller_spec.rb

DEV: Upgrade Discourse to Rails 6 (#8083)

2019-09-12 10:41:50 +10:00

categories_controller_spec.rb

SECURITY: don't reveal category details to users that do not have access

2019-08-19 12:38:28 +05:30

category_hashtags_controller_spec.rb

DEV: avoid double sign-in which can lead to flaky tests

2019-06-03 10:15:49 +10:00

clicks_controller_spec.rb

DEV: Fix failling test.

2019-05-07 11:19:13 +03:00

composer_controller_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

composer_messages_controller_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

csp_reports_controller_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

directory_items_controller_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

draft_controller_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

drafts_controller_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

email_controller_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

embed_controller_spec.rb

FEATURE: Allow embedding to ignore HTTP REFERER

2019-09-10 12:27:07 -04:00

exceptions_controller_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

export_csv_controller_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

extra_locales_controller_spec.rb

FIX: ensure extra locales are only available to staff

2019-08-20 12:38:46 +02:00

finish_installation_controller_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

forums_controller_spec.rb

FIX: Don't use DistributedCache to store redis readonly state

2019-06-25 11:20:34 +08:00

groups_controller_spec.rb

DEV: Upgrade Discourse to Rails 6 (#8083)

2019-09-12 10:41:50 +10:00

inline_onebox_controller_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

invites_controller_spec.rb

UX: update invite 'not found' message

2019-07-19 16:39:44 +05:30

list_controller_spec.rb

DEV: Upgrade Discourse to Rails 6 (#8083)

2019-09-12 10:41:50 +10:00

metadata_controller_spec.rb

DEV: Upgrade Discourse to Rails 6 (#8083)

2019-09-12 10:41:50 +10:00

notifications_controller_spec.rb

DEV: Prefer public_send over send.

2019-05-07 09:33:21 +08:00

offline_controller_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

omniauth_callbacks_controller_spec.rb

FEATURE: Use full page redirection for all external auth methods (#8092)

2019-10-08 12:10:43 +01:00

onebox_controller_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

permalinks_controller_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

post_action_users_controller_spec.rb

More prefabrication

2019-05-10 08:34:04 -04:00

post_actions_controller_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

post_readers_controller_spec.rb

Add spec description

2019-09-13 17:16:35 -03:00

posts_controller_spec.rb

FIX: first post true if user creates topic first (#8139)

2019-10-02 15:51:40 -04:00

push_notification_controller_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

reviewable_claimed_topics_controller_spec.rb

More prefabrication

2019-05-10 08:34:04 -04:00

reviewables_controller_spec.rb

FEATURE: Adds a pop up that shows a more detailed score for reviewables (#8035)

2019-09-04 09:56:25 -06:00

robots_txt_controller_spec.rb

Revert "FEATURE: add Noindex to robots.txt for disallowed routes"

2019-07-30 11:33:38 +10:00

safe_mode_controller_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

search_controller_spec.rb

FIX: Prevent null-byte searches causing 500 error (#8226)

2019-10-22 08:44:52 -06:00

session_controller_spec.rb

FEATURE: Webauthn authenticator management with 2FA login (Security Keys) (#8099)

2019-10-01 19:08:41 -07:00

similar_topics_controller_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

site_controller_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

static_controller_spec.rb

DEV: Upgrade Discourse to Rails 6 (#8083)

2019-09-12 10:41:50 +10:00

steps_controller_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

stylesheets_controller_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

svg_sprite_controller_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

tag_groups_controller_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

tags_controller_spec.rb

FIX: Topics with muted tag didn't show up when filtering by category and tag

2019-09-06 20:38:03 +02:00

theme_javascripts_controller_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

topics_controller_spec.rb

FEATURE: Add site setting to show more detailed 404 errors. (#8014)

2019-10-08 14:15:08 +03:00

uploads_controller_spec.rb

Revert "FIX: public_file_server.enabled is false in test (#8192)" (#8196)

2019-10-16 10:39:31 +11:00

user_actions_controller_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

user_api_keys_controller_spec.rb

bug: keep query params present in auth_redirect (#7923)

2019-07-23 12:16:03 -04:00

user_avatars_controller_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

user_badges_controller_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

users_controller_spec.rb

DEV: Add test for creating user with custom fields and user fields

2019-10-17 15:46:23 +01:00

users_email_controller_spec.rb

DEV: Prefabrication (test optimization) (#7414)

2019-05-07 13:12:20 +10:00

webhooks_controller_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00

wizard_controller_spec.rb

DEV: use #frozen_string_literal: true on all spec

2019-04-30 10:27:42 +10:00