github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-01-18 14:42:46 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
ba1b95c9f4
discourse/plugins/chat/spec/system
History
Martin Brennan ba1b95c9f4
FIX: Uploading multiple files to chat could cause canellations (#20605) 
When we introduced `existingUploads` as an arg to the
ChatComposerUploads component, we also introduced a bug where
if multiple uploads were being done at once, and the draft
was saved, then because of didReceiveAttrs we would cancel
the currently uploading files because the draft uploads became
the existingUploads.

To work around this, since we do want to keep this on didReceiveAttrs
for cases when the user opens a draft or edits another message,
the easiest thing to do is to just not save uploads into the chat
draft if there are still uploads in progress. That way only when
all uploads are complete do we make them a part of the draft.

There is a small risk that the user could do something to lose
their uploads in the draft, but it's a better gamble to have
that happen rather than in progress uploads to be cancelled
while the user is waiting for them to be done because of the
draft.

Also changes the uploads system spec back to the old way of
attaching multiple files since that is why it was failing.
2023-03-09 09:17:54 +01:00
..
list_channels UX: orders public channels by slug instead of title (#20188) 2023-02-07 10:36:28 +01:00
page_objects DEV: Introduces a wait_for_animation system spec helper (#20573) 2023-03-08 16:49:20 +01:00
shortcuts DEV: rework the chat-live-pane (#20519) 2023-03-03 13:09:25 +01:00
user_menu_notifications DEV: Pass messageId as a dynamic segment instead of a query param (#20013) 2023-02-01 12:39:23 -03:00
user_status DEV: attempts to move all Jobs.run_immediately! at top (#19688) 2023-01-03 11:32:27 +01:00
anonymous_spec.rb DEV: start glimmer-ification and optimisations of chat plugin (#19531) 2022-12-21 13:21:02 +01:00
archive_channel_spec.rb FIX: Improve error reporting and failure modes for channel archiving (#19791) 2023-01-12 10:04:46 +10:00
bookmark_message_spec.rb PERF: applies optimisations on chat-live pane (#20532) 2023-03-06 16:42:11 +01:00
browse_page_spec.rb FIX: correctly uses request_uri to generate load_more_url (#19680) 2023-01-03 00:19:13 +01:00
channel_about_page_spec.rb FEATURE: Allow editing channel slug (#19948) 2023-01-30 13:18:34 +10:00
channel_info_pages_spec.rb DEV: /channel -> /c chat route rename (#19782) 2023-01-27 09:58:12 -03:00
channel_members_page_spec.rb DEV: /channel -> /c chat route rename (#19782) 2023-01-27 09:58:12 -03:00
channel_message_selection_spec.rb FIX: Regression with chat shift+select messages (#20305) 2023-02-15 08:49:56 +01:00
channel_selector_modal_spec.rb DEV: Improve performance of system test sign_in helper (#19579) 2022-12-22 16:03:27 +00:00
channel_settings_page_spec.rb DEV: /channel -> /c chat route rename (#19782) 2023-01-27 09:58:12 -03:00
chat_channel_spec.rb FIX: correctly syncs current user message in multiple sessions (#20584) 2023-03-08 17:28:39 +01:00
chat_composer_spec.rb FIX: correctly filters input with pre-filled value (#20154) 2023-02-02 23:49:36 +01:00
closed_channel_spec.rb REFACTOR: Fix pluralized strings in chat plugin (#20357) 2023-02-20 10:31:02 +01:00
create_channel_spec.rb DEV: rework the chat-live-pane (#20519) 2023-03-03 13:09:25 +01:00
deleted_channel_spec.rb DEV: start glimmer-ification and optimisations of chat plugin (#19531) 2022-12-21 13:21:02 +01:00
deleted_message_spec.rb PERF: applies optimisations on chat-live pane (#20532) 2023-03-06 16:42:11 +01:00
draft_message_spec.rb FIX: do not show infinite loading state on draft with new users (#20582) 2023-03-08 15:21:20 +01:00
drawer_spec.rb DEV: rework the chat-live-pane (#20519) 2023-03-03 13:09:25 +01:00
edited_message_spec.rb FIX: re-enables using_session tests (#19564) 2022-12-22 14:40:36 +01:00
flag_message_spec.rb DEV: rework the chat-live-pane (#20519) 2023-03-03 13:09:25 +01:00
hashtag_autocomplete_spec.rb PERF: applies optimisations on chat-live pane (#20532) 2023-03-06 16:42:11 +01:00
jit_messages_spec.rb REFACTOR: Fix pluralized strings in chat plugin (#20357) 2023-02-20 10:31:02 +01:00
mention_warnings_spec.rb PERF: applies optimisations on chat-live pane (#20532) 2023-03-06 16:42:11 +01:00
message_notifications_mobile_spec.rb DEV: attempts to move all Jobs.run_immediately! at top (#19688) 2023-01-03 11:32:27 +01:00
message_notifications_with_sidebar_spec.rb DEV: rework the chat-live-pane (#20519) 2023-03-03 13:09:25 +01:00
message_user_info.rb DEV: rework the chat-live-pane (#20519) 2023-03-03 13:09:25 +01:00
move_message_to_channel_spec.rb DEV: start glimmer-ification and optimisations of chat plugin (#19531) 2022-12-21 13:21:02 +01:00
navigating_to_message_spec.rb DEV: rework the chat-live-pane (#20519) 2023-03-03 13:09:25 +01:00
navigation_spec.rb DEV: /channel -> /c chat route rename (#19782) 2023-01-27 09:58:12 -03:00
network_reconciliation_spec.rb FIX: ensures recovering network doesn't create unread mentions (#19597) 2022-12-23 07:38:45 +01:00
react_to_message_spec.rb FIX: prevents duplicate reactions (#20527) 2023-03-03 20:29:24 +01:00
read_only_spec.rb REFACTOR: Fix pluralized strings in chat plugin (#20357) 2023-02-20 10:31:02 +01:00
sidebar_navigation_menu_spec.rb DEV: /channel -> /c chat route rename (#19782) 2023-01-27 09:58:12 -03:00
sidebars_spec.rb DEV: start glimmer-ification and optimisations of chat plugin (#19531) 2022-12-21 13:21:02 +01:00
silenced_user_spec.rb DEV: start glimmer-ification and optimisations of chat plugin (#19531) 2022-12-21 13:21:02 +01:00
single_thread_spec.rb DEV: Introduces a wait_for_animation system spec helper (#20573) 2023-03-08 16:49:20 +01:00
sticky_date_spec.rb DEV: rework the chat-live-pane (#20519) 2023-03-03 13:09:25 +01:00
transcript_spec.rb DEV: Introduces a wait_for_animation system spec helper (#20573) 2023-03-08 16:49:20 +01:00
unfollow_dm_channel_spec.rb DEV: Improve performance of system test sign_in helper (#19579) 2022-12-22 16:03:27 +00:00
uploads_spec.rb FIX: Uploading multiple files to chat could cause canellations (#20605) 2023-03-09 09:17:54 +01:00
user_card_spec.rb DEV: start glimmer-ification and optimisations of chat plugin (#19531) 2022-12-21 13:21:02 +01:00
user_chat_preferences_spec.rb DEV: rework the chat-live-pane (#20519) 2023-03-03 13:09:25 +01:00
visit_channel_spec.rb DEV: Pass messageId as a dynamic segment instead of a query param (#20013) 2023-02-01 12:39:23 -03:00