mirror of
https://github.com/discourse/discourse.git
synced 2025-01-18 09:32:48 +08:00
ea548292bc
This commit is a major overhaul of how chat message actions work, to make it so they are reusable between the main chat channel and the chat thread panel, as well as many improvements and fixes for the thread panel. There are now several new classes and concepts: * ChatMessageInteractor - This is initialized from the ChatMessage, ChatMessageActionsDesktop, and ChatMessageActionsMobile components. This handles permissions about what actions can be done for each message based on the context (thread or channel), handles the actions themselves (e.g. copyLink, delete, edit), and interacts with the pane of the current context to modify the UI * ChatChannelThreadPane and ChatChannelPane services - This represents the UI context which contains the messages, and are mostly used for state management for things like message selection. * ChatChannelThreadComposer and ChatChannelComposer - This handles interaction between the pane, the message actions, and the composer, dealing with reply and edit message state. * Scrolling logic for the messages has now been moved to a helper so it can be shared between the main channel pane and the thread pane * Various improvements with the emoji picker on both mobile and desktop. The DOM node of each component is now located outside of the message which prevents a large range of issues. The thread panel now also works in the chat drawer, and the thread messages have less actions than the main panel, since some do not make sense there (e.g. moving messages to a different channel). The thread panel title, excerpt, and message sender have also been removed for now to save space. This gives us a solid base to keep expanding on and fixing up threads. Subsequent PRs will make the thread MessageBus subscriptions work and disable echo mode for the initial release of threads. Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com> |
||
|---|---|---|
| .. | ||
| list_channels | ||
| page_objects | ||
| shortcuts | ||
| user_menu_notifications | ||
| user_status | ||
| anonymous_spec.rb | ||
| archive_channel_spec.rb | ||
| bookmark_message_spec.rb | ||
| browse_page_spec.rb | ||
| channel_about_page_spec.rb | ||
| channel_info_pages_spec.rb | ||
| channel_members_page_spec.rb | ||
| channel_message_selection_spec.rb | ||
| channel_message_upload_spec.rb | ||
| channel_selector_modal_spec.rb | ||
| channel_settings_page_spec.rb | ||
| chat_channel_spec.rb | ||
| chat_composer_spec.rb | ||
| closed_channel_spec.rb | ||
| create_channel_spec.rb | ||
| deleted_channel_spec.rb | ||
| deleted_message_spec.rb | ||
| draft_message_spec.rb | ||
| drawer_spec.rb | ||
| edited_message_spec.rb | ||
| flag_message_spec.rb | ||
| hashtag_autocomplete_spec.rb | ||
| jit_messages_spec.rb | ||
| kick_user_from_channel_spec.rb | ||
| mention_warnings_spec.rb | ||
| message_notifications_mobile_spec.rb | ||
| message_notifications_with_sidebar_spec.rb | ||
| message_user_info.rb | ||
| move_message_to_channel_spec.rb | ||
| navigating_to_message_spec.rb | ||
| navigation_spec.rb | ||
| network_reconciliation_spec.rb | ||
| react_to_message_spec.rb | ||
| read_only_spec.rb | ||
| sidebar_navigation_menu_spec.rb | ||
| sidebars_spec.rb | ||
| silenced_user_spec.rb | ||
| single_thread_spec.rb | ||
| sticky_date_spec.rb | ||
| transcript_spec.rb | ||
| unfollow_dm_channel_spec.rb | ||
| update_last_read.rb | ||
| uploads_spec.rb | ||
| user_card_spec.rb | ||
| user_chat_preferences_spec.rb | ||
| user_presence.rb | ||
| visit_channel_spec.rb | ||