github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-03-29 09:25:37 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
discourse/lib
History
Sam Saffron f0a0252526 FIX: broken onebox images due to url normalization bugs 
normalized_encode in addressable has a number of issues, including https://github.com/sporkmonger/addressable/issues/472

To temporaily work around those issues for the majority of cases, we try parsing with `::URI`. If that fails (e.g. due to non-ascii characters) then we will fall back to addressable.

Hopefully we can simplify this back to `Addressable::URI.normalized_encode` in the future.

This commit also adds support for unicode domain names and emoji domain names with escape_uri.

This removes an unneeded hack checking for pre-signed urls, which are now handled by the general case due to starting off valid and only being minimally normalized. Previous test case continues to pass.

UrlHelper.s3_presigned_url? which was somewhat wide was removed.
2022-08-09 11:55:25 +01:00
..
action_dispatch/session
DEV: Upgrade to Rails 7
2022-04-28 11:51:03 +02:00
auth
FIX: Logout could fail due to cached user (#17325)
2022-07-04 17:01:19 +02:00
autospec
DEV: Remove qunit autorunner (#17430)
2022-07-11 22:29:33 +02:00
backup_restore
FEATURE: Create upload_references table (#16146)
2022-06-09 09:24:30 +10:00
common_passwords
DEV: Upgrade to Rails 7
2022-04-28 11:51:03 +02:00
compression
…
content_security_policy
DEV: Use performance timings to as a baseline for the splash take 2 (#17284)
2022-06-30 21:22:00 +08:00
demon
DEV: Route Sidekiq logs to Rails logger (#15817)
2022-02-04 16:28:20 +00:00
discourse_dev
DEV: Populate first and last seen at timestamps. (#17643)
2022-07-25 11:54:43 -03:00
email
FEATURE: Log the SMTP response in EmailLog (#17056)
2022-06-15 10:28:30 +10:00
email_controller_helper
FEATURE: Custom unsubscribe options (#17090)
2022-06-21 15:49:47 -03:00
emoji
FEATURE: Add missing emojis (#15582)
2022-01-14 17:51:13 -03:00
faker
DEV: Fix methods removed in Ruby 3.2 (#15459)
2022-01-05 18:45:08 +01:00
file_store
FEATURE: Make S3 presigned GET URL expiry configurable (#16912)
2022-05-26 09:53:01 +10:00
freedom_patches
DEV: Remove vendored babel and update config for plugins/themes (#17832)
2022-08-09 11:53:24 +01:00
generators/rails
DEV: removes plugin generator (#14101)
2021-08-20 11:29:06 +02:00
guardian
FIX: Support for group everyone in tag setting (#17669)
2022-07-27 15:44:41 +03:00
i18n
DEV: Upgrade to Rails 7
2022-04-28 11:51:03 +02:00
imap
FEATURE: Introduce site setting to allow for non staff pm tagging (#16671)
2022-05-10 10:02:28 -05:00
import
…
import_export
FEATURE: include user custom fields in base exporter (#14690)
2021-10-22 10:02:56 -07:00
javascripts
DEV: Extensively use startsWith() (#17540)
2022-07-17 20:16:39 +02:00
middleware
DEV: Upgrade to Rails 7
2022-04-28 11:51:03 +02:00
migration
DEV: Upgrade to Rails 7
2022-04-28 11:51:03 +02:00
onebox
FIX: Use URI#merge to merge base and relative URLs (#17454)
2022-07-18 14:17:54 +03:00
plugin
Add discourse-question-answer to official plugins (#17807)
2022-08-05 14:31:58 +05:30
pretty_text
DEV: Extensively use includes() (#17541)
2022-07-17 20:48:36 +02:00
rate_limiter
FEATURE: Apply rate limits per user instead of IP for trusted users (#14706)
2021-11-17 23:27:30 +03:00
reviewable
DEV: Upgrade to Rails 7
2022-04-28 11:51:03 +02:00
scheduler
…
search
FIX: Limits for PM and group header search (#16887)
2022-05-24 11:31:24 -04:00
second_factor
FEATURE: Add 2FA support to the Discourse Connect Provider protocol (#16386)
2022-04-13 15:04:09 +03:00
seed_data
FIX: Support Ruby 3 keyword arguments
2021-10-05 11:25:00 -04:00
sidekiq
…
site_settings
FIX: min/max username length limits weren't validated (#17382)
2022-07-08 12:00:47 -03:00
stylesheet
DEV: Preload CSS in the <head> (#17322)
2022-07-05 00:23:09 +08:00
tasks
Revert "DEV: Improve multisite db scripts in dev (#17337)" (#17801)
2022-08-04 16:15:06 -05:00
theme_store
DEV: Upgrade to Rails 7
2022-04-28 11:51:03 +02:00
topic_query
FEATURE: whispers available for groups (#17170)
2022-06-30 10:18:12 +10:00
turbo_tests
FIX: Make thumbnail tests start with a clean slate (#15216)
2021-12-07 13:07:45 -06:00
validators
FEATURE: Add support for case-sensitive Watched Words (#17445)
2022-08-02 10:06:03 +02:00
webauthn
…
wizard
FIX: do not overwrite top_menu site setting in wizard styling step (#17743)
2022-08-02 19:29:34 +05:30
admin_confirmation.rb
FEATURE: Centralized 2FA page (#15377)
2022-02-17 12:12:59 +03:00
admin_constraint.rb
Revert "DEV: Add context in AdminConstraint (#15838)" (#15845)
2022-02-07 21:05:19 +03:00
admin_user_index_query.rb
FIX: Add email to admin user list when show_emails is enabled (#16636)
2022-05-04 14:07:22 -03:00
age_words.rb
…
archetype.rb
…
auth.rb
FEATURE: Experimental support for group membership via google auth (#14835)
2021-12-09 12:30:27 +00:00
backup_restore.rb
FIX: Handle enum types during database restore (#16624)
2022-05-04 08:40:34 +10:00
badge_posts_view_manager.rb
DEV: stop freezing frozen strings
2020-04-30 16:48:53 +10:00
badge_queries.rb
FIX: Don't grant sharing badges to users who don't exist (#13851)
2021-07-27 16:32:59 +10:00
base62.rb
DEV: Correct typos and spelling mistakes (#12812)
2021-05-21 11:43:47 +10:00
bookmark_manager.rb
DEV: Add save_user_preferences option to BookmarkManager (#16894)
2022-05-24 11:13:21 +10:00
bookmark_query.rb
DEV: Add bookmarks tab to the new user menu (#17814)
2022-08-08 17:24:04 +03:00
bookmark_reminder_notification_handler.rb
FEATURE: Promote polymorphic bookmarks to default and migrate (#16729)
2022-05-23 10:07:15 +10:00
browser_detection.rb
…
cache.rb
DEV: Fix rubocop issues (#14715)
2021-10-27 11:39:28 +03:00
canonical_url.rb
FEATURE: Send a 'noindex' header in non-canonical responses (#15026)
2021-11-25 16:58:39 -03:00
category_badge.rb
…
chrome_installed_checker.rb
DEV: Add chromium to ChromeInstalledChecker (#16224)
2022-03-19 11:00:06 +01:00
comment_migration.rb
…
common_passwords.rb
DEV: Upgrade to Rails 7
2022-04-28 11:51:03 +02:00
composer_messages_finder.rb
FEATURE: Make allow_uploaded_avatars accept TL (#14091)
2021-08-24 10:46:28 +03:00
configurable_urls.rb
Replace base_uri with base_path (#10879)
2020-10-09 12:51:24 +01:00
content_buffer.rb
…
content_security_policy.rb
PERF: Eager load Theme associations in Stylesheet Manager.
2021-06-21 11:06:58 +08:00
cooked_post_processor.rb
FEATURE: Allow hotlinked media to be blocked (#16940)
2022-06-07 15:23:04 +01:00
cooked_processor_mixin.rb
FEATURE: Allow hotlinked media to be blocked (#16940)
2022-06-07 15:23:04 +01:00
crawler_detection.rb
FEATURE: Implement browser update in crawler view (#12448)
2021-03-22 19:41:42 +02:00
csrf_token_verifier.rb
…
current_user.rb
…
custom_renderer.rb
…
db_helper.rb
DEV: Upgrade to Rails 7
2022-04-28 11:51:03 +02:00
directory_helper.rb
…
discourse_connect_base.rb
FEATURE: allow for overlapping DiscourseConnect secrets per domain (#16915)
2022-05-31 15:24:04 +10:00
discourse_connect_provider.rb
FEATURE: allow for overlapping DiscourseConnect secrets per domain (#16915)
2022-05-31 15:24:04 +10:00
discourse_dev.rb
DEV: move discourse_dev gem to the core. (#13360)
2021-06-14 20:34:44 +05:30
discourse_diff.rb
Escape values of HTML attributes
2021-08-10 10:25:15 -04:00
discourse_event.rb
DEV: Remove site_setting_saved event (#15164)
2021-12-02 09:33:03 -06:00
discourse_hub.rb
…
discourse_ip_info.rb
DEV: Typo. (#16092)
2022-03-03 09:24:58 +08:00
discourse_js_processor.rb
DEV: Remove vendored babel and update config for plugins/themes (#17832)
2022-08-09 11:53:24 +01:00
discourse_logstash_logger.rb
…
discourse_plugin_registry.rb
FEATURE: Custom unsubscribe options (#17090)
2022-06-21 15:49:47 -03:00
discourse_redis.rb
DEV: Readonly Redis support for DiscourseRedis#multi/pipelined (#16744)
2022-05-13 16:18:13 +08:00
discourse_sourcemapping_url_processor.rb
DEV: Fix production sourcemaps with Ember CLI (#16707)
2022-05-11 10:23:32 +01:00
discourse_tagging.rb
FEATURE: Show prompt for required tag groups (#16458)
2022-04-21 13:13:52 +01:00
discourse_updates.rb
FIX: Regression introduced in #14715 (#14842)
2021-11-09 17:20:09 +11:00
discourse.rb
FIX: properly log all internal job failures (#17805)
2022-08-05 17:40:22 +10:00
disk_space.rb
…
distributed_cache.rb
FIX: Handle nil values in DistributedCache#defer_get_set (#15978)
2022-02-17 14:52:14 +00:00
distributed_memoizer.rb
DEV: Make DistributedMemoizer use DistributedMutex (#16229)
2022-04-05 19:29:58 +02:00
distributed_mutex.rb
DEV: Implement distributed mutex in lua (#16228)
2022-07-11 14:16:37 +02:00
edit_rate_limiter.rb
FEATURE: Increase daily edit limits proportionally to trust level (#13090)
2021-05-19 13:57:21 +04:00
email_backup_token.rb
…
email_cook.rb
PERF: Avoid lookbehinds when replacing links in imported emails (#11931)
2021-02-02 17:34:00 +01:00
email_updater.rb
DEV: Update :critical_user_email calls to use strings (#15827)
2022-02-04 23:43:53 +00:00
email.rb
DEV: pull email address validation out to a new EmailAddressValidator
2022-02-17 21:49:22 -05:00
ember_cli.rb
DEV: Pass static scripts through Ember CLI (#17373)
2022-07-08 10:13:46 +01:00
encodings.rb
…
enum_site_setting.rb
…
enum.rb
…
excerpt_parser.rb
DEV: Remove dead code
2021-05-31 10:22:50 +08:00
external_upload_helpers.rb
FIX: Use hidden site setting for batch presign rate limit (#16692)
2022-05-10 11:14:26 +10:00
feed_element_installer.rb
…
feed_item_accessor.rb
FIX: Select best link from Atom feed (#15663)
2022-01-21 17:54:18 +02:00
file_helper.rb
DEV: Stop logging error response body in FileHelper (#17120)
2022-06-17 11:50:30 +01:00
filter_best_posts.rb
…
final_destination.rb
FIX: Don’t raise an error on onebox timeouts
2022-07-25 10:41:46 +02:00
flag_query.rb
DEV: Remove deprecated methods (#14885)
2021-11-11 12:21:25 -06:00
flag_settings.rb
DEV: Compatibility with TruffleRuby (#16864)
2022-05-19 21:56:55 +02:00
gaps.rb
…
global_path.rb
FEATURE: Centralized 2FA page (#15377)
2022-02-17 12:12:59 +03:00
group_email_credentials_check.rb
FEATURE: Scheduled group email credential problem check (#15396)
2022-01-04 10:14:33 +10:00
guardian.rb
FIX: don't memoize site setting in guardian (#17788)
2022-08-04 10:07:12 +10:00
has_errors.rb
…
highlight_js.rb
DEV: Upgrade to Rails 7
2022-04-28 11:51:03 +02:00
hijack.rb
DEV: Add more debugging context to onebox generation
2020-10-22 12:50:22 +08:00
homepage_constraint.rb
FEATURE: Apply rate limits per user instead of IP for trusted users (#14706)
2021-11-17 23:27:30 +03:00
html_prettify.rb
DEV: stop freezing frozen strings
2020-04-30 16:48:53 +10:00
html_to_markdown.rb
DEV: Upgrade to Rails 7
2022-04-28 11:51:03 +02:00
http_language_parser.rb
FIX: Include resolved locale in anonymous cache key (#10289)
2020-07-22 18:00:07 +01:00
image_sizer.rb
…
import_export.rb
FEATURE: Rake task to export groups (#9450)
2020-04-17 14:59:54 -07:00
inline_oneboxer.rb
FIX: InlineOneboxer watched word censor error (#16921)
2022-05-26 14:01:44 +10:00
js_locale_helper.rb
FIX: Extra-locale merging didn't account for fallbacks (#17128)
2022-06-17 19:34:08 +02:00
json_error.rb
…
letter_avatar.rb
DEV: Fix methods removed in Ruby 3.2 (#15459)
2022-01-05 18:45:08 +01:00
markdown_linker.rb
…
mem_info.rb
…
message_bus_diags.rb
…
method_profiler.rb
DEV: Add output_sql_to_stderr! to MethodProfiler (#12445)
2021-03-19 17:48:30 +10:00
mini_sql_multisite_connection.rb
DEV: Use MiniSql ActiveRecordPostgres adapter (#15767)
2022-02-03 10:00:28 +00:00
mobile_detection.rb
FIX: include crawler content on old mobile browsers (#16387)
2022-04-06 11:09:12 +01:00
new_post_manager.rb
SECURITY: Escape watched word in error message (#14434)
2021-09-24 11:55:15 +03:00
new_post_result.rb
DEV: Let's always give a drop_from param to deprecate (#14901)
2021-11-12 08:52:59 -06:00
notification_levels.rb
DEV: Add normal as an alias for regular in NotificationLevels.topic_levels (#17466)
2022-07-13 06:37:38 +03:00
onebox.rb
DEV: Don’t patch Sanitize::Config
2022-04-06 17:10:51 +02:00
oneboxer.rb
FIX: InlineOneboxer watched word censor error (#16921)
2022-05-26 14:01:44 +10:00
onpdiff.rb
…
pbkdf2.rb
Use Xorcist.xor! instead of refinements since Ruby 3.2+ removes Refinment-include (#15694)
2022-02-03 16:19:30 +11:00
permalink_constraint.rb
…
pinned_check.rb
…
plain_text_to_markdown.rb
DEV: stop freezing frozen strings
2020-04-30 16:48:53 +10:00
plugin_gem.rb
DEV: Don't load bundler when installing plugin gem. (#16117)
2022-03-07 13:20:43 +08:00
plugin.rb
DEV: Upgrade to Rails 7
2022-04-28 11:51:03 +02:00
post_action_creator.rb
DEV: Remove PostAction/UserAction bookmark refs (#16681)
2022-05-10 10:42:18 +10:00
post_action_destroyer.rb
FIX: Background like count update didn't account for own user actions (#16688)
2022-05-09 17:23:39 -03:00
post_action_result.rb
DEV: Upgrade to Rails 7
2022-04-28 11:51:03 +02:00
post_creator.rb
FIX: Change UserCommScreener to use user_ids (#17489)
2022-07-14 15:23:09 +10:00
post_destroyer.rb
UX: Update topics stats automatically (#17135)
2022-06-27 18:21:05 -03:00
post_jobs_enqueuer.rb
FIX: Do not send emails to mailing_list_mode subscribers for PMs (#14159)
2021-08-26 15:16:35 +10:00
post_locker.rb
…
post_merger.rb
FEATURE: TL4 & category moderators can merge posts (#12843)
2021-04-27 18:24:27 +02:00
post_revisor.rb
FIX: Skip job if tag edit notification is disabled (#17508)
2022-07-15 15:36:27 +03:00
presence_channel.rb
DEV: Fix random typos (#16066)
2022-02-28 10:20:58 +08:00
pretty_text.rb
FEATURE: Add support for case-sensitive Watched Words (#17445)
2022-08-02 10:06:03 +02:00
promotion.rb
FIX: check if BasicBadge is enabled for TL1 welcome message (#13983)
2021-08-11 08:39:25 +10:00
quote_comparer.rb
FIX: handle quote rendering for external Discourse instance (#16722)
2022-05-12 10:07:43 -05:00
rake_helpers.rb
…
rate_limiter.rb
DEV: Consolidate Redis evalsha logic into DiscourseRedis::EvalHelper (#15957)
2022-02-15 16:06:12 +00:00
read_only_mixin.rb
DEV: New readonly mode. Only applies to non-staff (#16243)
2022-05-17 13:06:08 -05:00
redis_snapshot.rb
FIX: add support for pipelined and multi redis commands (#16682)
2022-05-10 08:19:02 +10:00
require_dependency_backward_compatibility.rb
DEV: Upgrade to Rails 7
2022-04-28 11:51:03 +02:00
retrieve_title.rb
DEV: Supress logs when RetrieveTitle.crawl fails with Net::ReadTimeout errors (#16971)
2022-06-09 16:30:22 -03:00
route_format.rb
…
route_matcher.rb
FIX: Incorrect currentUser could be cached for requests with API key (#17279)
2022-07-01 10:18:24 +02:00
rtl.rb
…
s3_cors_rulesets.rb
DEV: Upgrade to Rails 7
2022-04-28 11:51:03 +02:00
s3_helper.rb
FIX: don't raise an error if file not found in S3. (#17841)
2022-08-09 15:16:35 +05:30
s3_inventory.rb
DEV: Fix methods removed in Ruby 3.2 (#15459)
2022-01-05 18:45:08 +01:00
score_calculator.rb
…
screening_model.rb
…
search.rb
FEATURE: Create upload_references table (#16146)
2022-06-09 09:24:30 +10:00
secure_session.rb
…
shrink_uploaded_image.rb
FIX: Should be UploadReference instead of UploadReferences (#17361)
2022-07-06 11:40:54 -07:00
sidekiq_logster_reporter.rb
DEV: Upgrade Sidekiq to 6.5 (#17142)
2022-06-21 09:23:36 +08:00
site_icon_manager.rb
PERF: Defer setting of distributed cache in more spots.
2021-06-04 09:13:18 +08:00
site_setting_extension.rb
FIX: Resetting selectable avatars was failing (#16302)
2022-03-28 14:15:28 -04:00
slug.rb
FIX: Make category slugs lowercase (#11277)
2021-01-12 17:28:33 +02:00
socket_server.rb
…
spam_handler.rb
FIX: use allowlist and blocklist terminology (#10209)
2020-07-27 10:23:54 +10:00
staff_constraint.rb
FEATURE: Apply rate limits per user instead of IP for trusted users (#14706)
2021-11-17 23:27:30 +03:00
staff_message_format.rb
…
suggested_topics_builder.rb
…
svg_sprite.rb
FEATURE: Replace hamburger dropdown with Sidebar when undock (#17600)
2022-07-22 13:06:47 +08:00
system_message.rb
DEV: Add event for plugins to customize system messages (#16953)
2022-05-30 14:01:21 +01:00
temporary_db.rb
Revert "DEV: Improve multisite db scripts in dev (#17337)" (#17801)
2022-08-04 16:15:06 -05:00
temporary_redis.rb
DEV: Introduce TemporaryRedis and unset DISCOURSE_* env vars in the themes:isolated_test rake task (#13401)
2021-06-23 07:38:43 +03:00
text_cleaner.rb
FEATURE: Correctly convert topic title to uppercase and lowercase for Turkish default locale (#13115)
2021-05-24 18:13:30 +10:00
text_sentinel.rb
DEV: Correct typos and spelling mistakes (#12812)
2021-05-21 11:43:47 +10:00
theme_javascript_compiler.rb
DEV: Patch Ruby Ember template compiler to work with recent ember
2022-07-19 10:00:59 +01:00
theme_modifier_helper.rb
Code review comments.
2021-06-21 11:06:58 +08:00
theme_settings_manager.rb
FEATURE: Allow theme settings to request refresh (#15037)
2021-11-22 13:16:56 +01:00
theme_settings_parser.rb
FEATURE: Allow theme settings to request refresh (#15037)
2021-11-22 13:16:56 +01:00
theme_translation_manager.rb
…
theme_translation_parser.rb
…
timeline_lookup.rb
FIX: ensures timeline_lookup includes last tuple (#11829)
2021-01-25 11:30:59 +01:00
tiny_japanese_segmenter.rb
FEATURE: Split up text segmentation for Chinese and Japanese.
2022-02-07 09:21:14 +08:00
topic_creator.rb
FEATURE: Add support for case-sensitive Watched Words (#17445)
2022-08-02 10:06:03 +02:00
topic_list_responder.rb
DEV: Refactor draft attributes for CategoryList and TopicList.
2020-07-24 10:11:30 +08:00
topic_publisher.rb
FIX: Notify tag watchers when publishing topic (#17576)
2022-07-20 19:07:18 +03:00
topic_query_params.rb
FIX: Build correct topic list filter (#11473)
2020-12-11 14:20:48 +02:00
topic_query.rb
FIX: Ensure all public topic-query options can be used via Ember (#17706)
2022-07-29 09:03:53 +10:00
topic_retriever.rb
FEATURE: Fallback to system users when creating new TopicEmbed (#12386)
2021-03-15 11:58:53 -03:00
topic_subtype.rb
…
topic_upload_security_manager.rb
FEATURE: Create upload_references table (#16146)
2022-06-09 09:24:30 +10:00
topic_view.rb
FEATURE: show status on post streams (#17813)
2022-08-08 17:35:26 +04:00
topics_bulk_action.rb
FEATURE: whispers available for groups (#17170)
2022-06-30 10:18:12 +10:00
trust_level.rb
FIX: Don't store translated trust level names in anonymous cache (#13224)
2021-06-01 22:11:48 +02:00
turbo_tests.rb
FIX: Make thumbnail tests start with a clean slate (#15216)
2021-12-07 13:07:45 -06:00
twitter_api.rb
FIX: twitter onebox keeps whitespace for expanded links (#17055)
2022-06-10 01:20:26 -04:00
unicorn_logstash_patch.rb
DEV: Fix lint.
2020-07-21 15:55:03 +08:00
unread.rb
FEATURE: whispers available for groups (#17170)
2022-06-30 10:18:12 +10:00
upload_creator.rb
FIX: Didn't delete upload stub when a new upload is created
2022-06-28 21:27:52 +02:00
upload_fixer.rb
…
upload_markdown.rb
DEV: Expand UploadMarkdown generation capabilities (#15930)
2022-02-14 15:48:27 +10:00
upload_recovery.rb
FIX: Support Ruby 3 keyword arguments
2021-10-05 11:25:00 -04:00
upload_security.rb
PERF: Speed up secure media and ACL sync rake tasks (#16849)
2022-05-23 13:14:11 +10:00
url_helper.rb
FIX: broken onebox images due to url normalization bugs
2022-08-09 11:55:25 +01:00
user_comm_screener.rb
FIX: Handle actor not having preferences in UserCommScreener (#17790)
2022-08-04 10:16:54 +10:00
user_lookup.rb
REVERT "FIX: do not show private group flair on user avatars" (#13991)
2021-08-10 17:25:11 +05:30
user_name_suggester.rb
FEATURE: when suggesting usernames skip input that consist entirely of disallowed characters (#15368)
2021-12-21 21:13:05 +04:00
vary_header.rb
FIX: Include the Vary:Accept header on all Accept-based responses (#14647)
2021-10-25 12:53:50 +01:00
version.rb
Version bump to v2.9.0.beta8 (#17697)
2022-07-27 17:11:58 -03:00
webauthn.rb
FEATURE: RS512, RS384 and RS256 COSE algorithms (#15804)
2022-02-08 14:07:47 +02:00
wizard.rb
…