discourse/spec
Martin Brennan f63da1c146
FIX: Confirm new email not sent for staff if email disabled with "non-staff" option (#10794)
See https://meta.discourse.org/t/email-address-change-confirmation-email-not-sent-but-every-other-notification-emails-are/165358

In short: with disable emails set to non-staff, email address change confirmation emails (those sent to the new address) are not sent for staff or admin members.

This was happening because we were looking up the staff user with the to_address of the email, but the to address was the new email address because we are sending a confirm email change email, and thus the user could not be found. We didn't need to do this anyway because we are passing the user into the Email::Sender class anyway.
2020-10-08 13:52:17 +10:00
..
components FIX: Confirm new email not sent for staff if email disabled with "non-staff" option (#10794) 2020-10-08 13:52:17 +10:00
fabricators DEV: Move UserApiKey scopes to dedicated table (#10704) 2020-09-29 10:57:48 +01:00
fixtures SECURITY: return error on oversized images 2020-09-14 10:45:11 +10:00
helpers DEV: Clean up S3 specs, stubs, and helpers 2020-09-28 12:02:25 +01:00
import_export FEATURE: Rake task to export groups (#9450) 2020-04-17 14:59:54 -07:00
initializers FIX: We need to skip users with associated reviewables when auto-approving (#9080) 2020-03-02 14:33:52 -05:00
integration FIX: Pluralized translation overrides didn't work for en_US 2020-08-29 00:11:46 +02:00
integrity DEV: Check English locale for errors in CI 2020-06-03 21:54:58 +02:00
jobs PERF: Do not enqueue digest emails when attempted recently (#10849) 2020-10-07 15:30:38 +01:00
lib DEV: Recover missing files of existing uploads (#10757) 2020-10-01 14:54:45 +02:00
mailers FIX: When admin changes an email for the user the user must confirm the change (#10830) 2020-10-07 13:02:24 +10:00
models Embedded topics are now unlisted by default 2020-10-05 12:09:20 -04:00
multisite DEV: Clean up S3 specs, stubs, and helpers 2020-09-28 12:02:25 +01:00
requests FIX - downcase strings consistently (#10861) 2020-10-08 11:28:07 +11:00
script/import_scripts FIX: improve Vanilla importing (#10478) 2020-08-24 16:19:57 -04:00
serializers DEV: Clean up S3 specs, stubs, and helpers 2020-09-28 12:02:25 +01:00
services PERF: avoid lookbehinds when indexing search (#10862) 2020-10-08 11:40:13 +11:00
support FIX: move hp request from /users to /token (#10795) 2020-10-02 09:01:40 +10:00
tasks DEV: Clean up S3 specs, stubs, and helpers 2020-09-28 12:02:25 +01:00
views/omniauth_callbacks FEATURE: Use full page redirection for all external auth methods (#8092) 2019-10-08 12:10:43 +01:00
rails_helper.rb DEV: Clean up S3 specs, stubs, and helpers 2020-09-28 12:02:25 +01:00
swagger_helper.rb DEV: Add rswag to aid in api documention (#9546) 2020-04-27 16:40:07 -06:00