github-mirror/fish-shell
github-mirror/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2025-02-21 11:27:56 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fixup! Reintroduce trivially copyable maybe_t impl

Browse Source 
`git revert --no-commit` leaving the repo in a "middle of revert" state
tripped me up and my changes weren't included in the commit. Mea culpa.
This commit is contained in:
Mahmoud Al-Qudsi 2022-10-29 11:38:37 -05:00
parent 4f46abec9d
commit 8750f9ccb7
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/maybe.h
View File

@ -147,7 +147,13 @@ inline constexpr none_t none() { return none_t::none; }
// This is a value-type class that stores a value of T in aligned storage.
template <typename T>
class maybe_t : private maybe_detail::conditionally_copyable_t<T> {
#if __GNUG__ && __GNUC__ < 5
// Making maybe_t trivially copyable results in some heisenbugs if compiled under gcc 8.3.0
// targeting 32-bit armhf platforms (Debian 10 armhf toolchain). It's confirmed not to happen if
// using clang 7 (under Debian 10 armhf) or gcc 10 (under Debian 11 armhf) so we're also
// excluding gcc 9 unless/until 32-bit armhf builds under GCC 9 are observed to pass all tests
// with this version check lowered. As this is only an optimization, just disable it across the
// board rather than only for armhf targets out of an abundance of caution.
#if __GNUG__ && __GNUC__ < 10
using maybe_impl_t = maybe_detail::maybe_impl_not_trivially_copyable_t<T>;
#else
using maybe_impl_t =