mirror of
https://github.com/fish-shell/fish-shell.git
synced 2025-02-22 10:18:56 +08:00

* Since we already have an allocation of length wstr.len(), it's probably better to allocate the result (which is strictly less than or equal to the input length) up-front rather than risk thrashing the Vec allocation, * There's no need to compare c2 against '\0' since that will just cause to_digit(16) to return None anyway, * Our convert_hex() specialization of to_digit(16) that only checks capital letters A-F without also checking lowercase a-f isn't significantly faster than just use to_digit(16), and we already assert that the input *wasn't* a lowercase a-f before making the call, so there's no point in using a special function to handle that.