From 8642e94d90460650bbd35ab6eccced0d22050797 Mon Sep 17 00:00:00 2001 From: "Sean E. Russell" Date: Mon, 2 Mar 2020 13:41:55 -0600 Subject: [PATCH] Workflow and documentation improvements. --- .github/workflows/release.yml | 4 ++-- README.md | 7 ++++--- cmd/gotop/main.go | 1 + 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 290717d..6390f46 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -19,7 +19,7 @@ jobs: with: token: ${{ secrets.REPO_ACCESS_TOKEN }} repository: xxxserxxx/homebrew-gotop - event-type: my-event + event-type: my-release client-payload: '{"tag": "${{ steps.tag_name.outputs.tag }}"}' - name: Update Arch AURs @@ -27,5 +27,5 @@ jobs: with: token: ${{ secrets.REPO_ACCESS_TOKEN }} repository: xxxserxxx/gotop-linux - event-type: my-event + event-type: my-release client-payload: '{"tag": "${{ steps.tag_name.outputs.tag }}"}' diff --git a/README.md b/README.md index 8ee6067..432188b 100644 --- a/README.md +++ b/README.md @@ -31,17 +31,18 @@ yay -S gotop-bin ### OSX -gotop can be installed with [Homebrew](https://brew.sh/); you'll need to tap the recipe. If you'd previously tapped cjbassi's recipe, you'll want to untap that first. +gotop can be installed with [Homebrew](https://brew.sh/); you'll need to tap the recipe. If you'd previously tapped cjbassi's recipe, you'll want to untap that first. The old version of gotop is also included in Homebrew's core library, and that will always be chosen before any taps, so you have to specify the tap specifically. ``` +brew uninstall gotop # If previously installed brew untap cjbassi/gotop # If previously tapped brew tap xxxserxxx/gotop -brew install gotop +brew install xxxserxxx/gotop ``` ### Prebuilt binaries -This doesn't require Go, is easy, and works across distributions. You have to manually upgrade the executable yourself, though. +This doesn't require Go, is easy, and works across distributions. You have to manually upgrade the executable yourself, though, so using your distribution's package (if one is available) is a better approach. Visit [the releases page](https://github.com/xxxserxxx/gotop/releases) with your web browser and download the appropriate file for your OS. Unzip it (the archive contains a single file) and then move the resulting `gotop` binary into your `$PATH` somewhere. If you're on a Debian or Redhat derivative, you can download an `.rpm` or `.deb` and install that. diff --git a/cmd/gotop/main.go b/cmd/gotop/main.go index 9ae093f..4ce78ba 100644 --- a/cmd/gotop/main.go +++ b/cmd/gotop/main.go @@ -51,6 +51,7 @@ var ( // TODO: state:deferred 157 FreeBSD fixes & Nvidia GPU support (kraust/master). Significant CPU use impact for NVidia changes. // TODO: Virtual devices from Prometeus metrics @feature // TODO: state:merge #167 configuration file (jrswab/configFile111) +// TODO: Abstract out the UI toolkit. mum4k/termdash, VladimirMarkelov/clui, gcla/gowid, rivo/tview, marcusolsson/tui-go might work better for some OS/Archs. Performance/memory use comparison would be interesting. func parseArgs(conf *gotop.Config) error { usage := ` Usage: gotop [options]