github-mirror/BookStack
github-mirror/BookStack
2
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2025-03-23 22:45:14 +08:00
Code Issues Actions4 Packages Projects Releases Wiki Activity

Fixed failing tests due to search highlighting changes

Browse Source
This commit is contained in:
Dan Brown 2021-11-13 13:43:41 +00:00
parent 2633b94deb
commit 221458ccfd
No known key found for this signature in database
GPG Key ID: 46D9F943C24A2EF9
2 changed files with 9 additions and 4 deletions
app/Entities/Tools
SearchIndex.php
tests/Entity
EntitySearchTest.php

2
app/Entities/Tools/SearchIndex.php

@ -223,7 +223,7 @@ class SearchIndex
if ($entity instanceof Page) {
$bodyTermsMap = $this->generateTermScoreMapFromHtml($entity->html);
} else {
$bodyTermsMap = $this->generateTermScoreMapFromText($entity->description, $entity->searchFactor);
$bodyTermsMap = $this->generateTermScoreMapFromText($entity->description ?? '', $entity->searchFactor);
}
$mergedScoreMap = $this->mergeTermScoreMaps($nameTermsMap, $bodyTermsMap, $tagTermsMap);

11
tests/Entity/EntitySearchTest.php

@ -18,15 +18,20 @@ class EntitySearchTest extends TestCase
$search = $this->asEditor()->get('/search?term=' . urlencode($page->name));
$search->assertSee('Search Results');
$search->assertSee($page->name);
$title = strip_tags($search->getElementHtml('.entity-list-item-name'));
$this->assertEquals($page->name, $title);
}
public function test_bookshelf_search()
{
$shelf = Bookshelf::first();
/** @var Bookshelf $shelf */
$shelf = Bookshelf::query()->first();
$search = $this->asEditor()->get('/search?term=' . urlencode(mb_substr($shelf->name, 0, 3)) . ' {type:bookshelf}');
$search->assertStatus(200);
$search->assertSee($shelf->name);
$title = strip_tags($search->getElementHtml('.entity-list-item-name'));
$this->assertEquals($shelf->name, $title);
}
public function test_invalid_page_search()