github-mirror/BookStack
2
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2024-11-22 12:30:27 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix too long function in BookController

Browse Source
This commit is contained in:
Fausztin Asztrik Virag 2024-07-19 22:36:41 +02:00
parent af02899f08
commit 5d17e991b6
1 changed files with 26 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
app/Entities/Controllers/BookController.php
View File

@ -40,20 +40,10 @@ class BookController extends Controller
public function index(Request $request)
{
$view = setting()->getForCurrentUser('books_view_type');
$listOptions = SimpleListOptions::fromRequest($request, 'books')->withSortOptions([
'name' => trans('common.sort_name'),
'created_at' => trans('common.sort_created_at'),
'updated_at' => trans('common.sort_updated_at'),
'view_count' => trans('common.sort_popularity'),
]);
$listOptions = $this->getListOptions($request);
$booksQuery = $this->queries->visibleForListWithCover();
if ($listOptions->getSort() === 'view_count') {
$booksQuery->scopes('withViewCount')->orderBy('view_count', $listOptions->getOrder());
} else {
$booksQuery->orderBy($listOptions->getSort(), $listOptions->getOrder());
}
$this->applySortOptions($booksQuery, $listOptions);
$books = $booksQuery->paginate(18);
@ -62,19 +52,37 @@ class BookController extends Controller
$new = $this->queries->visibleForList()->orderBy('created_at', 'desc')->take(4)->get();
$this->shelfContext->clearShelfContext();
$this->setPageTitle(trans('entities.books'));
return view('books.index', [
'books' => $books,
'recents' => $recents,
'popular' => $popular,
'new' => $new,
'view' => $view,
'books' => $books,
'recents' => $recents,
'popular' => $popular,
'new' => $new,
'view' => $view,
'listOptions' => $listOptions,
]);
}
private function getListOptions(Request $request): SimpleListOptions
{
return SimpleListOptions::fromRequest($request, 'books')->withSortOptions([
'name' => trans('common.sort_name'),
'created_at' => trans('common.sort_created_at'),
'updated_at' => trans('common.sort_updated_at'),
'view_count' => trans('common.sort_popularity'),
]);
}
private function applySortOptions($booksQuery, SimpleListOptions $listOptions): void
{
if ($listOptions->getSort() === 'view_count') {
$booksQuery->scopes('withViewCount')->orderBy('view_count', $listOptions->getOrder());
} else {
$booksQuery->orderBy($listOptions->getSort(), $listOptions->getOrder());
}
}
/**
* Show the form for creating a new book.
*/