github-mirror/BookStack
2
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2025-02-17 07:22:45 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Updated PR code to use isA and updated that function definition

Browse Source 
Related to #2227
This commit is contained in:
Dan Brown 2020-09-26 17:00:17 +01:00
parent fe0e307313
commit 68489e5b44
No known key found for this signature in database
GPG Key ID: 46D9F943C24A2EF9
2 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/Entities/Entity.php
View File

@ -201,12 +201,10 @@ class Entity extends Ownable
}
/**
* Allows checking of the exact class, Used to check entity type.
* Cleaner method for is_a.
* @param $type
* @return bool
* Check if this instance or class is a certain type of entity.
* Examples of $type are 'page', 'book', 'chapter'
*/
public static function isA($type)
public static function isA(string $type): bool
{
return static::getType() === strtolower($type);
}

2
app/Entities/Managers/BookContents.php
View File

@ -62,7 +62,7 @@ class BookContents
$all->each(function (Entity $entity) use ($renderPages) {
$entity->setRelation('book', $this->book);
if ($renderPages && get_class($entity) == 'BookStack\Entities\Page') {
if ($renderPages && $entity->isA('page')) {
$entity->html = (new PageContent($entity))->render();
}
});