ZIP Imports/Exports: Fixed some lint and test issues
Some checks failed
analyse-php / build (push) Waiting to run
lint-php / build (push) Waiting to run
test-migrations / build (8.1) (push) Waiting to run
test-migrations / build (8.2) (push) Waiting to run
test-migrations / build (8.3) (push) Waiting to run
test-php / build (8.1) (push) Waiting to run
test-php / build (8.2) (push) Waiting to run
test-php / build (8.3) (push) Waiting to run
lint-js / build (push) Has been cancelled
test-js / build (push) Has been cancelled

- Updated test handling to create imports folder when required.
- Updated some tests to delete created import zip files.
This commit is contained in:
Dan Brown 2024-11-25 16:23:59 +00:00
parent 9ecc91929a
commit 95d62e7f57
No known key found for this signature in database
GPG Key ID: 46D9F943C24A2EF9
4 changed files with 17 additions and 3 deletions

View File

@ -30,7 +30,7 @@ export {HeaderMobileToggle} from './header-mobile-toggle';
export {ImageManager} from './image-manager';
export {ImagePicker} from './image-picker';
export {ListSortControl} from './list-sort-control';
export {LoadingButton} from './loading-button';
export {LoadingButton} from './loading-button.ts';
export {MarkdownEditor} from './markdown-editor';
export {NewUserPassword} from './new-user-password';
export {Notification} from './notification';

View File

@ -93,7 +93,6 @@ export class PageComments extends Component {
updateCount() {
const count = this.getCommentCount();
console.log('update count', count, this.container);
this.commentsTitle.textContent = window.$trans.choice(this.countText, count, {count});
}

View File

@ -168,6 +168,8 @@ class ZipImportTest extends TestCase
$resp->assertRedirect("/import/{$import->id}");
$this->assertFileExists(storage_path($import->path));
$this->assertActivityExists(ActivityType::IMPORT_CREATE);
ZipTestHelper::deleteZipForImport($import);
}
public function test_import_show_page()
@ -325,6 +327,8 @@ class ZipImportTest extends TestCase
$resp = $this->followRedirects($resp);
$resp->assertSeeText('The name field is required.');
$resp->assertSeeText('The id must be an integer.');
ZipTestHelper::deleteZipForImport($import);
}
public function test_run_checks_permissions_on_import()
@ -340,6 +344,8 @@ class ZipImportTest extends TestCase
$resp = $this->followRedirects($resp);
$resp->assertSeeText('You are lacking the required permissions to create books.');
ZipTestHelper::deleteZipForImport($import);
}
public function test_run_requires_parent_for_chapter_and_page_imports()
@ -379,6 +385,8 @@ class ZipImportTest extends TestCase
$resp = $this->followRedirects($resp);
$resp->assertSee('Parent book required for chapter import.');
ZipTestHelper::deleteZipForImport($import);
}
protected function runImportFromFile(UploadedFile $file): TestResponse

View File

@ -20,7 +20,14 @@ class ZipTestHelper
$import = Import::factory()->create($importData);
$zip = static::zipUploadFromData($zipData, $files);
rename($zip->getRealPath(), storage_path($import->path));
$targetPath = storage_path($import->path);
$targetDir = dirname($targetPath);
if (!file_exists($targetDir)) {
mkdir($targetDir);
}
rename($zip->getRealPath(), $targetPath);
return $import;
}