github-mirror/BookStack
2
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2024-11-22 06:38:26 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Testing: Added PHP8.3 support

Browse Source 
Also fixed text which could through deprecation notice due to not having
a properly formed comment in use.
For #4633
This commit is contained in:
Dan Brown 2023-10-31 15:50:56 +00:00
parent c640db8434
commit fce7190257
No known key found for this signature in database
GPG Key ID: 46D9F943C24A2EF9
3 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/test-migrations.yml vendored
View File

@ -16,7 +16,7 @@ jobs:
runs-on: ubuntu-22.04
strategy:
matrix:
php: ['8.0', '8.1', '8.2']
php: ['8.0', '8.1', '8.2', '8.3']
steps:
- uses: actions/checkout@v1

2
.github/workflows/test-php.yml vendored
View File

@ -16,7 +16,7 @@ jobs:
runs-on: ubuntu-22.04
strategy:
matrix:
php: ['8.0', '8.1', '8.2']
php: ['8.0', '8.1', '8.2', '8.3']
steps:
- uses: actions/checkout@v1

5
tests/Activity/WatchTest.php
View File

@ -336,7 +336,10 @@ class WatchTest extends TestCase
$activities = [
ActivityType::PAGE_CREATE => $entities['page'],
ActivityType::PAGE_UPDATE => $entities['page'],
ActivityType::COMMENT_CREATE => (new Comment([]))->forceFill(['entity_id' => $entities['page']->id, 'entity_type' => $entities['page']->getMorphClass()]),
ActivityType::COMMENT_CREATE => Comment::factory()->make([
'entity_id' => $entities['page']->id,
'entity_type' => $entities['page']->getMorphClass(),
]),
];
$notifications = Notification::fake();