github-mirror/caddy
2
0
Fork 0
mirror of https://github.com/caddyserver/caddy.git synced 2025-01-19 07:12:45 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Revert "requestbody: Allow overwriting remote address"

Browse Source 
This reverts commit 0bf2046da7.

No actual use case.
This commit is contained in:
Matthew Holt 2021-01-11 13:35:12 -07:00
parent 160d199999
commit 1ac6351705
No known key found for this signature in database
GPG Key ID: 2A349DD577D586A5
1 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
modules/caddyhttp/requestbody/requestbody.go
View File

@ -29,11 +29,6 @@ func init() {
type RequestBody struct {
// The maximum number of bytes to allow reading from the body by a later handler.
MaxSize int64 `json:"max_size,omitempty"`
// Overwrites the remote address from which the request came. This is destructive;
// handlers later in the chain will not be able to recover the true originating
// address of the request. EXPERIMENTAL: May get changed or removed later.
RemoteAddress string `json:"remote_address,omitempty"`
}
// CaddyModule returns the Caddy module information.
@ -45,10 +40,6 @@ func (RequestBody) CaddyModule() caddy.ModuleInfo {
}
func (rb RequestBody) ServeHTTP(w http.ResponseWriter, r *http.Request, next caddyhttp.Handler) error {
if rb.RemoteAddress != "" {
repl := r.Context().Value(caddy.ReplacerCtxKey).(*caddy.Replacer)
r.RemoteAddr = repl.ReplaceAll(rb.RemoteAddress, "")
}
if r.Body == nil {
return next.ServeHTTP(w, r)
}