github-mirror/caddy
github-mirror/caddy
2
0
Fork 0
mirror of https://github.com/caddyserver/caddy.git synced 2025-02-21 19:07:26 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Allow duplicate Server headers when proxying response

Browse Source 
See discussion on commit c9b022b5e0384ab97812366aade0bb34304459af

If we overwrite the Server header, it becomes difficult/impossible to
know from the client whether the request was proxied through Caddy.
This commit is contained in:
Matthew Holt 2017-06-27 12:10:03 -06:00
parent 7b5efb5d75
commit 43b56d621b
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
caddyhttp/proxy/reverseproxy.go
View File

@ -413,8 +413,12 @@ func copyHeader(dst, src http.Header) {
if _, shouldSkip := skipHeaders[k]; shouldSkip {
continue
}
// otherwise, overwrite
dst.Del(k)
// otherwise, overwrite to avoid duplicated fields that can be
// problematic (see issue #1086) -- however, allow duplicate
// Server fields so we can see the reality of the proxying.
if k != "Server" {
dst.Del(k)
}
}
for _, v := range vv {
dst.Add(k, v)