From 817470dd66edb22015651971e39f8ef183d7bf9d Mon Sep 17 00:00:00 2001 From: Matthew Holt Date: Mon, 24 Oct 2022 12:18:32 -0600 Subject: [PATCH] httploader: Close resp body on bad status code Related to #5158 --- caddyconfig/httploader.go | 1 + 1 file changed, 1 insertion(+) diff --git a/caddyconfig/httploader.go b/caddyconfig/httploader.go index 04dec34f1..7c4dc2319 100644 --- a/caddyconfig/httploader.go +++ b/caddyconfig/httploader.go @@ -124,6 +124,7 @@ func attemptHttpCall(client *http.Client, request *http.Request) (*http.Response if err != nil { return nil, fmt.Errorf("problem calling http loader url: %v", err) } else if resp.StatusCode < 200 || resp.StatusCode > 499 { + resp.Body.Close() return nil, fmt.Errorf("bad response status code from http loader url: %v", resp.StatusCode) } return resp, nil