github-mirror/caddy
2
0
Fork 0
mirror of https://github.com/caddyserver/caddy.git synced 2024-11-23 06:36:16 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

caddyhttp: Log non-500 handler errors at debug level (#4429)

Browse Source 
Fixes #4428

It's best to still log handler errors at debug level so that they're hidden by default, but still accessible if additional details are necessary.
This commit is contained in:
Francis Lavoie 2021-11-22 13:58:25 -05:00 committed by GitHub
parent 7d5047c1f1
commit eead337324
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
modules/caddyhttp/server.go
View File

@ -244,6 +244,8 @@ func (s *Server) ServeHTTP(w http.ResponseWriter, r *http.Request) {
// successfully, so now just log the error // successfully, so now just log the error
if errStatus >= 500 { if errStatus >= 500 {
logger.Error(errMsg, errFields...) logger.Error(errMsg, errFields...)
} else {
logger.Debug(errMsg, errFields...)
} }
} else { } else {
// well... this is awkward // well... this is awkward
@ -262,6 +264,8 @@ func (s *Server) ServeHTTP(w http.ResponseWriter, r *http.Request) {
} else { } else {
if errStatus >= 500 { if errStatus >= 500 {
logger.Error(errMsg, errFields...) logger.Error(errMsg, errFields...)
} else {
logger.Debug(errMsg, errFields...)
} }
w.WriteHeader(errStatus) w.WriteHeader(errStatus)
} }