v2: only compare TLS protocol versions if both are set (#3005)

This commit is contained in:
Mohammed Al Sahaf 2020-02-03 19:25:32 +03:00 committed by GitHub
parent 8b2ad61220
commit f74fed3f54
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -222,15 +222,15 @@ func (p *ConnectionPolicy) buildStandardTLSConfig(ctx caddy.Context) error {
}
// min and max protocol versions
if (p.ProtocolMin != "" && p.ProtocolMax != "") && p.ProtocolMin > p.ProtocolMax {
return fmt.Errorf("protocol min (%x) cannot be greater than protocol max (%x)", p.ProtocolMin, p.ProtocolMax)
}
if p.ProtocolMin != "" {
cfg.MinVersion = SupportedProtocols[p.ProtocolMin]
}
if p.ProtocolMax != "" {
cfg.MaxVersion = SupportedProtocols[p.ProtocolMax]
}
if p.ProtocolMin > p.ProtocolMax {
return fmt.Errorf("protocol min (%x) cannot be greater than protocol max (%x)", p.ProtocolMin, p.ProtocolMax)
}
// client authentication
if p.ClientAuthentication != nil {