mirror of
https://github.com/caddyserver/caddy.git
synced 2024-11-26 02:09:47 +08:00
3d43c5b697
================== WARNING: DATA RACE Write at 0x00c42049d300 by goroutine 26: github.com/mholt/caddy/caddytls.standaloneTLSTicketKeyRotation() /home/tw/golib/src/github.com/mholt/caddy/caddytls/crypto.go:230 +0x698 Previous read at 0x00c42049d300 by goroutine 25: github.com/mholt/caddy/caddytls.TestStandaloneTLSTicketKeyRotation() /home/tw/golib/src/github.com/mholt/caddy/caddytls/crypto_test.go:113 +0x413 testing.tRunner() /home/tw/goroot/src/testing/testing.go:610 +0xc9 Goroutine 26 (running) created at: github.com/mholt/caddy/caddytls.TestStandaloneTLSTicketKeyRotation() /home/tw/golib/src/github.com/mholt/caddy/caddytls/crypto_test.go:101 +0x2a4 testing.tRunner() /home/tw/goroot/src/testing/testing.go:610 +0xc9 Goroutine 25 (running) created at: testing.(*T).Run() /home/tw/goroot/src/testing/testing.go:646 +0x52f testing.RunTests.func1() /home/tw/goroot/src/testing/testing.go:793 +0xb9 testing.tRunner() /home/tw/goroot/src/testing/testing.go:610 +0xc9 testing.RunTests() /home/tw/goroot/src/testing/testing.go:799 +0x4b5 testing.(*M).Run() /home/tw/goroot/src/testing/testing.go:743 +0x12f github.com/mholt/caddy/caddytls.TestMain() /home/tw/golib/src/github.com/mholt/caddy/caddytls/setup_test.go:27 +0x133 main.main() github.com/mholt/caddy/caddytls/_test/_testmain.go:116 +0x1b1 ================== ================== WARNING: DATA RACE Write at 0x00c4204aa6c0 by goroutine 26: github.com/mholt/caddy/caddytls.TestStandaloneTLSTicketKeyRotation.func2() /home/tw/golib/src/github.com/mholt/caddy/caddytls/crypto_test.go:93 +0x56 github.com/mholt/caddy/caddytls.standaloneTLSTicketKeyRotation() /home/tw/golib/src/github.com/mholt/caddy/caddytls/crypto.go:233 +0x638 Previous read at 0x00c4204aa6c0 by goroutine 25: github.com/mholt/caddy/caddytls.TestStandaloneTLSTicketKeyRotation() /home/tw/golib/src/github.com/mholt/caddy/caddytls/crypto_test.go:108 +0x391 testing.tRunner() /home/tw/goroot/src/testing/testing.go:610 +0xc9 Goroutine 26 (running) created at: github.com/mholt/caddy/caddytls.TestStandaloneTLSTicketKeyRotation() /home/tw/golib/src/github.com/mholt/caddy/caddytls/crypto_test.go:101 +0x2a4 testing.tRunner() /home/tw/goroot/src/testing/testing.go:610 +0xc9 Goroutine 25 (running) created at: testing.(*T).Run() /home/tw/goroot/src/testing/testing.go:646 +0x52f testing.RunTests.func1() /home/tw/goroot/src/testing/testing.go:793 +0xb9 testing.tRunner() /home/tw/goroot/src/testing/testing.go:610 +0xc9 testing.RunTests() /home/tw/goroot/src/testing/testing.go:799 +0x4b5 testing.(*M).Run() /home/tw/goroot/src/testing/testing.go:743 +0x12f github.com/mholt/caddy/caddytls.TestMain() /home/tw/golib/src/github.com/mholt/caddy/caddytls/setup_test.go:27 +0x133 main.main() github.com/mholt/caddy/caddytls/_test/_testmain.go:116 +0x1b1 ================== Signed-off-by: Tw <tw19881113@gmail.com>
136 lines
3.1 KiB
Go
136 lines
3.1 KiB
Go
package caddytls
|
|
|
|
import (
|
|
"bytes"
|
|
"crypto"
|
|
"crypto/ecdsa"
|
|
"crypto/elliptic"
|
|
"crypto/rand"
|
|
"crypto/rsa"
|
|
"crypto/tls"
|
|
"crypto/x509"
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
func TestSaveAndLoadRSAPrivateKey(t *testing.T) {
|
|
privateKey, err := rsa.GenerateKey(rand.Reader, 128) // make tests faster; small key size OK for testing
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// test save
|
|
savedBytes, err := savePrivateKey(privateKey)
|
|
if err != nil {
|
|
t.Fatal("error saving private key:", err)
|
|
}
|
|
|
|
// test load
|
|
loadedKey, err := loadPrivateKey(savedBytes)
|
|
if err != nil {
|
|
t.Error("error loading private key:", err)
|
|
}
|
|
|
|
// verify loaded key is correct
|
|
if !PrivateKeysSame(privateKey, loadedKey) {
|
|
t.Error("Expected key bytes to be the same, but they weren't")
|
|
}
|
|
}
|
|
|
|
func TestSaveAndLoadECCPrivateKey(t *testing.T) {
|
|
privateKey, err := ecdsa.GenerateKey(elliptic.P384(), rand.Reader)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// test save
|
|
savedBytes, err := savePrivateKey(privateKey)
|
|
if err != nil {
|
|
t.Fatal("error saving private key:", err)
|
|
}
|
|
|
|
// test load
|
|
loadedKey, err := loadPrivateKey(savedBytes)
|
|
if err != nil {
|
|
t.Error("error loading private key:", err)
|
|
}
|
|
|
|
// verify loaded key is correct
|
|
if !PrivateKeysSame(privateKey, loadedKey) {
|
|
t.Error("Expected key bytes to be the same, but they weren't")
|
|
}
|
|
}
|
|
|
|
// PrivateKeysSame compares the bytes of a and b and returns true if they are the same.
|
|
func PrivateKeysSame(a, b crypto.PrivateKey) bool {
|
|
return bytes.Equal(PrivateKeyBytes(a), PrivateKeyBytes(b))
|
|
}
|
|
|
|
// PrivateKeyBytes returns the bytes of DER-encoded key.
|
|
func PrivateKeyBytes(key crypto.PrivateKey) []byte {
|
|
var keyBytes []byte
|
|
switch key := key.(type) {
|
|
case *rsa.PrivateKey:
|
|
keyBytes = x509.MarshalPKCS1PrivateKey(key)
|
|
case *ecdsa.PrivateKey:
|
|
keyBytes, _ = x509.MarshalECPrivateKey(key)
|
|
}
|
|
return keyBytes
|
|
}
|
|
|
|
func TestStandaloneTLSTicketKeyRotation(t *testing.T) {
|
|
type syncPkt struct {
|
|
ticketKey [32]byte
|
|
keysInUse int
|
|
}
|
|
|
|
tlsGovChan := make(chan struct{})
|
|
defer close(tlsGovChan)
|
|
callSync := make(chan *syncPkt, 1)
|
|
defer close(callSync)
|
|
|
|
oldHook := setSessionTicketKeysTestHook
|
|
defer func() {
|
|
setSessionTicketKeysTestHook = oldHook
|
|
}()
|
|
setSessionTicketKeysTestHook = func(keys [][32]byte) [][32]byte {
|
|
callSync <- &syncPkt{keys[0], len(keys)}
|
|
return keys
|
|
}
|
|
|
|
c := new(tls.Config)
|
|
timer := time.NewTicker(time.Millisecond * 1)
|
|
|
|
go standaloneTLSTicketKeyRotation(c, timer, tlsGovChan)
|
|
|
|
rounds := 0
|
|
var lastTicketKey [32]byte
|
|
for {
|
|
select {
|
|
case pkt := <-callSync:
|
|
if lastTicketKey == pkt.ticketKey {
|
|
close(tlsGovChan)
|
|
t.Errorf("The same TLS ticket key has been used again (not rotated): %x.", lastTicketKey)
|
|
return
|
|
}
|
|
lastTicketKey = pkt.ticketKey
|
|
rounds++
|
|
if rounds <= NumTickets && pkt.keysInUse != rounds {
|
|
close(tlsGovChan)
|
|
t.Errorf("Expected TLS ticket keys in use: %d; Got instead: %d.", rounds, pkt.keysInUse)
|
|
return
|
|
}
|
|
if c.SessionTicketsDisabled == true {
|
|
t.Error("Session tickets have been disabled unexpectedly.")
|
|
return
|
|
}
|
|
if rounds >= NumTickets+1 {
|
|
return
|
|
}
|
|
case <-time.After(time.Second * 1):
|
|
t.Errorf("Timeout after %d rounds.", rounds)
|
|
return
|
|
}
|
|
}
|
|
}
|