discourse/spec/components/html_prettify_spec.rb

# frozen_string_literal: true

require 'rails_helper'
require 'html_prettify'

describe HtmlPrettify do

  def t(source, expected)
    expect(HtmlPrettify.render(source)).to eq(expected)
  end

  it 'correctly prettifies html' do
    t "<p>All's well!</p>", "<p>All&rsquo;s well!</p>"
    t "<p>Eatin' Lunch'.</p>", "<p>Eatin&rsquo; Lunch&rsquo;.</p>"
    t "<p>a 1/4. is a fraction but not 1/4/2000</p>", "<p>a &frac14;. is a fraction but not 1/4/2000</p>"
    t "<p>Well that'll be the day</p>", "<p>Well that&rsquo;ll be the day</p>"
    t %(<p>"Quoted text"</p>), %(<p>&ldquo;Quoted text&rdquo;</p>)
    t "<p>I've been meaning to tell you ..</p>", "<p>I&rsquo;ve been meaning to tell you ..</p>"
    t "<p>single `backticks` in HTML should be preserved</p>", "<p>single `backticks` in HTML should be preserved</p>"
    t "<p>double hyphen -- ndash --- mdash</p>", "<p>double hyphen &ndash; ndash &mdash; mdash</p>"
    t "a long time ago...", "a long time ago&hellip;"
    t "is 'this a mistake'?", "is &lsquo;this a mistake&rsquo;?"
    t ERB::Util.html_escape("'that went well'"), "&lsquo;that went well&rsquo;"
    t '"that went well"', "&ldquo;that went well&rdquo;"
    t ERB::Util.html_escape('"that went well"'), "&ldquo;that went well&rdquo;"

    t 'src="test.png"&gt; yay', "src=&ldquo;test.png&rdquo;&gt; yay"

    t '\\\\mnt\\c', "\\\\mnt\\c"

    t ERB::Util.html_escape('<img src="test.png"> yay'), "&lt;img src=&ldquo;test.png&rdquo;&gt; yay"
  end

end
DEV: use #frozen_string_literal: true on all spec This change both speeds up specs (less strings to allocate) and helps catch cases where methods in Discourse are mutating inputs. Overall we will be migrating everything to use #frozen_string_literal: true it will take a while, but this is the first and safest move in this direction 2019-04-30 08:27:42 +08:00			`# frozen_string_literal: true`

Prepare for separation of RSpec helper files Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails. 2015-10-11 17:41:23 +08:00			`require 'rails_helper'`
FEATURE: remove dependency of Redcarpet PERF: cache fancy_title in topics table New pure ruby implementation is far more flexible and easier to amend. 2015-09-24 11:37:53 +08:00			`require 'html_prettify'`

			`describe HtmlPrettify do`

			`def t(source, expected)`
			`expect(HtmlPrettify.render(source)).to eq(expected)`
			`end`

			`it 'correctly prettifies html' do`
			`t "<p>All's well!</p>", "<p>All’s well!</p>"`
			`t "<p>Eatin' Lunch'.</p>", "<p>Eatin’ Lunch’.</p>"`
			`t "<p>a 1/4. is a fraction but not 1/4/2000</p>", "<p>a ¼. is a fraction but not 1/4/2000</p>"`
			`t "<p>Well that'll be the day</p>", "<p>Well that’ll be the day</p>"`
			`t %(<p>"Quoted text"</p>), %(<p>“Quoted text”</p>)`
			`t "<p>I've been meaning to tell you ..</p>", "<p>I’ve been meaning to tell you ..</p>"`
			t "<p>single `backticks` in HTML should be preserved</p>", "<p>single `backticks` in HTML should be preserved</p>"
			`t "<p>double hyphen -- ndash --- mdash</p>", "<p>double hyphen – ndash — mdash</p>"`
			`t "a long time ago...", "a long time ago…"`
			`t "is 'this a mistake'?", "is ‘this a mistake’?"`
			`t ERB::Util.html_escape("'that went well'"), "‘that went well’"`
			`t '"that went well"', "“that went well”"`
			`t ERB::Util.html_escape('"that went well"'), "“that went well”"`

			`t 'src="test.png"> yay', "src=“test.png”> yay"`

FEATURE: stop escaping special chars in title prettify This feature is confusting and just leads to inconsistency 2017-03-13 22:02:20 +08:00			`t '\\\\mnt\\c', "\\\\mnt\\c"`

FEATURE: remove dependency of Redcarpet PERF: cache fancy_title in topics table New pure ruby implementation is far more flexible and easier to amend. 2015-09-24 11:37:53 +08:00			`t ERB::Util.html_escape('<img src="test.png"> yay'), "<img src=“test.png”> yay"`
			`end`

			`end`